Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
Ok, thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1784#issuecomment-372100797
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
Closed #1784. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1784#event-1514966210
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
OK I found the root cause of the issue, which actually is a problem on our side. See #1799 for details and a fix. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1784#issuecomment-372073501
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
@b4n: thanks for the info. I also played around with the cursor a bit. I managed to use it as a replacement but also noticed that it does not make any difference. Setting selection mode to none also does not help. > Obviously we can't filter anymore, but the selection/cursor doesn't jump > around anymore. Interesting. Will have a look too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1784#issuecomment-372009322
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
> Also, we really should be using the treeview's cursor rather than the > selection, but well. I haven't used cursors yet. How should it be used? Somewhat like this: - on clicking a checkbox in the pluing manager set the cursor to the path given to ```pm_plugin_toggled()``` - in ```pm_on_plugin_button_clicked``` get the current cursor instead of the selection to determine which row/plugin is active/to be called Do we need to track ```cursor-changed```? Can the user change the cursor position if we do not have any editable cells? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1784#issuecomment-371819439
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
@LarsGit223 pushed 1 commit. 9e49575 plugin-manager: protect call to help function with NULL pointer check -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/1784/files/c25188fc101149b07cf6a8773ee20bf3f78290f9..9e49575342bd793db379db365bbf67f6dc463a13
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
> I think that first of all we should fix the code so that it doesn't only rely > on the UI being insensitive not to crash. Yes, both keybindings and preferences buttons don't seem to suffer the problem, probably because of a similar test. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1784#issuecomment-371743728
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
I think that first of all we should fix the code so that it doesn't only rely
on the UI being insensitive not to crash. At least, do something like this:
```diff
diff --git a/src/plugins.c b/src/plugins.c
index 32a0ee891..c036ea0dd 100644
--- a/src/plugins.c
+++ b/src/plugins.c
@@ -1865,7 +1865,10 @@ static void pm_on_plugin_button_clicked(G_GNUC_UNUSED
GtkButton *button, gpointe
if (GPOINTER_TO_INT(user_data) == PM_BUTTON_CONFIGURE)
plugin_show_configure(>public);
else if (GPOINTER_TO_INT(user_data) == PM_BUTTON_HELP)
+{
+g_return_if_fail(p->cbs.help != NULL);
p->cbs.help(>public, p->cb_data);
+}
else if (GPOINTER_TO_INT(user_data) == PM_BUTTON_KEYBINDINGS &&
p->key_group && p->key_group->plugin_key_count > 0)
keybindings_dialog_show_prefs_scroll(p->info.name);
}
```
Then, I'll try and play with this to see if we're not doing something wrong
somewhere, because it looks like a very odd bug, and it only happens when
double-clicking on the checkmark. Also, we really should be using the
treeview's cursor rather than the selection, but well.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1784#issuecomment-371670845
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
I haven't thoroughly reviewed or tested the code, but I have absolutely no objection over merging it nice and early in the release cycle. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1784#issuecomment-371670170
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
LGBI I havn't had a chance to test it, but yeah, in the face of a GTK bug a workaround is needed because even if the problem is fixed there are buggy versions in the wild already. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1784#issuecomment-371639445
Re: [Github-comments] [geany/geany] plugin-manager: sync buttons on "button-release-event" (#1784)
I think the workaround is acceptable. @elextr @b4n @codebrainz any objections? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1784#issuecomment-371514744
