I am closing this ion favour of PR #750.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-394800377
Closed #697.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#event-1664336274
I will not merge it when disabling Gtk2 without suitable replacement for Gtk2
users
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-373939746
@frlan: please don't merge this yet as there is still an open discussion how to
proceed regarding GTK2 and GTK3 support.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@elextr: no, the changes are only regarding GTK3 and VTE compatibility.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-368261597
@Skif-off To be even more explicit, geany will still support gtk2, its just the
changes in this PR make this plugin gtk3 only. Which is why I keep repeating
myself that it should be a separate plugin so it leaves the GTK2 version
available for those lucky people where it does not hang Geany.
@LarsGit223
Thanks, I was confused by the
[GP_CHECK_PLUGIN_GTK**3_ONLY**](https://github.com/geany/geany-plugins/pull/697/files#diff-c6ec9ad09f6351d19420270032720e7eR4).
P.S. I use Xubuntu 17.10, but I compile on my own (I use [PR
1752](https://github.com/geany/geany/pull/1752)) and [I don't
To be explicit: Geany will still support GTK2. It will not be dropped.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-368228470
@Skif-off:
No. By default geany compiles/is built for GTK2. If you specify the option
```--enable-gtk3``` on build then it will be build for GTK3. Then only plugins
would work with that version of geany which support GTK3.
Which OS/distro do you use? Many linux distros support both GTK
@LarsGit223
Sorry, I didn't understand :) Is Geany drop to support GTK2?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-368226268
@Skif-off: no. As the PR is right now, it would only support GTK3.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-368225208
@LarsGit223
Why ```GP_CHECK_PLUGIN_GTK3_ONLY```? Is plugin don't support build with GTK2
now?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-368225063
12 matches
Mail list logo