Re: [Github-comments] [geany/geany-plugins] treebrowser: removed needless Gtk version checks (#723)

2018-03-12 Thread LarsGit223 
LarsGit223 commented on this pull request.



> @@ -138,11 +138,7 @@ PLUGIN_SET_TRANSLATABLE_INFO(
 static GList*
 _gtk_cell_layout_get_cells(GtkTreeViewColumn *column)
 {
-#if GTK_CHECK_VERSION(2, 12, 0)

Done in #725.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/723#discussion_r173771983

Re: [Github-comments] [geany/geany-plugins] treebrowser: removed needless Gtk version checks (#723)

2018-03-11 Thread Matthew Brush 
codebrainz commented on this pull request.



> @@ -138,11 +138,7 @@ PLUGIN_SET_TRANSLATABLE_INFO(
 static GList*
 _gtk_cell_layout_get_cells(GtkTreeViewColumn *column)
 {
-#if GTK_CHECK_VERSION(2, 12, 0)

Why not remove this whole function? It looks like it was only added for 
backwards compatibility pre-2.12, and has a confusing name.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/723#pullrequestreview-102884524

Re: [Github-comments] [geany/geany-plugins] treebrowser: removed needless Gtk version checks (#723)

2018-03-11 Thread Frank Lanitz 
Merged #723.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/723#event-1515019753