[GitHub] [arrow] github-actions[bot] commented on issue #6985: ARROW-8413: [C++][WIP] Refactor Generating validity bitmap for values column

2020-04-19 Thread GitBox
github-actions[bot] commented on issue #6985: URL: https://github.com/apache/arrow/pull/6985#issuecomment-616252267 https://issues.apache.org/jira/browse/ARROW-8413 This is an automated message from the Apache Git Service.

[GitHub] [arrow] kou commented on issue #6983: ARROW-8519: [C++][Packaging] Reduce disk usage for external projects

2020-04-19 Thread GitBox
kou commented on issue #6983: URL: https://github.com/apache/arrow/pull/6983#issuecomment-616273563 @github-actions crossbow submit debian-buster-amd64 This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] cyb70289 commented on a change in pull request #6954: ARROW-8440: [C++] Refine SIMD header files

2020-04-19 Thread GitBox
cyb70289 commented on a change in pull request #6954: URL: https://github.com/apache/arrow/pull/6954#discussion_r411062264 ## File path: cpp/cmake_modules/DefineOptions.cmake ## @@ -101,7 +101,6 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

[GitHub] [arrow] kou commented on issue #6983: ARROW-8519: [C++][Packaging] Reduce disk usage for external projects

2020-04-19 Thread GitBox
kou commented on issue #6983: URL: https://github.com/apache/arrow/pull/6983#issuecomment-616287781 @github-actions crossbow submit -g linux -g linux-arm This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] cyb70289 commented on issue #6986: ARROW-8523: [C++] Optimize BitmapReader

2020-04-19 Thread GitBox
cyb70289 commented on issue #6986: URL: https://github.com/apache/arrow/pull/6986#issuecomment-616294784 I forgot to add jira no in the first commit, modified later. Looks jira status is not synced with this PR. Shall I abandon and push a new PR?

[GitHub] [arrow] jianxind commented on a change in pull request #6954: ARROW-8440: [C++] Refine SIMD header files

2020-04-19 Thread GitBox
jianxind commented on a change in pull request #6954: URL: https://github.com/apache/arrow/pull/6954#discussion_r411045620 ## File path: cpp/cmake_modules/DefineOptions.cmake ## @@ -101,7 +101,6 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

[GitHub] [arrow] wesm commented on issue #6386: ARROW-7800 [Python] Create record batch reader interface on FileReader

2020-04-19 Thread GitBox
wesm commented on issue #6386: URL: https://github.com/apache/arrow/pull/6386#issuecomment-616271391 @wjones1 I'll close this in favor of your PR. You can always collaborate together there This is an automated message from

[GitHub] [arrow] kou commented on issue #6983: ARROW-8519: [C++][Packaging] Reduce disk usage for external projects

2020-04-19 Thread GitBox
kou commented on issue #6983: URL: https://github.com/apache/arrow/pull/6983#issuecomment-616277711 @github-actions crossbow submit debian-buster-amd64 This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] github-actions[bot] commented on issue #6983: ARROW-8519: [C++][Packaging] Reduce disk usage for external projects

2020-04-19 Thread GitBox
github-actions[bot] commented on issue #6983: URL: https://github.com/apache/arrow/pull/6983#issuecomment-616277957 Revision: 75c7495f4df6b2c08388df1f4dc708bbc6a04ecd Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] github-actions[bot] commented on issue #6983: ARROW-8519: [C++][Packaging] Reduce disk usage for external projects

2020-04-19 Thread GitBox
github-actions[bot] commented on issue #6983: URL: https://github.com/apache/arrow/pull/6983#issuecomment-616288123 Revision: eacd0de2a127048bc69c3926a75ea2337d1b00df Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] wesm commented on issue #6967: ARROW-8499: [C++][Dataset] In ScannerBuilder, batch_size will not wor…

2020-04-19 Thread GitBox
wesm commented on issue #6967: URL: https://github.com/apache/arrow/pull/6967#issuecomment-616288112 As a matter of principle, functional correctness needs to be validated by tests. If you don't test then something that is working, but not tested, may stop working as the result of

[GitHub] [arrow] cyb70289 opened a new pull request #6986: [C++] Optimize BitmapReader

2020-04-19 Thread GitBox
cyb70289 opened a new pull request #6986: URL: https://github.com/apache/arrow/pull/6986 Replacing bit offset with bit mask improves about 15% performance with gcc-7.5. Arm64 servers have similar performance uplift. clang-9 doesn't benefit from this change. Below are

[GitHub] [arrow] github-actions[bot] commented on issue #6986: ARROW-8523: [C++] Optimize BitmapReader

2020-04-19 Thread GitBox
github-actions[bot] commented on issue #6986: URL: https://github.com/apache/arrow/pull/6986#issuecomment-616295380 https://issues.apache.org/jira/browse/ARROW-8523 This is an automated message from the Apache Git Service.

[GitHub] [arrow] kou commented on issue #6983: ARROW-8519: [C++][Packaging] Reduce disk usage for external projects

2020-04-19 Thread GitBox
kou commented on issue #6983: URL: https://github.com/apache/arrow/pull/6983#issuecomment-616264904 @github-actions crossbow submit debian-buster-amd64 ubuntu-eoan-amd64 ubuntu-focal-amd64 This is an automated message from

[GitHub] [arrow] zhztheplayer commented on issue #6967: ARROW-8499: [C++][Dataset] In ScannerBuilder, batch_size will not wor…

2020-04-19 Thread GitBox
zhztheplayer commented on issue #6967: URL: https://github.com/apache/arrow/pull/6967#issuecomment-616276272 > Unit test possible? Is unit test always required for a quick fix like this? I thought this may belong to the kind of changes that could be easily proved right.

[GitHub] [arrow] emkornfield opened a new pull request #6987: ARROW-8515: [C++] Bitmap::ToString should group by bytes

2020-04-19 Thread GitBox
emkornfield opened a new pull request #6987: URL: https://github.com/apache/arrow/pull/6987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above