tobim opened a new pull request #7038:
URL: https://github.com/apache/arrow/pull/7038
Converts local constants in `file_serialize_test.cc` to snake_case.
Fixes a confilct with the `PAGE_SIZE` macro declared in the `limits.h`
header that is shipped with musl libc.
--
github-actions[bot] commented on pull request #7038:
URL: https://github.com/apache/arrow/pull/7038#issuecomment-619346808
https://issues.apache.org/jira/browse/ARROW-8593
This is an automated message from the Apache Git Serv
rollokb commented on a change in pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#discussion_r415027375
##
File path: python/pyarrow/tests/test_parquet.py
##
@@ -179,6 +179,99 @@ def alltypes_sample(size=1, seed=0, categorical=False):
@pytest.mark.pan
gramirezespinoza opened a new pull request #7039:
URL: https://github.com/apache/arrow/pull/7039
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
github-actions[bot] commented on pull request #7039:
URL: https://github.com/apache/arrow/pull/7039#issuecomment-619367004
https://issues.apache.org/jira/browse/ARROW-8513
This is an automated message from the Apache Git Serv
eerhardt commented on a change in pull request #7032:
URL: https://github.com/apache/arrow/pull/7032#discussion_r415072524
##
File path: csharp/src/Apache.Arrow/Apache.Arrow.csproj
##
@@ -4,7 +4,7 @@
netstandard1.3;netcoreapp2.1
true
$(DefineConstants);UNSAFE_BY
eerhardt commented on pull request #7032:
URL: https://github.com/apache/arrow/pull/7032#issuecomment-619396229
> ARROW-5634 by properly setting the readonly value for NullCount, which
previously was hardcoded to -1.
I don't believe this change addresses the issue correctly. Can we r
eerhardt commented on pull request #6121:
URL: https://github.com/apache/arrow/pull/6121#issuecomment-619396952
Thank you for this contribution, @abbotware.
However, my opinion is that #7032 is more inline with how null support
should be designed for the builder APIs. It also more cl
eerhardt opened a new pull request #7040:
URL: https://github.com/apache/arrow/pull/7040
Workaround https://github.com/dotnet/sourcelink/issues/572 by explicitly
embedding the AssemblyAttributes file into the pdb.
This is an
github-actions[bot] commented on pull request #7040:
URL: https://github.com/apache/arrow/pull/7040#issuecomment-619408251
https://issues.apache.org/jira/browse/ARROW-8505
This is an automated message from the Apache Git Serv
wjones1 commented on a change in pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#discussion_r415130068
##
File path: python/pyarrow/tests/test_parquet.py
##
@@ -179,6 +179,99 @@ def alltypes_sample(size=1, seed=0, categorical=False):
@pytest.mark.pan
wjones1 commented on pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#issuecomment-619437378
Two failing checks right now.
For the linting one, it seems to be alarmed by some Rust code that I didn't
touch. Am I missing something in that output?
For the Python
kou opened a new pull request #7041:
URL: https://github.com/apache/arrow/pull/7041
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kou commented on pull request #7041:
URL: https://github.com/apache/arrow/pull/7041#issuecomment-619456003
@github-actions crossbow submit -g linux
This is an automated message from the Apache Git Service.
To respond to the m
mayuropensource commented on pull request #7022:
URL: https://github.com/apache/arrow/pull/7022#issuecomment-619456016
A better calculation for bandwidth (by removing TTFB from total time) is
done using following script:
curl --negotiate -u: -o /dev/null -w "total_time_sec=%{time_tot
mayuropensource edited a comment on pull request #7022:
URL: https://github.com/apache/arrow/pull/7022#issuecomment-619456016
A better calculation for bandwidth (by removing TTFB from total time) is
done using following script:
`curl --negotiate -u: -o /dev/null -w "total_time_sec=%{
github-actions[bot] commented on pull request #7041:
URL: https://github.com/apache/arrow/pull/7041#issuecomment-619456125
Revision: 3e57660bbcb5002a8c53146754146fc7c92b1ead
Submitted crossbow builds: [ursa-labs/crossbow @
actions-166](https://github.com/ursa-labs/crossbow/branches/a
github-actions[bot] commented on pull request #7041:
URL: https://github.com/apache/arrow/pull/7041#issuecomment-619457325
https://issues.apache.org/jira/browse/ARROW-8584
This is an automated message from the Apache Git Serv
wjones1 commented on pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#issuecomment-619463693
I found the cause of the test failure: If the `batch_size` isn't aligned
with the `chunk_size`, categorical columns will fail with the error:
```
pyarrow.lib.ArrowNotImplemen
liyafan82 commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r415202903
##
File path:
java/memory/src/main/java/org/apache/arrow/memory/NettyAllocationManager.java
##
@@ -17,48 +17,97 @@
package org.apache.arrow.memory;
liyafan82 commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r415202953
##
File path:
java/memory/src/main/java/org/apache/arrow/memory/NettyAllocationManager.java
##
@@ -17,48 +17,97 @@
package org.apache.arrow.memory;
liyafan82 commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r415203349
##
File path:
java/memory/src/test/java/org/apache/arrow/memory/TestLargeArrowBuf.java
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Founda
liyafan82 commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r415203808
##
File path:
java/memory/src/main/java/org/apache/arrow/memory/NettyAllocationManager.java
##
@@ -17,48 +17,97 @@
package org.apache.arrow.memory;
liyafan82 commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r415203665
##
File path:
java/memory/src/main/java/org/apache/arrow/memory/NettyAllocationManager.java
##
@@ -17,48 +17,97 @@
package org.apache.arrow.memory;
liyafan82 commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r415203879
##
File path:
java/memory/src/test/java/org/apache/arrow/memory/TestNettyAllocationManager.java
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Softwa
liyafan82 commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r415203851
##
File path:
java/memory/src/test/java/org/apache/arrow/memory/TestNettyAllocationManager.java
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Softwa
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r414295562
##
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##
@@ -40,12 +40,13 @@ if(ARROW_CPU_FLAG STREQUAL "x86")
set(CXX_SUPPORTS_SSE4_2 TRUE)
else(
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r415221009
##
File path: cpp/src/parquet/level_conversion_test.cc
##
@@ -0,0 +1,162 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r415221052
##
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##
@@ -40,12 +40,13 @@ if(ARROW_CPU_FLAG STREQUAL "x86")
set(CXX_SUPPORTS_SSE4_2 TRUE)
else(
emkornfield commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-619488093
@pitrou I think I addressed your comments. One of them that went stale was
the complexity for "AppendWord", I tried to remove parts that did not seem to
affect performance on
emkornfield commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r415226340
##
File path: cpp/src/arrow/util/hash_util.h
##
@@ -27,39 +27,27 @@
#include "arrow/util/logging.h"
#include "arrow/util/macros.h"
-#include "arrow/
emkornfield commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r415226495
##
File path: cpp/src/arrow/util/hash_util.h
##
@@ -27,39 +27,27 @@
#include "arrow/util/logging.h"
#include "arrow/util/macros.h"
-#include "arrow/
emkornfield commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r415226495
##
File path: cpp/src/arrow/util/hash_util.h
##
@@ -27,39 +27,27 @@
#include "arrow/util/logging.h"
#include "arrow/util/macros.h"
-#include "arrow/
emkornfield commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r415228325
##
File path: cpp/src/arrow/util/simd.h
##
@@ -17,6 +17,24 @@
#pragma once
+#ifdef _MSC_VER
+// MSVC x86_64/arm64
+
+#if defined(_M_AMD64) || defin
emkornfield commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r415226340
##
File path: cpp/src/arrow/util/hash_util.h
##
@@ -27,39 +27,27 @@
#include "arrow/util/logging.h"
#include "arrow/util/macros.h"
-#include "arrow/
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415229227
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
tianchen92 commented on a change in pull request #6912:
URL: https://github.com/apache/arrow/pull/6912#discussion_r415229312
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/complex/NonNullableStructVector.java
##
@@ -320,6 +322,20 @@ public int hashCode(int ind
tianchen92 commented on a change in pull request #6912:
URL: https://github.com/apache/arrow/pull/6912#discussion_r415229163
##
File path: java/vector/src/main/java/org/apache/arrow/vector/ValueVector.java
##
@@ -283,4 +283,10 @@
* @return the name of the vector.
*/
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415229405
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415229405
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415230291
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415230291
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415230959
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415231200
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415231122
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415231929
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
emkornfield commented on pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#issuecomment-619493366
Just curious if you see and impact on parquet-arrow-reader-writer
benchmarks? That is the ultimate goal of the speedup.
-
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415233940
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
48 matches
Mail list logo