[GitHub] [arrow] github-actions[bot] commented on pull request #7091: ARROW-8680: [Rust] Fix ComplexObjectArray null value shifting

2020-05-03 Thread GitBox
github-actions[bot] commented on pull request #7091: URL: https://github.com/apache/arrow/pull/7091#issuecomment-623132413 https://issues.apache.org/jira/browse/ARROW-8680 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7092: ARROW-8682: [Ruby][Parquet] Add support for column level compression

2020-05-03 Thread GitBox
github-actions[bot] commented on pull request #7092: URL: https://github.com/apache/arrow/pull/7092#issuecomment-623183601 https://issues.apache.org/jira/browse/ARROW-8682 This is an automated message from the Apache Git

[GitHub] [arrow] mcassels commented on a change in pull request #6770: ARROW-7842: [Rust] [Parquet] implement array_reader for list type columns

2020-05-03 Thread GitBox
mcassels commented on a change in pull request #6770: URL: https://github.com/apache/arrow/pull/6770#discussion_r419189845 ## File path: rust/parquet/src/arrow/array_reader.rs ## @@ -468,6 +491,391 @@ where } } +/// Implementation of list array reader. +pub struct

[GitHub] [arrow] mcassels commented on a change in pull request #6770: ARROW-7842: [Rust] [Parquet] implement array_reader for list type columns

2020-05-03 Thread GitBox
mcassels commented on a change in pull request #6770: URL: https://github.com/apache/arrow/pull/6770#discussion_r419189845 ## File path: rust/parquet/src/arrow/array_reader.rs ## @@ -468,6 +491,391 @@ where } } +/// Implementation of list array reader. +pub struct

[GitHub] [arrow] emkornfield commented on a change in pull request #7012: ARROW-8555: [FlightRPC][Java] implement DoExchange

2020-05-03 Thread GitBox
emkornfield commented on a change in pull request #7012: URL: https://github.com/apache/arrow/pull/7012#discussion_r419200568 ## File path: java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java ## @@ -0,0 +1,395 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] emkornfield commented on pull request #7012: ARROW-8555: [FlightRPC][Java] implement DoExchange

2020-05-03 Thread GitBox
emkornfield commented on pull request #7012: URL: https://github.com/apache/arrow/pull/7012#issuecomment-623240480 Thanks, I think the tests are clearer now, left a few more comments. @jacques-n do you want to review? Otherwise, I'll take one more review pass later in the week (but I

[GitHub] [arrow] emkornfield commented on pull request #7029: ARROW-8579 [C++] Add AVX512 SIMD for spaced decoding and encoding.

2020-05-03 Thread GitBox
emkornfield commented on pull request #7029: URL: https://github.com/apache/arrow/pull/7029#issuecomment-623237943 Sorry for the late reply. Might as well append it to this PR. This is an automated message from the Apache

[GitHub] [arrow] emkornfield commented on a change in pull request #7012: ARROW-8555: [FlightRPC][Java] implement DoExchange

2020-05-03 Thread GitBox
emkornfield commented on a change in pull request #7012: URL: https://github.com/apache/arrow/pull/7012#discussion_r419200063 ## File path: java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightClient.java ## @@ -293,6 +292,76 @@ public void onCompleted() {

[GitHub] [arrow] emkornfield commented on pull request #6985: ARROW-8413: [C++][Parquet] Refactor Generating validity bitmap for values column

2020-05-03 Thread GitBox
emkornfield commented on pull request #6985: URL: https://github.com/apache/arrow/pull/6985#issuecomment-623249922 The separate .cc files might work as, we should probably cleanup macro naming so we can distinguish between min and max SSE instruction se to use (I imagine some people won't

[GitHub] [arrow] siddharthteotia commented on pull request #6729: ARROW-8229: [Java] Move ArrowBuf into the Arrow package

2020-05-03 Thread GitBox
siddharthteotia commented on pull request #6729: URL: https://github.com/apache/arrow/pull/6729#issuecomment-623251813 It will be good to link the related issues in the PR description. This is an automated message from the

[GitHub] [arrow] siddharthteotia commented on pull request #5930: ARROW-3495: [Java] Move validityBuffer to BaseValueVector, delete the optim…

2020-05-03 Thread GitBox
siddharthteotia commented on pull request #5930: URL: https://github.com/apache/arrow/pull/5930#issuecomment-623253871 Closing based on latest comments This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] wesm commented on issue #7082: pyarrow 0.17 atexit handler causes a segmentation fault

2020-05-03 Thread GitBox
wesm commented on issue #7082: URL: https://github.com/apache/arrow/issues/7082#issuecomment-623220977 I'm guessing you're using macOS and at least Python 3.7.5. I just opened https://issues.apache.org/jira/browse/ARROW-8684 If you could confirm your OS and Python version that

[GitHub] [arrow] siddharthteotia commented on pull request #6433: ARROW-7495: [Java] Remove "empty" concept from ArrowBuf, replace with custom referencemanager

2020-05-03 Thread GitBox
siddharthteotia commented on pull request #6433: URL: https://github.com/apache/arrow/pull/6433#issuecomment-623253149 @tianchen92 , can you please revise thia? Looks like the work is completed This is an automated message

[GitHub] [arrow] emkornfield commented on pull request #6985: ARROW-8413: [C++][Parquet] Refactor Generating validity bitmap for values column

2020-05-03 Thread GitBox
emkornfield commented on pull request #6985: URL: https://github.com/apache/arrow/pull/6985#issuecomment-623271321 @nealrichardson looks like a different error now? I think I probably want to use the scalar version for 32-bit builds. Is there an example in the code that provide the

[GitHub] [arrow] yordan-pavlov edited a comment on pull request #7037: ARROW-6718: [DRAFT] [Rust] Remove packed_simd

2020-05-03 Thread GitBox
yordan-pavlov edited a comment on pull request #7037: URL: https://github.com/apache/arrow/pull/7037#issuecomment-623106920 > @yordan-pavlov when you say SIMD you mean the "simd" feature (packed_simd), right? @paddyhoran yes that's what I meant, apologies if it was unclear

[GitHub] [arrow] yordan-pavlov commented on pull request #7037: ARROW-6718: [DRAFT] [Rust] Remove packed_simd

2020-05-03 Thread GitBox
yordan-pavlov commented on pull request #7037: URL: https://github.com/apache/arrow/pull/7037#issuecomment-623106920 > @yordan-pavlov when you say SIMD you mean the "simd" feature (packed_simd), right? @paddyhoran yes that's what I meant, apologies if it was unclear

[GitHub] [arrow] github-actions[bot] commented on pull request #7089: ARROW-8657: [C++][Python] Add separate configuration for data pages

2020-05-03 Thread GitBox
github-actions[bot] commented on pull request #7089: URL: https://github.com/apache/arrow/pull/7089#issuecomment-623073094 https://issues.apache.org/jira/browse/ARROW-8657 This is an automated message from the Apache Git

[GitHub] [arrow] emkornfield opened a new pull request #7089: ARROW-8657: [C++][Python] Add separate configuration for data pages

2020-05-03 Thread GitBox
emkornfield opened a new pull request #7089: URL: https://github.com/apache/arrow/pull/7089 - Adds a separate write config to determine which version of data page to use. - Plumb this throught to python. - At the moment version and data page version are completely

[GitHub] [arrow] nevi-me opened a new pull request #7090: ARROW-8422: [Rust] [Parquet] Arrow to Parquet schema conversion

2020-05-03 Thread GitBox
nevi-me opened a new pull request #7090: URL: https://github.com/apache/arrow/pull/7090 Converts an Arrow schema to Parquet schema This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] github-actions[bot] commented on pull request #7090: ARROW-8422: [Rust] [Parquet] Arrow to Parquet schema conversion

2020-05-03 Thread GitBox
github-actions[bot] commented on pull request #7090: URL: https://github.com/apache/arrow/pull/7090#issuecomment-623099297 https://issues.apache.org/jira/browse/ARROW-8422 This is an automated message from the Apache Git

[GitHub] [arrow] nevi-me commented on a change in pull request #6770: ARROW-7842: [Rust] [Parquet] implement array_reader for list type columns

2020-05-03 Thread GitBox
nevi-me commented on a change in pull request #6770: URL: https://github.com/apache/arrow/pull/6770#discussion_r419080375 ## File path: rust/parquet/src/arrow/array_reader.rs ## @@ -468,6 +491,391 @@ where } } +/// Implementation of list array reader. +pub struct