[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-06-30 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r447441667 ## File path: java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionUtility.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-06-30 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r447442441 ## File path: java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionCodec.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] nevi-me commented on pull request #7500: ARROW-9191: [Rust] Do not panic when milliseconds is less than zero as chrono can handle…

2020-06-30 Thread GitBox
nevi-me commented on pull request #7500: URL: https://github.com/apache/arrow/pull/7500#issuecomment-651650955 I've merged this, I've been having computer issues so haven't been able to do much work This is an automated

[GitHub] [arrow] nevi-me closed pull request #7554: ARROW-9236: [Rust] CSV WriterBuilder never writes header

2020-06-30 Thread GitBox
nevi-me closed pull request #7554: URL: https://github.com/apache/arrow/pull/7554 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] nevi-me closed pull request #7500: ARROW-9191: [Rust] Do not panic when milliseconds is less than zero as chrono can handle…

2020-06-30 Thread GitBox
nevi-me closed pull request #7500: URL: https://github.com/apache/arrow/pull/7500 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] pitrou commented on pull request #7580: ARROW-9261: [Python] Fix CA certificate lookup with S3 filesystem on manylinux

2020-06-30 Thread GitBox
pitrou commented on pull request #7580: URL: https://github.com/apache/arrow/pull/7580#issuecomment-651665973 I'm restarting that build just in case, seems it seems to fail contacting Github. But macOS wheel builds don't enable S3 anyway, so I doubt this has anything to do with this PR.

[GitHub] [arrow] pitrou commented on pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-30 Thread GitBox
pitrou commented on pull request #7449: URL: https://github.com/apache/arrow/pull/7449#issuecomment-651717472 Phew. It worked. RTools 4.0 is still broken, but there doesn't seem to be anything we can do, except perhaps disable that job. I'm gonna merge and leave the R cleanup to someone

[GitHub] [arrow] pitrou closed pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-30 Thread GitBox
pitrou closed pull request #7449: URL: https://github.com/apache/arrow/pull/7449 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] pitrou closed pull request #7580: ARROW-9261: [Python] Fix CA certificate lookup with S3 filesystem on manylinux

2020-06-30 Thread GitBox
pitrou closed pull request #7580: URL: https://github.com/apache/arrow/pull/7580 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] rymurr commented on pull request #7290: ARROW-1692: [Java] UnionArray round trip not working

2020-06-30 Thread GitBox
rymurr commented on pull request #7290: URL: https://github.com/apache/arrow/pull/7290#issuecomment-651630439 I _think_ this is now inline with the spec. The Union/DenseUnion types now uses logical type ids in Java. Which is the same as in c++. The difference in a java created Union is

[GitHub] [arrow] nevi-me commented on pull request #7588: ARROW-9274: [Rust] Parse 64bit numbers from integration files as strings

2020-06-30 Thread GitBox
nevi-me commented on pull request #7588: URL: https://github.com/apache/arrow/pull/7588#issuecomment-651720277 @wesm may I merge this? The Travis CI often takes long to start running This is an automated message from the

[GitHub] [arrow] nevi-me opened a new pull request #7588: ARROW-9274: [Rust] Parse 64bit numbers from integration files as strings

2020-06-30 Thread GitBox
nevi-me opened a new pull request #7588: URL: https://github.com/apache/arrow/pull/7588 This fixes Rust build failures This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] liyafan82 opened a new pull request #7587: ARROW-8973: [Java] Support batch value appending for large varchar/varbinary vectors

2020-06-30 Thread GitBox
liyafan82 opened a new pull request #7587: URL: https://github.com/apache/arrow/pull/7587 Please see https://issues.apache.org/jira/browse/ARROW-8973 This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] tianchen92 commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

2020-06-30 Thread GitBox
tianchen92 commented on pull request #6156: URL: https://github.com/apache/arrow/pull/6156#issuecomment-651706326 > Can we leave the old method in place and mark it as deprecated and remove in a later release? I am afraid it's not reasonable. since we need the right order in IPC and

[GitHub] [arrow] github-actions[bot] commented on pull request #7587: ARROW-8973: [Java] Support batch value appending for large varchar/varbinary vectors

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7587: URL: https://github.com/apache/arrow/pull/7587#issuecomment-651614454 https://issues.apache.org/jira/browse/ARROW-8973 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7588: ARROW-9274: [Rust] Parse 64bit numbers from integration files as strings

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7588: URL: https://github.com/apache/arrow/pull/7588#issuecomment-651709041 https://issues.apache.org/jira/browse/ARROW-9274 This is an automated message from the Apache Git

[GitHub] [arrow] nevi-me opened a new pull request #7591: ARROW-8535: [Rust] Specify arrow-flight version

2020-06-30 Thread GitBox
nevi-me opened a new pull request #7591: URL: https://github.com/apache/arrow/pull/7591 This is to ensure that Rust users who include the arrow crate from crates.io do not get errors as they would not have the arrow-flight directory

[GitHub] [arrow] pitrou commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

2020-06-30 Thread GitBox
pitrou commented on pull request #7590: URL: https://github.com/apache/arrow/pull/7590#issuecomment-651773473 @crcrpar Do you think the version I pushed is ok and clear enough? This is an automated message from the Apache

[GitHub] [arrow] wesm commented on a change in pull request #7535: ARROW-9222: [Format][DONOTMERGE] Columnar.rst changes for removing validity bitmap from union types

2020-06-30 Thread GitBox
wesm commented on a change in pull request #7535: URL: https://github.com/apache/arrow/pull/7535#discussion_r447691975 ## File path: docs/source/format/Columnar.rst ## @@ -566,33 +572,28 @@ having the values: ``[{f=1.2}, null, {f=3.4}, {i=5}]`` :: * Length: 4, Null

[GitHub] [arrow] wesm commented on a change in pull request #7535: ARROW-9222: [Format][DONOTMERGE] Columnar.rst changes for removing validity bitmap from union types

2020-06-30 Thread GitBox
wesm commented on a change in pull request #7535: URL: https://github.com/apache/arrow/pull/7535#discussion_r447692444 ## File path: docs/source/format/Columnar.rst ## @@ -688,11 +687,10 @@ will have the following layout: :: ||---|

[GitHub] [arrow] pitrou commented on a change in pull request #7594: ARROW-7654: [Python] Ability to set column_types to a Schema in csv.ConvertOptions is undocumented

2020-06-30 Thread GitBox
pitrou commented on a change in pull request #7594: URL: https://github.com/apache/arrow/pull/7594#discussion_r447724372 ## File path: python/pyarrow/_csv.pyx ## @@ -342,9 +342,9 @@ cdef class ConvertOptions: -- check_utf8 : bool, optional (default True)

[GitHub] [arrow] kszucs opened a new pull request #7594: ARROW-7654: [Python] Ability to set column_types to a Schema in csv.ConvertOptions is undocumented

2020-06-30 Thread GitBox
kszucs opened a new pull request #7594: URL: https://github.com/apache/arrow/pull/7594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] kszucs commented on a change in pull request #7594: ARROW-7654: [Python] Ability to set column_types to a Schema in csv.ConvertOptions is undocumented

2020-06-30 Thread GitBox
kszucs commented on a change in pull request #7594: URL: https://github.com/apache/arrow/pull/7594#discussion_r447723473 ## File path: python/pyarrow/_csv.pyx ## @@ -342,9 +342,9 @@ cdef class ConvertOptions: -- check_utf8 : bool, optional (default True)

[GitHub] [arrow] wesm commented on pull request #7556: ARROW-9188: [C++] Use Brotli shared libraries if they are available

2020-06-30 Thread GitBox
wesm commented on pull request #7556: URL: https://github.com/apache/arrow/pull/7556#issuecomment-651847404 This looks good to me, @kszucs @kou @nealrichardson anything else you would want to check? This is an automated

[GitHub] [arrow] kszucs commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
kszucs commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r447758318 ## File path: python/pyarrow/tests/test_scalars.py ## @@ -16,427 +16,443 @@ # under the License. import datetime +import decimal import pytest -import

[GitHub] [arrow] xhochy opened a new pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
xhochy opened a new pull request #7593: URL: https://github.com/apache/arrow/pull/7593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] lidavidm commented on pull request #7543: ARROW-9221: [Java] account for big-endian buffers in ArrowBuf.setBytes

2020-06-30 Thread GitBox
lidavidm commented on pull request #7543: URL: https://github.com/apache/arrow/pull/7543#issuecomment-651777225 Would a Java maintainer be able to look at this? This is an automated message from the Apache Git Service. To

[GitHub] [arrow] kszucs commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
kszucs commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r447725569 ## File path: python/pyarrow/lib.pxd ## @@ -179,101 +179,18 @@ cdef class Schema: cdef class Scalar: -cdef readonly: -DataType type - -

[GitHub] [arrow] crcrpar commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

2020-06-30 Thread GitBox
crcrpar commented on pull request #7590: URL: https://github.com/apache/arrow/pull/7590#issuecomment-651835046 @pitrou My pleasure :smiley: Yes, I think so as the use of `arrow::Result` in my commits might be confusing.

[GitHub] [arrow] pitrou closed pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

2020-06-30 Thread GitBox
pitrou closed pull request #7590: URL: https://github.com/apache/arrow/pull/7590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] kszucs commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
kszucs commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r447734944 ## File path: python/pyarrow/scalar.pxi ## @@ -16,1198 +16,745 @@ # under the License. -_NULL = NA = None +import collections cdef class Scalar:

[GitHub] [arrow] crcrpar commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

2020-06-30 Thread GitBox
crcrpar commented on pull request #7590: URL: https://github.com/apache/arrow/pull/7590#issuecomment-651844844 I'm so impressed by your quick response! Thanks! This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #7586: ARROW-9280: [Rust] [Parquet] Calculate page and column statistics

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7586: URL: https://github.com/apache/arrow/pull/7586#issuecomment-651852823 https://issues.apache.org/jira/browse/ARROW-9280 This is an automated message from the Apache Git

[GitHub] [arrow] kszucs commented on a change in pull request #7589: ARROW-9276: [Release] Enforce CUDA device for updating the api documentations

2020-06-30 Thread GitBox
kszucs commented on a change in pull request #7589: URL: https://github.com/apache/arrow/pull/7589#discussion_r447643080 ## File path: dev/release/post-09-docs.sh ## @@ -42,20 +47,20 @@ popd pushd "${ARROW_DIR}" git checkout "${release_tag}" Review comment: @wesm

[GitHub] [arrow] github-actions[bot] commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7590: URL: https://github.com/apache/arrow/pull/7590#issuecomment-651768214 https://issues.apache.org/jira/browse/ARROW-9277 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7591: ARROW-8535: [Rust] Specify arrow-flight version

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7591: URL: https://github.com/apache/arrow/pull/7591#issuecomment-651768213 https://issues.apache.org/jira/browse/ARROW-8535 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou opened a new pull request #7592: ARROW-9220: [C++] Make utf8proc optional even with ARROW_COMPUTE=ON

2020-06-30 Thread GitBox
pitrou opened a new pull request #7592: URL: https://github.com/apache/arrow/pull/7592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] pitrou commented on a change in pull request #7582: ARROW-8190: [FlightRPC][C++] Expose IPC options

2020-06-30 Thread GitBox
pitrou commented on a change in pull request #7582: URL: https://github.com/apache/arrow/pull/7582#discussion_r447665599 ## File path: cpp/src/arrow/flight/flight_test.cc ## @@ -1808,6 +1880,90 @@ TEST_F(TestMetadata, DoPutReadMetadata) { ASSERT_OK(writer->Close()); }

[GitHub] [arrow] xhochy commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
xhochy commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-651779867 This currently fails for chunked arrays. I though that they should be handled by the kernel framework automatically but it seems, they aren't. ``` [--] 1 test

[GitHub] [arrow] github-actions[bot] commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-651787097 https://issues.apache.org/jira/browse/ARROW-9160 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7592: ARROW-9220: [C++] Make utf8proc optional even with ARROW_COMPUTE=ON

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7592: URL: https://github.com/apache/arrow/pull/7592#issuecomment-651787096 https://issues.apache.org/jira/browse/ARROW-9220 This is an automated message from the Apache Git

[GitHub] [arrow] wesm commented on pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-30 Thread GitBox
wesm commented on pull request #7449: URL: https://github.com/apache/arrow/pull/7449#issuecomment-651793397 thanks @maartenbreddels! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] github-actions[bot] commented on pull request #7594: ARROW-7654: [Python] Ability to set column_types to a Schema in csv.ConvertOptions is undocumented

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7594: URL: https://github.com/apache/arrow/pull/7594#issuecomment-651831683 https://issues.apache.org/jira/browse/ARROW-7654 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on a change in pull request #7544: ARROW-7285: [C++] ensure C++ implementation meets clarified dictionary spec

2020-06-30 Thread GitBox
pitrou commented on a change in pull request #7544: URL: https://github.com/apache/arrow/pull/7544#discussion_r447729043 ## File path: cpp/src/arrow/ipc/read_write_test.cc ## @@ -1228,6 +1228,152 @@ TEST_P(TestFileFormat, RoundTrip) { TestZeroLengthRoundTrip(*GetParam(),

[GitHub] [arrow] pitrou closed pull request #7592: ARROW-9220: [C++] Make utf8proc optional even with ARROW_COMPUTE=ON

2020-06-30 Thread GitBox
pitrou closed pull request #7592: URL: https://github.com/apache/arrow/pull/7592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] kszucs commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
kszucs commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r447731034 ## File path: python/pyarrow/scalar.pxi ## @@ -16,1198 +16,745 @@ # under the License. -_NULL = NA = None +import collections cdef class Scalar:

[GitHub] [arrow] kszucs commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
kszucs commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r447738979 ## File path: python/pyarrow/scalar.pxi ## @@ -16,1198 +16,745 @@ # under the License. -_NULL = NA = None +import collections cdef class Scalar:

[GitHub] [arrow] maartenbreddels commented on pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-30 Thread GitBox
maartenbreddels commented on pull request #7449: URL: https://github.com/apache/arrow/pull/7449#issuecomment-651796902 You're welcome. Thanks all for your help. Impressed by the project, setup (CI/CMake), and people, and happy with the results:

[GitHub] [arrow] pitrou commented on pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
pitrou commented on pull request #7519: URL: https://github.com/apache/arrow/pull/7519#issuecomment-651806049 Ok, at a quick glance, it seems that null container tests work properly regardless: ```python >>> s = set()

[GitHub] [arrow] fsaintjacques closed pull request #7536: ARROW-8647: [C++][Python][Dataset] Allow partitioning fields to be inferred with dictionary type

2020-06-30 Thread GitBox
fsaintjacques closed pull request #7536: URL: https://github.com/apache/arrow/pull/7536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] lidavidm commented on pull request #7582: ARROW-8190: [FlightRPC][C++] Expose IPC options

2020-06-30 Thread GitBox
lidavidm commented on pull request #7582: URL: https://github.com/apache/arrow/pull/7582#issuecomment-651813343 Thanks for the review! I've fixed the comment/test names. This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
pitrou commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r447732301 ## File path: python/pyarrow/scalar.pxi ## @@ -16,1198 +16,745 @@ # under the License. -_NULL = NA = None +import collections cdef class Scalar:

[GitHub] [arrow] wesm commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-651849432 @xhochy chunked array should be handled automatically by the function executors. I will take a look. This is an

[GitHub] [arrow] pitrou commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
pitrou commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r447751371 ## File path: python/pyarrow/scalar.pxi ## @@ -16,1198 +16,745 @@ # under the License. -_NULL = NA = None +import collections cdef class Scalar:

[GitHub] [arrow] pitrou commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

2020-06-30 Thread GitBox
pitrou commented on pull request #7590: URL: https://github.com/apache/arrow/pull/7590#issuecomment-651836379 Thank you for your contribution. Please don't hesitate to report other doc problems. This is an automated message

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-651849432 @xhochy chunked arrays should be handled automatically by the function executors. I will take a look. This

[GitHub] [arrow] pitrou commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

2020-06-30 Thread GitBox
pitrou commented on pull request #7590: URL: https://github.com/apache/arrow/pull/7590#issuecomment-651769268 Thank you for spotting this and suggesting a fix! I will make a couple changes to your suggestion. This is an

[GitHub] [arrow] nevi-me commented on pull request #7591: ARROW-8535: [Rust] Specify arrow-flight version

2020-06-30 Thread GitBox
nevi-me commented on pull request #7591: URL: https://github.com/apache/arrow/pull/7591#issuecomment-651837534 @kszucs may you please have a look at this when you get a chance. There's a change to the prepare-test Ruby script

[GitHub] [arrow] pitrou commented on a change in pull request #7589: ARROW-9276: [Release] Enforce CUDA device for updating the api documentations

2020-06-30 Thread GitBox
pitrou commented on a change in pull request #7589: URL: https://github.com/apache/arrow/pull/7589#discussion_r447741353 ## File path: dev/release/post-09-docs.sh ## @@ -42,20 +47,20 @@ popd pushd "${ARROW_DIR}" git checkout "${release_tag}" Review comment: @kszucs

[GitHub] [arrow] kszucs opened a new pull request #7589: ARROW-9276: [Release] Enforce CUDA device for updating the api documentations

2020-06-30 Thread GitBox
kszucs opened a new pull request #7589: URL: https://github.com/apache/arrow/pull/7589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #7590: [C++] Fix docs of reading CSV files

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7590: URL: https://github.com/apache/arrow/pull/7590#issuecomment-651761199 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] github-actions[bot] commented on pull request #7589: ARROW-9276: [Release] Enforce CUDA device for updating the api documentations

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7589: URL: https://github.com/apache/arrow/pull/7589#issuecomment-651761179 https://issues.apache.org/jira/browse/ARROW-9276 This is an automated message from the Apache Git

[GitHub] [arrow] crcrpar opened a new pull request #7590: [C++] Fix docs of reading CSV files

2020-06-30 Thread GitBox
crcrpar opened a new pull request #7590: URL: https://github.com/apache/arrow/pull/7590 Hi, This is my first PR for this awesome project. So if I do not follow the workflow, could you tell me, please? In this PR, I aim at fixing

[GitHub] [arrow] nevi-me closed pull request #7588: ARROW-9274: [Rust] Parse 64bit numbers from integration files as strings

2020-06-30 Thread GitBox
nevi-me closed pull request #7588: URL: https://github.com/apache/arrow/pull/7588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] xhochy edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
xhochy edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-651779867 This currently fails for chunked arrays. I thought that they should be handled by the kernel framework automatically but it seems, they aren't. ``` [--] 1

[GitHub] [arrow] nevi-me commented on pull request #7586: Calculate page and column statistics

2020-06-30 Thread GitBox
nevi-me commented on pull request #7586: URL: https://github.com/apache/arrow/pull/7586#issuecomment-651810251 Hi @zeevm, may you please kindly rebase (to fix the Rust failures) and open a JIRA for this PR This is an

[GitHub] [arrow] kszucs commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
kszucs commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r447725217 ## File path: python/pyarrow/includes/libarrow.pxd ## @@ -44,6 +44,11 @@ cdef extern from "arrow/util/key_value_metadata.h" namespace "arrow" nogil:

[GitHub] [arrow] kszucs commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
kszucs commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r447733611 ## File path: python/pyarrow/scalar.pxi ## @@ -16,1198 +16,745 @@ # under the License. -_NULL = NA = None +import collections cdef class Scalar:

[GitHub] [arrow] pitrou closed pull request #7549: ARROW-9230: [FlightRPC][Python] pass through all options in flight.connect

2020-06-30 Thread GitBox
pitrou closed pull request #7549: URL: https://github.com/apache/arrow/pull/7549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] sunchao commented on a change in pull request #7319: ARROW-8289: [Rust] Parquet Arrow writer with nested support

2020-06-30 Thread GitBox
sunchao commented on a change in pull request #7319: URL: https://github.com/apache/arrow/pull/7319#discussion_r447898772 ## File path: rust/parquet/src/arrow/arrow_writer.rs ## @@ -0,0 +1,348 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] BryanCutler commented on pull request #7275: ARROW-6110: [Java][Integration] Support LargeList Type and add integration test with C++

2020-06-30 Thread GitBox
BryanCutler commented on pull request #7275: URL: https://github.com/apache/arrow/pull/7275#issuecomment-651984931 > Is this good to merge now? @BryanCutler are you still planning to review this? Would like to get this in 1.0. I'm taking a look now, I'd like to get it in for 1.0

[GitHub] [arrow] nealrichardson closed pull request #7595: ARROW-9281: [R] Turn off utf8proc in R builds

2020-06-30 Thread GitBox
nealrichardson closed pull request #7595: URL: https://github.com/apache/arrow/pull/7595 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] tobim commented on pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow

2020-06-30 Thread GitBox
tobim commented on pull request #7315: URL: https://github.com/apache/arrow/pull/7315#issuecomment-652001357 @wesm I still believe this approach is the sanest, but seeing that it requires CMake 3.9 I guess that makes it a non-starter? I would not expect problems with this on windows,

[GitHub] [arrow] nealrichardson closed pull request #7600: ARROW-4390: [R] Serialize "labeled" metadata in Feather files, IPC messages

2020-06-30 Thread GitBox
nealrichardson closed pull request #7600: URL: https://github.com/apache/arrow/pull/7600 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] lmsanch commented on issue #6841: AttributeError: module 'pyarrow' has no attribute 'filesystem'

2020-06-30 Thread GitBox
lmsanch commented on issue #6841: URL: https://github.com/apache/arrow/issues/6841#issuecomment-651976303 I am experiencing the same problem. I don't know what the solution is This is an automated message from the Apache Git

[GitHub] [arrow] wesm commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652048000 I just opened https://issues.apache.org/jira/browse/ARROW-9285 -- it should be easy to check if a kernel has mistakenly replaced a preallocated data buffer (which may be a slice of

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744 I also propose to rename the function from "contains_exact" to "utf8_contains". ~~I'm pushing that change here shortly~~. Or should we call it "binary_contains" /

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744 I also propose to rename the function from "contains_exact" to "utf8_contains". ~~I'm pushing that change here shortly~~. Or should we call it "binary_contains" /

[GitHub] [arrow] nealrichardson closed pull request #7597: ARROW-9282: [R] Remove usage of _EXTPTR_PTR

2020-06-30 Thread GitBox
nealrichardson closed pull request #7597: URL: https://github.com/apache/arrow/pull/7597 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] nealrichardson opened a new pull request #7601: ARROW-8867: [R] Support converting POSIXlt type

2020-06-30 Thread GitBox
nealrichardson opened a new pull request #7601: URL: https://github.com/apache/arrow/pull/7601 Also contains some test refactor, documentation, and slight tweaks as followup to ARROW-8899. This is an automated message from

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744 I also propose to rename the function from "contains_exact" to "utf8_contains". ~~I'm pushing that change here shortly~~. Or should we call it "binary_contains" /

[GitHub] [arrow] wesm commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652045953 @xhochy I'm fixing a couple issues with the implementation: * The function executor allocates memory for you unless you explicitly disable it. The idea is that you don't want

[GitHub] [arrow] wesm commented on a change in pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm commented on a change in pull request #7593: URL: https://github.com/apache/arrow/pull/7593#discussion_r447982219 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -387,16 +380,20 @@ using ContainsExactState = OptionsWrapper; template struct

[GitHub] [arrow] github-actions[bot] commented on pull request #7601: ARROW-8867: [R] Support converting POSIXlt type

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7601: URL: https://github.com/apache/arrow/pull/7601#issuecomment-652056875 https://issues.apache.org/jira/browse/ARROW-8867 This is an automated message from the Apache Git

[GitHub] [arrow] kou commented on a change in pull request #7556: ARROW-9188: [C++] Use Brotli shared libraries if they are available

2020-06-30 Thread GitBox
kou commented on a change in pull request #7556: URL: https://github.com/apache/arrow/pull/7556#discussion_r448003034 ## File path: python/manylinux201x/build_arrow.sh ## @@ -120,6 +120,7 @@ PATH="${CPYTHON_PATH}/bin:${PATH}" cmake \ -DARROW_WITH_SNAPPY=ON \

[GitHub] [arrow] wesm commented on pull request #7556: ARROW-9188: [C++] Use Brotli shared libraries if they are available

2020-06-30 Thread GitBox
wesm commented on pull request #7556: URL: https://github.com/apache/arrow/pull/7556#issuecomment-652058759 If there's no further feedback I will merge this in the next 24h and I assume that any packaging issues will come up in nightlies as we push toward the next release.

[GitHub] [arrow] wesm edited a comment on pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7315: URL: https://github.com/apache/arrow/pull/7315#issuecomment-652020060 We're running out of time to get this completed for the release, so if a working solution can be demonstrated to have been reached on all 3 platforms that works for both

[GitHub] [arrow] wesm commented on pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow

2020-06-30 Thread GitBox
wesm commented on pull request #7315: URL: https://github.com/apache/arrow/pull/7315#issuecomment-652020060 We're running out of time to get this completed for the release, so if a working solution can be demonstrated to have been reached on all 3 platforms that works for both jemalloc

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744 I also propose to rename the function from "contains_exact" to "utf8_contains". I'm pushing that change here shortly. Or should we call it "BinaryContains" since it will work

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744 I also propose to rename the function from "contains_exact" to "utf8_contains". I'm pushing that change here shortly. Or should we call it "binary_contains" /

[GitHub] [arrow] wesm commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744 I also propose to rename the function from "contains_exact" to "utf8_contains". I'm pushing that change here shortly

[GitHub] [arrow] BryanCutler commented on a change in pull request #7275: ARROW-6110: [Java][Integration] Support LargeList Type and add integration test with C++

2020-06-30 Thread GitBox
BryanCutler commented on a change in pull request #7275: URL: https://github.com/apache/arrow/pull/7275#discussion_r448032771 ## File path: java/vector/src/main/java/org/apache/arrow/vector/complex/LargeListVector.java ## @@ -0,0 +1,991 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] mrkn commented on pull request #7477: ARROW-4221: [C++][Python] Add canonical flag in COO sparse index

2020-06-30 Thread GitBox
mrkn commented on pull request #7477: URL: https://github.com/apache/arrow/pull/7477#issuecomment-652124757 @pitrou In summary, the constraint of the indices order of SparseCOOIndex was removed, but the new flag field is introduced to state whether or not the indices tensor is ordered in

[GitHub] [arrow] wesm closed pull request #7478: ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type

2020-06-30 Thread GitBox
wesm closed pull request #7478: URL: https://github.com/apache/arrow/pull/7478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7287: ARROW-8771: [C++] Add boost/process library to build support

2020-06-30 Thread GitBox
wesm commented on pull request #7287: URL: https://github.com/apache/arrow/pull/7287#issuecomment-652142725 Could this be picked up again? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] wesm commented on pull request #7507: ARROW-8797: [C++] Create test to receive RecordBatch for different endian

2020-06-30 Thread GitBox
wesm commented on pull request #7507: URL: https://github.com/apache/arrow/pull/7507#issuecomment-652142541 @kiszk I would suggest creating a LE and BE example corpus in apache/arrow-testing. You can use the integration test command line tools to create point-of-truth JSON files and then

[GitHub] [arrow] nealrichardson opened a new pull request #7602: ARROW-9083: [R] collect int64, uint32, uint64 as R integer type if not out of bounds

2020-06-30 Thread GitBox
nealrichardson opened a new pull request #7602: URL: https://github.com/apache/arrow/pull/7602 Still to do: - [ ] Update test expectations since the output types have changed - [ ] Add tests that exercise the case where the data doesn't fit into int32

[GitHub] [arrow] github-actions[bot] commented on pull request #7602: ARROW-9083: [R] collect int64, uint32, uint64 as R integer type if not out of bounds

2020-06-30 Thread GitBox
github-actions[bot] commented on pull request #7602: URL: https://github.com/apache/arrow/pull/7602#issuecomment-652080559 https://issues.apache.org/jira/browse/ARROW-9083 This is an automated message from the Apache Git

[GitHub] [arrow] wesm commented on a change in pull request #7602: ARROW-9083: [R] collect int64, uint32, uint64 as R integer type if not out of bounds

2020-06-30 Thread GitBox
wesm commented on a change in pull request #7602: URL: https://github.com/apache/arrow/pull/7602#discussion_r448028250 ## File path: r/src/array_to_vector.cpp ## @@ -673,6 +676,17 @@ class Converter_Null : public Converter { } }; +bool arrays_can_fit_integer(ArrayVector

[GitHub] [arrow] wesm commented on a change in pull request #7584: ARROW-9272: [C++][Python] Reduce complexity in python to arrow conversion

2020-06-30 Thread GitBox
wesm commented on a change in pull request #7584: URL: https://github.com/apache/arrow/pull/7584#discussion_r448064117 ## File path: cpp/src/arrow/python/python_to_arrow.cc ## @@ -53,6 +53,335 @@ using internal::checked_pointer_cast; namespace py { +//

  1   2   >