xhochy commented on a change in pull request #7808:
URL: https://github.com/apache/arrow/pull/7808#discussion_r457615350
##
File path: dev/tasks/conda-recipes/azure.win.yml
##
@@ -34,11 +34,10 @@ jobs:
- task: CondaEnvironment@1
inputs:
-packageSpecs:
andygrove commented on pull request #7809:
URL: https://github.com/apache/arrow/pull/7809#issuecomment-661264618
@jorgecarleitao fyi
This is an automated message from the Apache Git Service.
To respond to the message, please
jorgecarleitao opened a new pull request #7811:
URL: https://github.com/apache/arrow/pull/7811
@andygrove fyi
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
andygrove commented on a change in pull request #7812:
URL: https://github.com/apache/arrow/pull/7812#discussion_r457676182
##
File path: rust/datafusion/src/execution/physical_plan/udf.rs
##
@@ -84,6 +86,19 @@ impl ScalarFunctionExpr {
}
}
+impl fmt::Display for
kou commented on pull request #7791:
URL: https://github.com/apache/arrow/pull/7791#issuecomment-661347208
@kszucs Can I merge this to master? Or should I wait for releasing 1.0.0?
This is an automated message from the
patrickpai commented on pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#issuecomment-661292801
Does anyone know if I'm supposed to be able to see logs for failing checks?
When I view the details for a failing check, I can't see any error messages to
help figure out what
andygrove closed pull request #7809:
URL: https://github.com/apache/arrow/pull/7809
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
BryanCutler commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661296416
great, thanks @kszucs !
This is an automated message from the Apache Git Service.
To respond to the message,
kszucs opened a new pull request #7814:
URL: https://github.com/apache/arrow/pull/7814
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on pull request #7814:
URL: https://github.com/apache/arrow/pull/7814#issuecomment-661344375
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
xhochy commented on pull request #7810:
URL: https://github.com/apache/arrow/pull/7810#issuecomment-661270079
@github-actions crossbow submit conda-win-vs2017-py36
This is an automated message from the Apache Git Service.
To
xhochy opened a new pull request #7810:
URL: https://github.com/apache/arrow/pull/7810
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661269532
@BryanCutler seems like the spark tests are passing with the current master.
This is an automated message from the
kszucs commented on pull request #7782:
URL: https://github.com/apache/arrow/pull/7782#issuecomment-661305131
@praveenbingo please don't forget to add the relevant components
`[C++][Gandiva]` to the pull request's title.
github-actions[bot] commented on pull request #7812:
URL: https://github.com/apache/arrow/pull/7812#issuecomment-661311089
https://issues.apache.org/jira/browse/ARROW-9507
This is an automated message from the Apache Git
kszucs commented on pull request #7791:
URL: https://github.com/apache/arrow/pull/7791#issuecomment-661349863
@kou you can go ahead. I wanted to merge it, just forgot it.
This is an automated message from the Apache Git
andygrove closed pull request #7806:
URL: https://github.com/apache/arrow/pull/7806
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kszucs commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661257796
@BryanCutler I already submitted them, the spark tests are still running
https://github.com/ursa-labs/crossbow/branches/all?query=build-871
github-actions[bot] commented on pull request #7810:
URL: https://github.com/apache/arrow/pull/7810#issuecomment-661271016
Revision: 621022a99122277494b14693dd085b61ee02d1cb
Submitted crossbow builds: [ursa-labs/crossbow @
jorgecarleitao commented on pull request #7809:
URL: https://github.com/apache/arrow/pull/7809#issuecomment-661276604
Nice! I just needed this in my ballista's PR!
following [this SO answer](https://stackoverflow.com/a/40776087/931303),
what do you think of
```
trait
jorgecarleitao commented on pull request #7796:
URL: https://github.com/apache/arrow/pull/7796#issuecomment-661314335
@andygrove fyi
This is an automated message from the Apache Git Service.
To respond to the message, please
kszucs closed pull request #7808:
URL: https://github.com/apache/arrow/pull/7808
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kszucs edited a comment on pull request #7808:
URL: https://github.com/apache/arrow/pull/7808#issuecomment-661255732
The windows failures must be caused by the recent CF dependency updates (at
least setuptools has a different build hash). cc @xhochy
They are not mandatory for the
andygrove commented on pull request #7809:
URL: https://github.com/apache/arrow/pull/7809#issuecomment-661283955
@jorgecarleitao Oh, that is much nicer. Do you want to PR that and I'll
close this one?
This is an automated
jorgecarleitao commented on pull request #7809:
URL: https://github.com/apache/arrow/pull/7809#issuecomment-661286169
I can take it.
This is an automated message from the Apache Git Service.
To respond to the message, please
andygrove opened a new pull request #7812:
URL: https://github.com/apache/arrow/pull/7812
This allows physical expressions to be printed in a human-readable form and
is a step towards a printable physical plan.
This is an
andygrove commented on pull request #7812:
URL: https://github.com/apache/arrow/pull/7812#issuecomment-661308588
fyi @jorgecarleitao
This is an automated message from the Apache Git Service.
To respond to the message,
jorgecarleitao commented on pull request #7812:
URL: https://github.com/apache/arrow/pull/7812#issuecomment-661318331
Left a minor comment, other than that, LGTM.
I am uncertain whether this should be Debug or Display, but since we haven't
formulated a concrete spec on this,
nealrichardson commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-661323133
Correct me if I'm wrong, but IIUC there are doubts about a few things:
1) the correctness of the behavior on master (prior to reverting the initial
change)
2) the
eerhardt commented on pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#issuecomment-661363849
> I think that a member of the "arrow-committers" team can use "Re-run
jobs". (I re-ran jobs.)
Ah, I didn't know committers were special that way. Thanks for re-running,
BryanCutler commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-661238238
Just to clarify things, is the main concern with this patch over keeping the
previous buggy behavior? Besides that are these changes producing correct
results and passing
andygrove closed pull request #7795:
URL: https://github.com/apache/arrow/pull/7795
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #7811:
URL: https://github.com/apache/arrow/pull/7811#issuecomment-661311087
https://issues.apache.org/jira/browse/ARROW-9534
This is an automated message from the Apache Git
emkornfield commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-661328369
too many communication channels.
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] removed a comment on pull request #7814:
URL: https://github.com/apache/arrow/pull/7814#issuecomment-661344375
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
kszucs commented on pull request #7814:
URL: https://github.com/apache/arrow/pull/7814#issuecomment-661344718
@github-actions crossbow submit verify-rc-source-*
This is an automated message from the Apache Git Service.
To
kszucs commented on pull request #7787:
URL: https://github.com/apache/arrow/pull/7787#issuecomment-661344502
Closing in favor of https://github.com/apache/arrow/pull/7814
This is an automated message from the Apache Git
kszucs closed pull request #7787:
URL: https://github.com/apache/arrow/pull/7787
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kou commented on pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#issuecomment-661361050
I think that a member of the "arrow-committers" team can use "Re-run jobs".
(I re-ran jobs.)
Others can use `git commit --amend && git push --force ...` or ask a
committer to
andygrove opened a new pull request #7809:
URL: https://github.com/apache/arrow/pull/7809
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #7809:
URL: https://github.com/apache/arrow/pull/7809#issuecomment-661260249
https://issues.apache.org/jira/browse/ARROW-9534
This is an automated message from the Apache Git
jorgecarleitao commented on a change in pull request #7811:
URL: https://github.com/apache/arrow/pull/7811#discussion_r457663076
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -378,9 +378,44 @@ pub fn col(name: ) -> Expr {
Expr::UnresolvedColumn(name.to_owned())
jorgecarleitao commented on a change in pull request #7812:
URL: https://github.com/apache/arrow/pull/7812#discussion_r457673965
##
File path: rust/datafusion/src/execution/physical_plan/udf.rs
##
@@ -84,6 +86,19 @@ impl ScalarFunctionExpr {
}
}
+impl fmt::Display for
kou commented on a change in pull request #7813:
URL: https://github.com/apache/arrow/pull/7813#discussion_r457765369
##
File path: cpp/examples/minimal_build/Dockerfile_static_system_libs
##
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
mr-smidge commented on a change in pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#discussion_r457739938
##
File path: csharp/src/Apache.Arrow/Arrays/Date64Array.cs
##
@@ -15,56 +15,94 @@
using Apache.Arrow.Types;
using System;
-using
mr-smidge commented on a change in pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#discussion_r457739938
##
File path: csharp/src/Apache.Arrow/Arrays/Date64Array.cs
##
@@ -15,56 +15,94 @@
using Apache.Arrow.Types;
using System;
-using
kszucs commented on pull request #7814:
URL: https://github.com/apache/arrow/pull/7814#issuecomment-661556160
@github-actions crossbow submit verify-rc-binaries-* verify-rc-wheels-*
This is an automated message from the
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457173202
##
File path: cpp/src/arrow/python/inference.cc
##
@@ -332,6 +329,13 @@ class TypeInferrer {
++int_count_;
} else if (PyDateTime_Check(obj)) {
jorgecarleitao edited a comment on pull request #7799:
URL: https://github.com/apache/arrow/pull/7799#issuecomment-660824105
Some benchmarks:
* Current: 19m with image caching; 21m without image caching
* This PR: ~8m with image caching; 13m without image caching
(~8
github-actions[bot] commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660856056
Revision: a5b2a51665ab1383fb371ecd76bb3c20c4bf8726
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660856402
We can use task listed only in
https://github.com/apache/arrow/blob/master/dev/tasks/tasks.yml#L1930 for
`crossbow submit`.
We don't have `...-3.7-...` task. We only have
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-660877250
@sunchao , I moved the coverage to run on the docker image and added
reporting to codecov to github's workflow.
Since coverage reporting requires a different
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457177694
##
File path: cpp/src/arrow/python/inference.cc
##
@@ -332,6 +329,13 @@ class TypeInferrer {
++int_count_;
} else if (PyDateTime_Check(obj)) {
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457178228
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3325,6 +3325,21 @@ def test_cast_timestamp_unit():
assert result.equals(expected)
+def
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457178426
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3325,6 +3325,21 @@ def test_cast_timestamp_unit():
assert result.equals(expected)
+def
zhztheplayer commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-660927861
Sorry I am reconsidering whether to use JVM direct memory as a limit of
native buffer allocation. By Oracle's explanation[1] about direct memory,
direct memory seems only to
zhztheplayer edited a comment on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-660927861
Sorry I am reconsidering whether to use JVM direct memory as a limit of
native buffer allocation. Technically by Oracle's explanation[1] about direct
memory, direct
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457176423
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3325,6 +3325,21 @@ def test_cast_timestamp_unit():
assert result.equals(expected)
+def
github-actions[bot] commented on pull request #7810:
URL: https://github.com/apache/arrow/pull/7810#issuecomment-661646798
Revision: 2d6c6d7170486e7c71c752983f15e5b41e037d60
Submitted crossbow builds: [ursa-labs/crossbow @
xhochy commented on pull request #7810:
URL: https://github.com/apache/arrow/pull/7810#issuecomment-661646295
@github-actions crossbow submit conda-win-vs2017-py36
This is an automated message from the Apache Git Service.
To
sagnikc-dremio commented on a change in pull request #7641:
URL: https://github.com/apache/arrow/pull/7641#discussion_r457838825
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -16,6 +16,7 @@
// under the License.
// String functions
+#include
Review
projjal commented on a change in pull request #7641:
URL: https://github.com/apache/arrow/pull/7641#discussion_r457847628
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -322,6 +387,138 @@ const char* trim_utf8(gdv_int64 context, const char*
data, gdv_int32
sagnikc-dremio commented on a change in pull request #7641:
URL: https://github.com/apache/arrow/pull/7641#discussion_r457840242
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -322,6 +387,138 @@ const char* trim_utf8(gdv_int64 context, const char*
data,
sagnikc-dremio commented on a change in pull request #7641:
URL: https://github.com/apache/arrow/pull/7641#discussion_r457843985
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -322,6 +387,138 @@ const char* trim_utf8(gdv_int64 context, const char*
data,
projjal commented on a change in pull request #7641:
URL: https://github.com/apache/arrow/pull/7641#discussion_r457847628
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -322,6 +387,138 @@ const char* trim_utf8(gdv_int64 context, const char*
data, gdv_int32
projjal commented on a change in pull request #7641:
URL: https://github.com/apache/arrow/pull/7641#discussion_r457847628
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -322,6 +387,138 @@ const char* trim_utf8(gdv_int64 context, const char*
data, gdv_int32
jorgecarleitao commented on pull request #7799:
URL: https://github.com/apache/arrow/pull/7799#issuecomment-660824105
Some benchmarks:
* Current: 19m with image caching; 21m without image caching
* This PR: ~8m with image caching; 13m without image caching
(~8 assumes 1m
emkornfield commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660857649
@kou 3.8 should be fine. Thank you!. I copied the command from the previous
PR related to datetimes, I guess CI has changed since then.
BryanCutler opened a new pull request #7804:
URL: https://github.com/apache/arrow/pull/7804
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660848831
https://issues.apache.org/jira/browse/ARROW-9528
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7806:
URL: https://github.com/apache/arrow/pull/7806#issuecomment-660848829
https://issues.apache.org/jira/browse/ARROW-9527
This is an automated message from the Apache Git
BryanCutler commented on pull request #7804:
URL: https://github.com/apache/arrow/pull/7804#issuecomment-660829646
@ursabot crossbow submit test-conda-python-3.8-spark-master
This is an automated message from the Apache Git
emkornfield commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660844779
@github-actions crossbow submit test-conda-python-3.7-spark-master
This is an automated message from the
emkornfield commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457121068
##
File path: cpp/src/arrow/python/inference.cc
##
@@ -332,6 +329,13 @@ class TypeInferrer {
++int_count_;
} else if
emkornfield commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457121774
##
File path: python/pyarrow/scalar.pxi
##
@@ -331,7 +331,8 @@ cdef class Date64Scalar(Scalar):
def as_py(self):
"""
-Return
BryanCutler commented on pull request #7804:
URL: https://github.com/apache/arrow/pull/7804#issuecomment-660828910
@emkornfield @wesm this isn't a proper patch for spark, but should be good
enough to check the test that has been failing if we continue with the changes
from ARROW-9223
kou commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660855376
@github-actions crossbow submit test-conda-python-3.8-spark-master
This is an automated message from the Apache Git
kszucs commented on pull request #7808:
URL: https://github.com/apache/arrow/pull/7808#issuecomment-661255732
The windows failures must be caused by the recent CF dependency updates (at
least setuptools has a different build hash).
They are not mandatory for the release, so +1.
andygrove commented on pull request #7798:
URL: https://github.com/apache/arrow/pull/7798#issuecomment-661255507
@yordan-pavlov This is exciting! I will start reviewing this later today.
This is an automated message from the
jorgecarleitao commented on a change in pull request #7812:
URL: https://github.com/apache/arrow/pull/7812#discussion_r457672336
##
File path: rust/datafusion/src/execution/physical_plan/udf.rs
##
@@ -84,6 +86,19 @@ impl ScalarFunctionExpr {
}
}
+impl fmt::Display for
jorgecarleitao commented on a change in pull request #7812:
URL: https://github.com/apache/arrow/pull/7812#discussion_r457677554
##
File path: rust/datafusion/src/execution/physical_plan/udf.rs
##
@@ -84,6 +86,19 @@ impl ScalarFunctionExpr {
}
}
+impl fmt::Display for
github-actions[bot] commented on pull request #7813:
URL: https://github.com/apache/arrow/pull/7813#issuecomment-661338081
https://issues.apache.org/jira/browse/ARROW-9412
This is an automated message from the Apache Git
tobim opened a new pull request #7813:
URL: https://github.com/apache/arrow/pull/7813
I used the minimal build example to add a test case based on an alpine
docker image.
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7814:
URL: https://github.com/apache/arrow/pull/7814#issuecomment-661345404
Revision: f81412a74c444d1cfff948791283819bd9067162
Submitted crossbow builds: [ursa-labs/crossbow @
kou closed pull request #7791:
URL: https://github.com/apache/arrow/pull/7791
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on pull request #7791:
URL: https://github.com/apache/arrow/pull/7791#issuecomment-661354322
OK!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kszucs commented on pull request #7799:
URL: https://github.com/apache/arrow/pull/7799#issuecomment-660949359
Thanks @jorgecarleitao, it looks like a nice improvement. Currently I'm
working on the next release candidate, but I'll take a look at it afterwards.
kszucs closed pull request #7800:
URL: https://github.com/apache/arrow/pull/7800
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kszucs closed pull request #7801:
URL: https://github.com/apache/arrow/pull/7801
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kszucs commented on pull request #7800:
URL: https://github.com/apache/arrow/pull/7800#issuecomment-660948169
Thanks @projjal!
This is an automated message from the Apache Git Service.
To respond to the message, please log
mr-smidge commented on pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#issuecomment-660971998
@eerhardt , is there a way to re-trigger build checks? The `C# / AMD64
MacOS 10.15 C# 2.2.103 (pull_request)` check failed with an unhelpful "This
check failed" error message
projjal commented on a change in pull request #7641:
URL: https://github.com/apache/arrow/pull/7641#discussion_r45731
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -16,6 +16,7 @@
// under the License.
// String functions
+#include
Review comment:
kszucs closed pull request #7792:
URL: https://github.com/apache/arrow/pull/7792
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kszucs commented on pull request #7792:
URL: https://github.com/apache/arrow/pull/7792#issuecomment-660949955
Closing in favor of
https://github.com/apache/arrow/commit/83679f3b46e2c12e8f506c76323341c1d05b7d01#diff-3ebb5f8536634a43ccb884fcd453b1cdL88
praveenbingo commented on pull request #7782:
URL: https://github.com/apache/arrow/pull/7782#issuecomment-660959362
thanks @sagnikc-dremio
This is an automated message from the Apache Git Service.
To respond to the message,
praveenbingo closed pull request #7782:
URL: https://github.com/apache/arrow/pull/7782
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
projjal commented on a change in pull request #7641:
URL: https://github.com/apache/arrow/pull/7641#discussion_r457316490
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -322,6 +387,138 @@ const char* trim_utf8(gdv_int64 context, const char*
data, gdv_int32
romainfrancois opened a new pull request #7807:
URL: https://github.com/apache/arrow/pull/7807
Either passing down NULL or a Schema.
But perhaps a schema is confusing because the only thing that is being
controlled by it here is the types, not their order etc .. which I believe
github-actions[bot] commented on pull request #7807:
URL: https://github.com/apache/arrow/pull/7807#issuecomment-661060579
https://issues.apache.org/jira/browse/ARROW-6537
This is an automated message from the Apache Git
emkornfield commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457422354
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3325,6 +3325,21 @@ def test_cast_timestamp_unit():
assert result.equals(expected)
1 - 100 of 137 matches
Mail list logo
