[GitHub] [arrow] github-actions[bot] commented on pull request #7863: ARROW-9344: [C++][Flight] Measure latency quantiles

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7863: URL: https://github.com/apache/arrow/pull/7863#issuecomment-666171816 https://issues.apache.org/jira/browse/ARROW-9344 This is an automated message from the Apache Git

[GitHub] [arrow] jianxind commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.

2020-07-30 Thread GitBox
jianxind commented on pull request #7700: URL: https://github.com/apache/arrow/pull/7700#issuecomment-666042625 > Follow up #7607, delegate the SIMD dispatch to kernel level inside the function instance. @wesm @wesm @pitrou @emkornfield Ping, could you help to review this when you

[GitHub] [arrow] github-actions[bot] commented on pull request #7861: ARROW-9597: [C++] AddAlias in compute::FunctionRegistry should be synchronized

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7861: URL: https://github.com/apache/arrow/pull/7861#issuecomment-666063292 https://issues.apache.org/jira/browse/ARROW-9597 This is an automated message from the Apache Git

[GitHub] [arrow] tianchen92 commented on pull request #7861: ARROW-9597: [C++] AddAlias in compute::FunctionRegistry should be synchronized

2020-07-30 Thread GitBox
tianchen92 commented on pull request #7861: URL: https://github.com/apache/arrow/pull/7861#issuecomment-666061321 cc @wesm This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] nealrichardson opened a new pull request #7860: ARROW-9596: [CI][Crossbow] Fix homebrew-cpp again, again

2020-07-30 Thread GitBox
nealrichardson opened a new pull request #7860: URL: https://github.com/apache/arrow/pull/7860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] github-actions[bot] commented on pull request #7858: WIP Rework r-sanitizer tests to build more like CRAN

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7858: URL: https://github.com/apache/arrow/pull/7858#issuecomment-665881367 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] github-actions[bot] commented on pull request #7860: ARROW-9596: [CI][Crossbow] Fix homebrew-cpp again, again

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7860: URL: https://github.com/apache/arrow/pull/7860#issuecomment-665900693 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] emkornfield commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.

2020-07-30 Thread GitBox
emkornfield commented on pull request #7700: URL: https://github.com/apache/arrow/pull/7700#issuecomment-666105439 @jianxind I think @wesm is probably the best person review and I think he'll be back online full time next week.

[GitHub] [arrow] nealrichardson closed pull request #7858: ARROW-9575: [R] gcc-UBSAN failure on CRAN

2020-07-30 Thread GitBox
nealrichardson closed pull request #7858: URL: https://github.com/apache/arrow/pull/7858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] nealrichardson commented on pull request #7858: WIP Rework r-sanitizer tests to build more like CRAN

2020-07-30 Thread GitBox
nealrichardson commented on pull request #7858: URL: https://github.com/apache/arrow/pull/7858#issuecomment-665878405 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] nealrichardson commented on pull request #7860: ARROW-9596: [CI][Crossbow] Fix homebrew-cpp again, again

2020-07-30 Thread GitBox
nealrichardson commented on pull request #7860: URL: https://github.com/apache/arrow/pull/7860#issuecomment-665897641 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] offthewall123 commented on a change in pull request #7815: ARROW-9536: [Java] Miss parameters in PlasmaOutOfMemoryException.java

2020-07-30 Thread GitBox
offthewall123 commented on a change in pull request #7815: URL: https://github.com/apache/arrow/pull/7815#discussion_r462686721 ## File path: java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaOutOfMemoryException.java ## @@ -22,11 +22,11 @@ */ public class

[GitHub] [arrow] cyb70289 opened a new pull request #7863: ARROW-9344: [C++][Flight] Measure latency quantiles

2020-07-30 Thread GitBox
cyb70289 opened a new pull request #7863: URL: https://github.com/apache/arrow/pull/7863 Measure average, median, 95%, 99% quantile and maximal latency. This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] emkornfield opened a new pull request #7862: ARROW-9598: [C++][Parquet] Fix nullable structs

2020-07-30 Thread GitBox
emkornfield opened a new pull request #7862: URL: https://github.com/apache/arrow/pull/7862 Traverse the node hierarchy to ensure we capture the right value count. This is an automated message from the Apache Git Service. To

[GitHub] [arrow] kou commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-07-30 Thread GitBox
kou commented on a change in pull request #7842: URL: https://github.com/apache/arrow/pull/7842#discussion_r462613619 ## File path: cpp/src/arrow/ArrowConfig.cmake.in ## @@ -38,45 +38,42 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowOptions.cmake")

[GitHub] [arrow] nealrichardson closed pull request #7860: ARROW-9596: [CI][Crossbow] Fix homebrew-cpp again, again

2020-07-30 Thread GitBox
nealrichardson closed pull request #7860: URL: https://github.com/apache/arrow/pull/7860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] kou commented on pull request #7818: ARROW-9541: [C++] CMakeLists requires UTF8PROC_STATIC when building static library

2020-07-30 Thread GitBox
kou commented on pull request #7818: URL: https://github.com/apache/arrow/pull/7818#issuecomment-665932951 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] wesm commented on a change in pull request #7851: ARROW-9286: [C++] Add function "aliases" to compute::FunctionRegistry

2020-07-30 Thread GitBox
wesm commented on a change in pull request #7851: URL: https://github.com/apache/arrow/pull/7851#discussion_r462550663 ## File path: cpp/src/arrow/compute/registry.cc ## @@ -45,6 +45,15 @@ class FunctionRegistry::FunctionRegistryImpl { return Status::OK(); } +

[GitHub] [arrow] github-actions[bot] commented on pull request #7862: ARROW-9598: [C++][Parquet] Fix writing nullable structs

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7862: URL: https://github.com/apache/arrow/pull/7862#issuecomment-666104382 https://issues.apache.org/jira/browse/ARROW-9598 This is an automated message from the Apache Git

[GitHub] [arrow] pereverges opened a new issue #7864: stop plasma_store from shell script

2020-07-30 Thread GitBox
pereverges opened a new issue #7864: URL: https://github.com/apache/arrow/issues/7864 What command can I use to stop the plasma_store from a shell script? And can the plasma store be started from the python code? Thank you!

[GitHub] [arrow] kszucs opened a new pull request #7865: [CI] Fix appveyor builds [WIP]

2020-07-30 Thread GitBox
kszucs opened a new pull request #7865: URL: https://github.com/apache/arrow/pull/7865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #7865: [CI] Fix appveyor builds [WIP]

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7865: URL: https://github.com/apache/arrow/pull/7865#issuecomment-666305328 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] kszucs closed pull request #7799: ARROW-7136: [Rust] Added caching to the docker image

2020-07-30 Thread GitBox
kszucs closed pull request #7799: URL: https://github.com/apache/arrow/pull/7799 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] cyb70289 commented on pull request #7863: ARROW-9344: [C++][Flight] Measure latency quantiles

2020-07-30 Thread GitBox
cyb70289 commented on pull request #7863: URL: https://github.com/apache/arrow/pull/7863#issuecomment-666862103 > Looks good overall (one minor nit). Do you have sample results? Test result on my host ``` $ release/arrow-flight-benchmark Using standalone server: false

[GitHub] [arrow] jianxind commented on a change in pull request #7862: ARROW-9598: [C++][Parquet] Fix writing nullable structs

2020-07-30 Thread GitBox
jianxind commented on a change in pull request #7862: URL: https://github.com/apache/arrow/pull/7862#discussion_r463354793 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -2344,6 +2344,23 @@ TEST(ArrowReadWrite, SimpleStructRoundTrip) { 2); }

[GitHub] [arrow] cyb70289 commented on a change in pull request #7863: ARROW-9344: [C++][Flight] Measure latency quantiles

2020-07-30 Thread GitBox
cyb70289 commented on a change in pull request #7863: URL: https://github.com/apache/arrow/pull/7863#discussion_r463366242 ## File path: cpp/src/arrow/flight/flight_benchmark.cc ## @@ -62,20 +69,40 @@ struct PerformanceResult { }; struct PerformanceStats { -

[GitHub] [arrow] GPSnoopy commented on pull request #7818: ARROW-9541: [C++] CMakeLists requires UTF8PROC_STATIC when building static library

2020-07-30 Thread GitBox
GPSnoopy commented on pull request #7818: URL: https://github.com/apache/arrow/pull/7818#issuecomment-666491868 I've merged those changes into the vcpkg PR. Waiting for the results. In the meantime, the vcpkg osx test failed around FindZSTD. Will have to investigate.

[GitHub] [arrow] github-actions[bot] commented on pull request #7866: ARROW-7218: [Python] Conversion from boolean numpy scalars not working

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7866: URL: https://github.com/apache/arrow/pull/7866#issuecomment-666351589 https://issues.apache.org/jira/browse/ARROW-7218 This is an automated message from the Apache Git

[GitHub] [arrow] lidavidm commented on pull request #7863: ARROW-9344: [C++][Flight] Measure latency quantiles

2020-07-30 Thread GitBox
lidavidm commented on pull request #7863: URL: https://github.com/apache/arrow/pull/7863#issuecomment-666374219 > Please **NOTE** this patch uses `boost::accumulators` package, have to install libboost-dev package before building. Hmm, the build system should take care of getting

[GitHub] [arrow] lidavidm commented on a change in pull request #7863: ARROW-9344: [C++][Flight] Measure latency quantiles

2020-07-30 Thread GitBox
lidavidm commented on a change in pull request #7863: URL: https://github.com/apache/arrow/pull/7863#discussion_r463021265 ## File path: cpp/src/arrow/flight/flight_benchmark.cc ## @@ -281,9 +313,12 @@ Status RunPerformanceTest(FlightClient* client, bool test_put) { //

[GitHub] [arrow] github-actions[bot] commented on pull request #7865: ARROW-9599: [CI] Appveyor toolchain build fails because CMake detects different C and C++ compilers

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7865: URL: https://github.com/apache/arrow/pull/7865#issuecomment-666397164 https://issues.apache.org/jira/browse/ARROW-9599 This is an automated message from the Apache Git

[GitHub] [arrow] alamb commented on pull request #7867: ARROW-9600: [Rust][Arrow] pin older version of proc-macro2 during build

2020-07-30 Thread GitBox
alamb commented on pull request #7867: URL: https://github.com/apache/arrow/pull/7867#issuecomment-666404571 I believe I need to get on a CLA list before this can be merged. I am investigating. This is an automated message

[GitHub] [arrow] alamb closed pull request #7867: ARROW-9600: [Rust][Arrow] pin older version of proc-macro2 during build

2020-07-30 Thread GitBox
alamb closed pull request #7867: URL: https://github.com/apache/arrow/pull/7867 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] andygrove commented on pull request #7867: ARROW-9600: [Rust][Arrow] pin older version of proc-macro2 during build

2020-07-30 Thread GitBox
andygrove commented on pull request #7867: URL: https://github.com/apache/arrow/pull/7867#issuecomment-666410584 @alamb I can merge your PR ... no need for CLA This is an automated message from the Apache Git Service. To

[GitHub] [arrow] kszucs opened a new pull request #7866: ARROW-7218: [Python] Conversion from boolean numpy scalars not working

2020-07-30 Thread GitBox
kszucs opened a new pull request #7866: URL: https://github.com/apache/arrow/pull/7866 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #7867: ARROW-9600: [Rust][Arrow] pin older version of proc-macro2 during build

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7867: URL: https://github.com/apache/arrow/pull/7867#issuecomment-666402667 https://issues.apache.org/jira/browse/ARROW-9600 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7868: ARROW-9429: [Python] ChunkedArray.to_numpy

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7868: URL: https://github.com/apache/arrow/pull/7868#issuecomment-666442636 https://issues.apache.org/jira/browse/ARROW-9429 This is an automated message from the Apache Git

[GitHub] [arrow] alamb opened a new pull request #7867: ARROW-9600: [Rust][Arrow] pin older version of proc-macro2 during build

2020-07-30 Thread GitBox
alamb opened a new pull request #7867: URL: https://github.com/apache/arrow/pull/7867 When used as a crate dependency, arrow-flight is rebuilt on every invocation of cargo build # Repro: Create a new repo, add `arrow=1.0.0` as a dependency, and then run `cargo build`

[GitHub] [arrow] kszucs opened a new pull request #7868: ARROW-9429: [Python] ChunkedArray.to_numpy

2020-07-30 Thread GitBox
kszucs opened a new pull request #7868: URL: https://github.com/apache/arrow/pull/7868 While it technically is still using pandas during the conversion it exposes the to_numpy() method. Also refactored the chunked array construction to support more flexible input, see the test

[GitHub] [arrow] tianchen92 opened a new pull request #7861: ARROW-9597: [C++] AddAlias in compute::FunctionRegistry should be synchronized

2020-07-30 Thread GitBox
tianchen92 opened a new pull request #7861: URL: https://github.com/apache/arrow/pull/7861 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] github-actions[bot] commented on pull request #7818: ARROW-9541: [C++] CMakeLists requires UTF8PROC_STATIC when building static library

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7818: URL: https://github.com/apache/arrow/pull/7818#issuecomment-665933833 Revision: f00d46e024caf674ab9dde03aa5a6720cfdda8c8 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] jorgecarleitao commented on pull request #7729: ARROW-9420: [Rust][DataFusion] Added repartion physical plan

2020-07-30 Thread GitBox
jorgecarleitao commented on pull request #7729: URL: https://github.com/apache/arrow/pull/7729#issuecomment-666555314 I don't think we are ready to take repartitioning at this point. This is an automated message from the

[GitHub] [arrow] jorgecarleitao closed pull request #7729: ARROW-9420: [Rust][DataFusion] Added repartion physical plan

2020-07-30 Thread GitBox
jorgecarleitao closed pull request #7729: URL: https://github.com/apache/arrow/pull/7729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] jorgecarleitao commented on pull request #7799: ARROW-7136: [Rust] Added caching to the docker image

2020-07-30 Thread GitBox
jorgecarleitao commented on pull request #7799: URL: https://github.com/apache/arrow/pull/7799#issuecomment-666590004 @kszucs , thank you very much for all the improvements and integration that you've made here. Really useful and appreciated!

[GitHub] [arrow] chrish42 commented on pull request #7110: ARROW-8952: [C++] WIP Support for textual, JSON schema representation

2020-07-30 Thread GitBox
chrish42 commented on pull request #7110: URL: https://github.com/apache/arrow/pull/7110#issuecomment-46994 Work in progress on `Schema:FromJson()`. Doesn't work currently. The FlatBuffer structure generated has 0 fields, even though the JSON data has some. Probably passing the wrong

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7687: ARROW-9382: [Rust][DataFusion] Simplified hash aggregations and added Boolean type

2020-07-30 Thread GitBox
jorgecarleitao commented on a change in pull request #7687: URL: https://github.com/apache/arrow/pull/7687#discussion_r463403608 ## File path: rust/datafusion/src/execution/physical_plan/hash_aggregate.rs ## @@ -327,120 +278,47 @@ impl RecordBatchReader for

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7687: ARROW-9382: [Rust][DataFusion] Simplified hash aggregations and added Boolean type

2020-07-30 Thread GitBox
jorgecarleitao commented on a change in pull request #7687: URL: https://github.com/apache/arrow/pull/7687#discussion_r463200434 ## File path: rust/datafusion/src/execution/physical_plan/hash_aggregate.rs ## @@ -327,120 +278,47 @@ impl RecordBatchReader for

[GitHub] [arrow] andygrove closed pull request #7848: ARROW-9550: [Rust] [DataFusion] Remove use of Rc> in HashAggregate - DRAFT

2020-07-30 Thread GitBox
andygrove closed pull request #7848: URL: https://github.com/apache/arrow/pull/7848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] github-actions[bot] commented on pull request #7869: ARROW-8002: [C++][Dataset][R] Support partitioned dataset writing

2020-07-30 Thread GitBox
github-actions[bot] commented on pull request #7869: URL: https://github.com/apache/arrow/pull/7869#issuecomment-666558756 https://issues.apache.org/jira/browse/ARROW-8002 This is an automated message from the Apache Git

[GitHub] [arrow] bkietz opened a new pull request #7869: ARROW-8002: [C++][Dataset][R] Support partitioned dataset writing

2020-07-30 Thread GitBox
bkietz opened a new pull request #7869: URL: https://github.com/apache/arrow/pull/7869 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] alamb commented on pull request #7867: ARROW-9600: [Rust][Arrow] pin older version of proc-macro2 during build

2020-07-30 Thread GitBox
alamb commented on pull request #7867: URL: https://github.com/apache/arrow/pull/7867#issuecomment-666575451 Thanks @andygrove ! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] andygrove closed pull request #7867: ARROW-9600: [Rust][Arrow] pin older version of proc-macro2 during build

2020-07-30 Thread GitBox
andygrove closed pull request #7867: URL: https://github.com/apache/arrow/pull/7867 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] kou closed pull request #7865: ARROW-9599: [CI] Appveyor toolchain build fails because CMake detects different C and C++ compilers

2020-07-30 Thread GitBox
kou closed pull request #7865: URL: https://github.com/apache/arrow/pull/7865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on pull request #7818: ARROW-9541: [C++] CMakeLists requires UTF8PROC_STATIC when building static library

2020-07-30 Thread GitBox
kou commented on pull request #7818: URL: https://github.com/apache/arrow/pull/7818#issuecomment-666708340 > In the meantime, the vcpkg osx test failed around FindZSTD. I see. We should work on it as a separated task. If these changes solve the utf8proc problem for vcpkg, I

[GitHub] [arrow] kou commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-07-30 Thread GitBox
kou commented on a change in pull request #7842: URL: https://github.com/apache/arrow/pull/7842#discussion_r463288078 ## File path: cpp/cmake_modules/FindSnappy.cmake ## @@ -15,25 +15,33 @@ # specific language governing permissions and limitations # under the License.

[GitHub] [arrow] kou commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-07-30 Thread GitBox
kou commented on a change in pull request #7842: URL: https://github.com/apache/arrow/pull/7842#discussion_r463290240 ## File path: cpp/cmake_modules/FindSnappy.cmake ## @@ -15,25 +15,33 @@ # specific language governing permissions and limitations # under the License.

[GitHub] [arrow] kou commented on issue #7864: stop plasma_store from shell script

2020-07-30 Thread GitBox
kou commented on issue #7864: URL: https://github.com/apache/arrow/issues/7864#issuecomment-97852 > What command can I use to stop the plasma_store from a shell script? ```bash kill ${PLASMA_STORE_PID} ``` > And can the plasma store be started from the python code?

[GitHub] [arrow] andygrove commented on a change in pull request #7687: ARROW-9382: [Rust][DataFusion] Simplified hash aggregations and added Boolean type

2020-07-30 Thread GitBox
andygrove commented on a change in pull request #7687: URL: https://github.com/apache/arrow/pull/7687#discussion_r463289143 ## File path: rust/datafusion/src/execution/physical_plan/hash_aggregate.rs ## @@ -327,120 +278,47 @@ impl RecordBatchReader for

[GitHub] [arrow] wesm commented on pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.

2020-07-30 Thread GitBox
wesm commented on pull request #7700: URL: https://github.com/apache/arrow/pull/7700#issuecomment-666739557 I rebased just to make sure that the Appveyor failure is transient This is an automated message from the Apache Git

[GitHub] [arrow] wesm commented on pull request #7865: ARROW-9599: [CI] Appveyor toolchain build fails because CMake detects different C and C++ compilers

2020-07-30 Thread GitBox
wesm commented on pull request #7865: URL: https://github.com/apache/arrow/pull/7865#issuecomment-666741046 Is there an upstream issue opened? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] wesm closed pull request #7700: ARROW-9398: [C++] Register SIMD sum variants to function instance.

2020-07-30 Thread GitBox
wesm closed pull request #7700: URL: https://github.com/apache/arrow/pull/7700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the