arw2019 commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-734530401
I think the code changes here are ok. However, at least some of the build
errors look related (and persisted across two CI runs) so that's left to figure
out
kou commented on a change in pull request #8756:
URL: https://github.com/apache/arrow/pull/8756#discussion_r531281952
##
File path: cpp/cmake_modules/DefineOptions.cmake
##
@@ -362,7 +362,9 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
kou closed pull request #8756:
URL: https://github.com/apache/arrow/pull/8756
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
arw2019 closed pull request #8782:
URL: https://github.com/apache/arrow/pull/8782
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
liyafan82 closed pull request #8721:
URL: https://github.com/apache/arrow/pull/8721
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8775:
URL: https://github.com/apache/arrow/pull/8775#issuecomment-734212791
https://issues.apache.org/jira/browse/ARROW-10742
This is an automated message from the Apache Git
pitrou commented on pull request #8770:
URL: https://github.com/apache/arrow/pull/8770#issuecomment-734223439
Aggregation benchmarks:
```
benchmark baselinecontender
change %
xhochy closed pull request #8756:
URL: https://github.com/apache/arrow/pull/8756
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chrisavl opened a new pull request #8775:
URL: https://github.com/apache/arrow/pull/8775
This change adds checks so that the same exceptions are raised when creating
an array with a mask using a python sequence or a numpy array.
pitrou edited a comment on pull request #8770:
URL: https://github.com/apache/arrow/pull/8770#issuecomment-734223439
Aggregation benchmarks:
```
benchmark baselinecontender
change %
xhochy commented on a change in pull request #8756:
URL: https://github.com/apache/arrow/pull/8756#discussion_r530938306
##
File path: cpp/cmake_modules/DefineOptions.cmake
##
@@ -362,7 +362,9 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
alamb commented on a change in pull request #8751:
URL: https://github.com/apache/arrow/pull/8751#discussion_r530957868
##
File path: rust/datafusion/src/sql/planner.rs
##
@@ -628,6 +701,53 @@ impl<'a, S: SchemaProvider> SqlToRel<'a, S> {
}
}
+fn
xhochy commented on pull request #8756:
URL: https://github.com/apache/arrow/pull/8756#issuecomment-734224862
@github-actions autotune
This is an automated message from the Apache Git Service.
To respond to the message,
pitrou commented on a change in pull request #8621:
URL: https://github.com/apache/arrow/pull/8621#discussion_r530997361
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1231,6 +1251,302 @@ Result StrptimeResolve(KernelContext* ctx,
const std::vector
nevi-me closed pull request #8773:
URL: https://github.com/apache/arrow/pull/8773
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8776:
URL: https://github.com/apache/arrow/pull/8776#issuecomment-734325402
Revision: 4f279895dc900c5862732ecea3f8ce6526db2027
Submitted crossbow builds: [ursa-labs/crossbow @
pitrou commented on pull request #8774:
URL: https://github.com/apache/arrow/pull/8774#issuecomment-734304025
Note: CI failure is unrelated.
This is an automated message from the Apache Git Service.
To respond to the
pitrou commented on pull request #8776:
URL: https://github.com/apache/arrow/pull/8776#issuecomment-734324232
@github-actions crossbow submit -g python
This is an automated message from the Apache Git Service.
To respond to
pitrou commented on a change in pull request #8755:
URL: https://github.com/apache/arrow/pull/8755#discussion_r530985982
##
File path: cpp/src/arrow/python/io.cc
##
@@ -199,25 +219,32 @@ Result PyReadableFile::Read(int64_t nbytes,
void* out) {
PyObject* bytes_obj =
nevi-me commented on a change in pull request #8731:
URL: https://github.com/apache/arrow/pull/8731#discussion_r531034102
##
File path: rust/datafusion/examples/database_sql.rs
##
@@ -0,0 +1,59 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
jorisvandenbossche commented on a change in pull request #8774:
URL: https://github.com/apache/arrow/pull/8774#discussion_r531036980
##
File path: cpp/src/parquet/statistics.h
##
@@ -206,16 +206,25 @@ class PARQUET_EXPORT Statistics {
/// \param[in] null_count number of
pitrou opened a new pull request #8776:
URL: https://github.com/apache/arrow/pull/8776
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Dandandan commented on pull request #8771:
URL: https://github.com/apache/arrow/pull/8771#issuecomment-734317444
Thanks @nevi-me . I found the comment / previous issue, thanks for the link
to the Jira story. Makes sense to coordinate / plan this a bit :+1:
github-actions[bot] commented on pull request #8776:
URL: https://github.com/apache/arrow/pull/8776#issuecomment-734317354
https://issues.apache.org/jira/browse/ARROW-5679
This is an automated message from the Apache Git
jorisvandenbossche commented on pull request #8776:
URL: https://github.com/apache/arrow/pull/8776#issuecomment-734335703
Looking at that comment with the list of triggered builds, we should add
builds with Python 3.9 to our CI. But that's another issue :)
Dandandan opened a new pull request #8779:
URL: https://github.com/apache/arrow/pull/8779
A thing I noticed while going through some code.
When creating a`MutableBuffer` here only `filter_bytes.len()` are being
allocated, but the capacity can afterwards being increased when adding
nevi-me commented on a change in pull request #8739:
URL: https://github.com/apache/arrow/pull/8739#discussion_r531148917
##
File path: rust/arrow/src/array/equal/structure.rs
##
@@ -30,19 +32,51 @@ fn equal_values(
.iter()
.zip(rhs.child_data())
nevi-me commented on a change in pull request #8739:
URL: https://github.com/apache/arrow/pull/8739#discussion_r531155130
##
File path: rust/arrow/src/array/equal/structure.rs
##
@@ -30,19 +32,51 @@ fn equal_values(
.iter()
.zip(rhs.child_data())
pitrou commented on a change in pull request #8468:
URL: https://github.com/apache/arrow/pull/8468#discussion_r531163812
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -1194,6 +1198,197 @@ void AddSplit(FunctionRegistry* registry) {
#endif
}
+//
github-actions[bot] commented on pull request #8779:
URL: https://github.com/apache/arrow/pull/8779#issuecomment-734404792
https://issues.apache.org/jira/browse/ARROW-10745
This is an automated message from the Apache Git
alamb commented on a change in pull request #8739:
URL: https://github.com/apache/arrow/pull/8739#discussion_r529030845
##
File path: rust/arrow/src/array/equal/structure.rs
##
@@ -30,19 +32,51 @@ fn equal_values(
.iter()
.zip(rhs.child_data())
paddyhoran commented on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-734413544
Hi @vertexclique.
All your contributions are very much appreciated. You are one of the most
advanced contributors to the project meaning that it's important for the
github-actions[bot] commented on pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#issuecomment-734481779
https://issues.apache.org/jira/browse/ARROW-10747
This is an automated message from the Apache Git
Dandandan commented on pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#issuecomment-734488236
I found some further opportunities for optimizing by also reusing the
stringrecord items, for another speed up.
Dandandan commented on pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#issuecomment-734490178
Is ready for review now.
This is an automated message from the Apache Git Service.
To respond to the message,
arw2019 commented on a change in pull request #8774:
URL: https://github.com/apache/arrow/pull/8774#discussion_r531128832
##
File path: cpp/src/parquet/statistics.h
##
@@ -206,16 +206,25 @@ class PARQUET_EXPORT Statistics {
/// \param[in] null_count number of null values
github-actions[bot] commented on pull request #8778:
URL: https://github.com/apache/arrow/pull/8778#issuecomment-734393581
Revision: 9dcade3ee0a4f0c6a712df9869665d103e167a8e
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #8777:
URL: https://github.com/apache/arrow/pull/8777#issuecomment-734382061
https://issues.apache.org/jira/browse/ARROW-10569
This is an automated message from the Apache Git
xhochy opened a new pull request #8778:
URL: https://github.com/apache/arrow/pull/8778
Debugging for #8386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
pitrou opened a new pull request #8777:
URL: https://github.com/apache/arrow/pull/8777
Instead of applying the same boolean filter to all N columns, first convert
to filter to take indices.
Selecting indices of a linear array is much faster, thanks to avoiding
bit-unpacking on the
xhochy commented on pull request #8778:
URL: https://github.com/apache/arrow/pull/8778#issuecomment-734392842
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
Dandandan opened a new pull request #8781:
URL: https://github.com/apache/arrow/pull/8781
Still WIP, but makes CSV reading (quite a bit) faster by reusing a bit more
allocations, doing things a bit more manually.
The nytaxi benchmark speeds up from ~4500ms to ~3500ms.
I think
arw2019 opened a new pull request #8782:
URL: https://github.com/apache/arrow/pull/8782
As per a TODO left in ARROW-3769 / #3721 we can now use the `GTEST_SKIP`
macro in `parquet/encoding-test.cpp`. `GTEST_SKIP` was added in gtest 1.10.0 so
this involves bumping our minimal gtest version
github-actions[bot] commented on pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#issuecomment-734472724
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
github-actions[bot] commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-734472714
https://issues.apache.org/jira/browse/ARROW-10746
This is an automated message from the Apache Git
velvia commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r531184824
##
File path: rust/arrow/src/compute/kernels/boolean.rs
##
@@ -149,6 +150,64 @@ pub fn is_not_null(input: ) ->
Result {
keeratsingh opened a new pull request #8780:
URL: https://github.com/apache/arrow/pull/8780
- This is a POC for the proposed design
[Link](https://docs.google.com/document/d/187DlGpIpOUPGhWvXVQEq0mXw_hdWjzzOuZp0p5qzBp0/edit?usp=sharing)
- This POC only add the retry capability to
github-actions[bot] commented on pull request #8780:
URL: https://github.com/apache/arrow/pull/8780#issuecomment-734457340
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
48 matches
Mail list logo
