[GitHub] [arrow] andygrove commented on pull request #8785: ARROW-10729: [Rust] [DataFusion] Add SQL support for JOIN using implicit syntax

2020-11-29 Thread GitBox
andygrove commented on pull request #8785: URL: https://github.com/apache/arrow/pull/8785#issuecomment-735405468 I rebased after merging the join test and then re-enabled the test that was previously failing. This is an

[GitHub] [arrow] andygrove commented on pull request #8785: ARROW-10729: [Rust] [DataFusion] Add SQL support for JOIN using implicit syntax [WIP]

2020-11-27 Thread GitBox
andygrove commented on pull request #8785: URL: https://github.com/apache/arrow/pull/8785#issuecomment-734952829 @jorgecarleitao I made some improvements to remove any join expressions from the filter which helped for some cases but there is still one failing test related to filter push

[GitHub] [arrow] andygrove commented on pull request #8785: ARROW-10729: [Rust] [DataFusion] Add SQL support for JOIN using implicit syntax [WIP]

2020-11-27 Thread GitBox
andygrove commented on pull request #8785: URL: https://github.com/apache/arrow/pull/8785#issuecomment-734910372 With this syntax, the WHERE clause can contain both JOIN conditions and regular filter conditions. For example: ```sql FROM customer, orders,

[GitHub] [arrow] andygrove commented on pull request #8785: ARROW-10729: [Rust] [DataFusion] Add SQL support for JOIN using implicit syntax [WIP]

2020-11-27 Thread GitBox
andygrove commented on pull request #8785: URL: https://github.com/apache/arrow/pull/8785#issuecomment-734903494 @jorgecarleitao This code is basically working but I think it has exposed a bug in the filter push down logic where it tries to push a filter down through the join where the