[GitHub] [arrow] bkietz edited a comment on pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

2020-11-10 Thread GitBox
bkietz edited a comment on pull request #8256: URL: https://github.com/apache/arrow/pull/8256#issuecomment-725059297 Sorry, my fault: the problem is I've moved the trait to arrow_exports.h so that arrowExports.cpp could access them because I was only thinking of the as_sexp usage. However

[GitHub] [arrow] bkietz edited a comment on pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

2020-11-10 Thread GitBox
bkietz edited a comment on pull request #8256: URL: https://github.com/apache/arrow/pull/8256#issuecomment-724995201 [Another sort of failure you might see:](https://github.com/apache/arrow/pull/8256/checks?check_run_id=1382178751#step:8:3439) ``` ── 5. Failure:

[GitHub] [arrow] bkietz edited a comment on pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

2020-11-10 Thread GitBox
bkietz edited a comment on pull request #8256: URL: https://github.com/apache/arrow/pull/8256#issuecomment-724995201 [Another sort of failure you might see:](https://github.com/apache/arrow/pull/8256/checks?check_run_id=1382178751#step:8:3439) ``` ── 5. Failure:

[GitHub] [arrow] bkietz edited a comment on pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

2020-11-10 Thread GitBox
bkietz edited a comment on pull request #8256: URL: https://github.com/apache/arrow/pull/8256#issuecomment-724985123 @nealrichardson @romainfrancois I've refactored `r6_class_name` to a trait. For simple cases it's no longer necessary to declare the R6 class name- we correctly guess that