[GitHub] [arrow] jameswinegar commented on a change in pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message

[GitBox]

jameswinegar commented on a change in pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#discussion_r563197536



##
File path: rust/datafusion/src/datasource/csv.rs
##
@@ -66,7 +66,10 @@ impl CsvFile {
 let mut filenames: Vec = vec![];
 common::build_file_list(path,  filenames, 
options.file_extension)?;
 if filenames.is_empty() {
-return Err(DataFusionError::Plan("No files 
found".to_string()));
+return Err(DataFusionError::Plan(format!(
+"No files found at {path}",

Review comment:
   fixed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] jameswinegar commented on a change in pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message

[GitBox]

jameswinegar commented on a change in pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#discussion_r563197517



##
File path: rust/arrow-flight/src/arrow.flight.protocol.rs
##
@@ -498,9 +498,8 @@ pub mod flight_service_server {
 #[async_trait]
 pub trait FlightService: Send + Sync + 'static {
 #[doc = "Server streaming response type for the Handshake method."]
-type HandshakeStream: Stream<
-Item = Result,
-> + Send
+type HandshakeStream: Stream>
++ Send

Review comment:
   fixed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org