[GitHub] [arrow] jianxind commented on pull request #7871: ARROW-9605: [C++] Speed up aggregate min/max compute kernels on integer types

2020-09-02 Thread GitBox
jianxind commented on pull request #7871: URL: https://github.com/apache/arrow/pull/7871#issuecomment-685615876 > ARROW_USER_SIMD_LEVEL=none Below is the cmd I used, and compiler vectorise happens only on Int types. ``` ARROW_USER_SIMD_LEVEL=avx2

[GitHub] [arrow] jianxind commented on pull request #7871: ARROW-9605: [C++] Speed up aggregate min/max compute kernels on integer types

2020-08-12 Thread GitBox
jianxind commented on pull request #7871: URL: https://github.com/apache/arrow/pull/7871#issuecomment-673192812 > @ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark --benchmark-filter=MinMax Below is the results for null_percent 0.01% and 0% on

[GitHub] [arrow] jianxind commented on pull request #7871: ARROW-9605: [C++] Speed up aggregate min/max compute kernels on integer types

2020-08-12 Thread GitBox
jianxind commented on pull request #7871: URL: https://github.com/apache/arrow/pull/7871#issuecomment-673186171 @ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark --benchmark-filter=MinMax This is an

[GitHub] [arrow] jianxind commented on pull request #7871: ARROW-9605: [C++] Speed up aggregate min/max compute kernels on integer types

2020-08-12 Thread GitBox
jianxind commented on pull request #7871: URL: https://github.com/apache/arrow/pull/7871#issuecomment-673185847 @ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark --benchmark_filter="MinMax" This is an

[GitHub] [arrow] jianxind commented on pull request #7871: ARROW-9605: [C++] Speed up aggregate min/max compute kernels on integer types

2020-08-12 Thread GitBox
jianxind commented on pull request #7871: URL: https://github.com/apache/arrow/pull/7871#issuecomment-672689445 Ping. @wesm @pitrou Could you help to review this? Similar approach to sum kernel, use compiler to vectorise the NoNulls part, use BitBlockCounter on the 0.01% data.

[GitHub] [arrow] jianxind commented on pull request #7871: ARROW-9605: [C++] Speed up aggregate min/max compute kernels on integer types

2020-08-05 Thread GitBox
jianxind commented on pull request #7871: URL: https://github.com/apache/arrow/pull/7871#issuecomment-669047527 Need a rebase after https://github.com/apache/arrow/pull/7903 This is an automated message from the Apache Git

[GitHub] [arrow] jianxind commented on pull request #7871: ARROW-9605: [C++] Speed up aggregate min/max compute kernels on integer types

2020-07-31 Thread GitBox
jianxind commented on pull request #7871: URL: https://github.com/apache/arrow/pull/7871#issuecomment-666978438 I can trigger a benchmark action once https://github.com/apache/arrow/pull/7870 get merged. Below is the BM data for int types on my setup: ``` Before: