[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8517: ARROW-10381: [Rust] Generalized Ordering for inter-array comparisons

2020-10-27 Thread GitBox
jorgecarleitao commented on a change in pull request #8517: URL: https://github.com/apache/arrow/pull/8517#discussion_r513164636 ## File path: rust/arrow/src/array/ord.rs ## @@ -15,297 +15,280 @@ // specific language governing permissions and limitations // under the

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8517: ARROW-10381: [Rust] Generalized Ordering for inter-array comparisons

2020-10-24 Thread GitBox
jorgecarleitao commented on a change in pull request #8517: URL: https://github.com/apache/arrow/pull/8517#discussion_r511491453 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -453,49 +466,46 @@ pub fn lexsort(columns: &[SortColumn]) -> Result> { /// Sort

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8517: ARROW-10381: [Rust] Generalized Ordering for inter-array comparisons

2020-10-24 Thread GitBox
jorgecarleitao commented on a change in pull request #8517: URL: https://github.com/apache/arrow/pull/8517#discussion_r511491453 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -453,49 +466,46 @@ pub fn lexsort(columns: &[SortColumn]) -> Result> { /// Sort