[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Create test to receive RecordBatch for different endian

2020-07-12 Thread GitBox 


kiszk commented on pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#issuecomment-657310102


   Thank you for your clarification. I thought that I will check in binary 
files and write C++ files to validate the result to be read.
   
   Now, I realized the integration test `archery integration ...` will kick 
`arrow-json-integration-test --integration --mode VALIDATE --json ... --arrow 
...`. I will stick with ``archery integration ...`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Create test to receive RecordBatch for different endian

2020-07-12 Thread GitBox 


kiszk commented on pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#issuecomment-657261835


   @wesm Can I ask a question?  I am writing a test case after creating a 
point-of-truth JSON file and generating two arrow binary files for BE and LE. 
Is this my approach what you suggested?  I am writing a function 
`MakePrimitiveBatch()` by importing values from the point-of-truth JSON file.
   
   https://gist.github.com/kiszk/bccb2640a68b706049c1631ba9514eae 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kiszk commented on pull request #7507: ARROW-8797: [C++] Create test to receive RecordBatch for different endian

2020-07-01 Thread GitBox 


kiszk commented on pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#issuecomment-652482871


   @wesm Thank you for your suggestion. I will pursue the approach that you 
suggested. I will check the integration test command line tool and the 
integration test with the JSON_TO_ARROW mode.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org