[GitHub] [arrow] kszucs commented on a change in pull request #7478: ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type

kszucs commented on a change in pull request #7478: URL: https://github.com/apache/arrow/pull/7478#discussion_r446266184 ## File path: cpp/src/arrow/compute/kernels/aggregate_test.cc ## @@ -399,15 +434,59 @@ class TestNumericMinMaxKernel : public ::testing::Test { };

[GitHub] [arrow] kszucs commented on a change in pull request #7478: ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type

kszucs commented on a change in pull request #7478: URL: https://github.com/apache/arrow/pull/7478#discussion_r446264863 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -397,24 +452,26 @@ struct MinMaxImpl : public ScalarAggregator { ArrayType

[GitHub] [arrow] kszucs commented on a change in pull request #7478: ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type

kszucs commented on a change in pull request #7478: URL: https://github.com/apache/arrow/pull/7478#discussion_r446219965 ## File path: cpp/src/arrow/compute/kernels/aggregate_test.cc ## @@ -399,15 +434,59 @@ class TestNumericMinMaxKernel : public ::testing::Test { };

[GitHub] [arrow] kszucs commented on a change in pull request #7478: ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type

kszucs commented on a change in pull request #7478: URL: https://github.com/apache/arrow/pull/7478#discussion_r445007543 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -397,24 +452,26 @@ struct MinMaxImpl : public ScalarAggregator { ArrayType

[GitHub] [arrow] kszucs commented on a change in pull request #7478: ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type

kszucs commented on a change in pull request #7478: URL: https://github.com/apache/arrow/pull/7478#discussion_r445006111 ## File path: cpp/src/arrow/testing/gtest_util.h ## @@ -137,6 +137,8 @@ namespace arrow { //

[GitHub] [arrow] kszucs commented on a change in pull request #7478: ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type

kszucs commented on a change in pull request #7478: URL: https://github.com/apache/arrow/pull/7478#discussion_r442864766 ## File path: cpp/src/arrow/compute/kernels/aggregate_test.cc ## @@ -399,15 +434,59 @@ class TestNumericMinMaxKernel : public ::testing::Test { };

[GitHub] [arrow] kszucs commented on a change in pull request #7478: ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type

kszucs commented on a change in pull request #7478: URL: https://github.com/apache/arrow/pull/7478#discussion_r442864422 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -339,13 +366,38 @@ std::unique_ptr MeanInit(KernelContext* ctx, const KernelInitArgs&

[GitHub] [arrow] kszucs commented on a change in pull request #7478: ARROW-9055: [C++] Add sum/mean/minmax kernels for Boolean type

kszucs commented on a change in pull request #7478: URL: https://github.com/apache/arrow/pull/7478#discussion_r442863137 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -397,24 +452,26 @@ struct MinMaxImpl : public ScalarAggregator { ArrayType