[GitHub] [arrow] kszucs commented on pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-07-06 Thread GitBox
kszucs commented on pull request #7519: URL: https://github.com/apache/arrow/pull/7519#issuecomment-654308059 @pitrou updated. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] kszucs commented on pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-07-06 Thread GitBox
kszucs commented on pull request #7519: URL: https://github.com/apache/arrow/pull/7519#issuecomment-654234467 @pitrou added the C++ tests. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] kszucs commented on pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-26 Thread GitBox
kszucs commented on pull request #7519: URL: https://github.com/apache/arrow/pull/7519#issuecomment-650158531 I'm considering to apply [cython.freelist](https://cython.readthedocs.io/en/latest/src/userguide/extension_types.html#fast-instantiation) on the scalar extension classes.

[GitHub] [arrow] kszucs commented on pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-26 Thread GitBox
kszucs commented on pull request #7519: URL: https://github.com/apache/arrow/pull/7519#issuecomment-650149745 > Could we add a `is_valid` attribute to the python scalar as well? Now the only way to check for a null value is to do `.as_py() is None` ? Added.

[GitHub] [arrow] kszucs commented on pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-25 Thread GitBox
kszucs commented on pull request #7519: URL: https://github.com/apache/arrow/pull/7519#issuecomment-649590873 > Really nice! > > Could we add a `is_valid` attribute to the python scalar as well? Now the only way to check for a null value is to do `.as_py() is None` ?