[GitHub] [arrow] maartenbreddels commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

maartenbreddels commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r560244159 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -186,16 +172,51 @@ struct UTF8Transform { } }; +#ifdef ARROW_WITH_UTF8PROC

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

maartenbreddels commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r555979359 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -186,6 +172,40 @@ struct UTF8Transform { } }; +#ifdef ARROW_WITH_UTF8PROC

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

maartenbreddels commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r555979073 ## File path: cpp/src/arrow/util/utf8.h ## @@ -456,6 +456,67 @@ static inline bool UTF8Transform(const uint8_t* first, const uint8_t* last,

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

maartenbreddels commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r545867768 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1231,6 +1251,302 @@ Result StrptimeResolve(KernelContext* ctx, const

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

maartenbreddels commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r545752285 ## File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc ## @@ -428,6 +428,59 @@ TYPED_TEST(TestStringKernels,

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

maartenbreddels commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r521422359 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1231,6 +1251,305 @@ Result StrptimeResolve(KernelContext* ctx, const

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

maartenbreddels commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r520802117 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1231,6 +1252,302 @@ Result StrptimeResolve(KernelContext* ctx, const