[GitHub] [arrow] maartenbreddels commented on pull request #8628: ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string])

2020-11-13 Thread GitBox 


maartenbreddels commented on pull request #8628:
URL: https://github.com/apache/arrow/pull/8628#issuecomment-726748561


   @pitrou i think this is ready to go/review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] maartenbreddels commented on pull request #8628: ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string])

2020-11-10 Thread GitBox 


maartenbreddels commented on pull request #8628:
URL: https://github.com/apache/arrow/pull/8628#issuecomment-724881905


   Looking at the implementation of `VisitArrayDataInline`, which is quite 
similar to what is being done in `FillNullFunctor::value>>`, I don't see much room for 
improvement.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org