mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-820963616
@pitrou Really thanks for your detailed comments! I have addressed all of
them. Please review again since we need to release it. Thanks!
--
This is an automated
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-819293482
> Sorry still reviewing, will try to do more tomorrow.
That's fine. I have addressed all the comments you gave and pushed.
--
This is an automated message from the
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-817451185
@pitrou I completely revamped adapter_util.cc and switched to
arrow::ArrayDataVisitor. That is, all comments have been addressed. Please
review.
--
This is an automated
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-798971411
@pitrou Could you please check again? My next PR is going to be ready soon
and it is dependent on this one merging to be clean.
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-796515523
@pitrou These two errors should be intermittent and have nothing to do with
ORC. So please review again. Thanks!
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-793383602
@pitrou Now all tests have passed. Please review.
@kou That’s fine haha. Next time I will check these files as well!
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-792387596
@kou Really thanks! I didn't realize that arrow::Type::type::MAP was not
fully supported!
This is an
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-792360387
@kou Thanks! I think I have already made all the changes in GLib (more
precisely the Ruby tests) I think I need to make. Not sure why adding maps to
buildable.rb led to a
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-792195893
@pitrou Now the problem has been fixed and it is ready for another review.
@kou I managed to install Arrow GLib as a developer but didn't manage to run
the tests in Ruby
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-792154086
@pitrou I have found the cause of the problem which is me failing to account
for the possibility of orc::Decimal64VectorBatch. I will edit my writer to
account for that.
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-791209166
@pitrou Yup I found your changes to Random 6 days ago in Arrow-11662. Things
did break after that. Now I’m trying to figure out whether it is my ORC writer
or Decimal128
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-790615411
@pitrou It is due to some new issue in Decimal128s. Starting from
https://github.com/apache/arrow/pull/8648/commits/68fd76fc5eba3350f341eb0fd7e4f83f7c83c51e
we suddenly
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-790297527
@pitrou Yes now it is ready for another review.
This is an automated message from the Apache Git Service.
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-775537466
> @mathyingzhou Feel free to ping me when this is ready for review again!
Thanks! Right now it seems that I will have to fix a bug in
arrow/testing/random first if I
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-773880147
I will make some further changes to the code to address Micah Kornfield's
concerns but pretty much that's it. Further simplification of the tests require
serious expansion
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-773880147
I will make some further changes to the code to address Micah Kornfield's
concerns but pretty much that's it. Further simplification of the tests require
serious expansion
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-764050107
> I didn't see anything rust related in this PR so I removed the Rust label
@alamb Sorry it didn’t appear in the right place but there is nothing
parquet-related in
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-764050107
> I didn't see anything rust related in this PR so I removed the Rust label
@alamb Sorry it didn’t appear in the right place but there is nothing
parquet-related in
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-759780885
@nevi-me Thanks! That’s done! I’m waiting for the PR to be reviewed and
merged..
This is an automated
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-759104480
@xhochy Please review it when you can. Thanks!
This is an automated message from the Apache Git Service.
To
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-757507160
I have finished the Python binding as well. Note that I have made no changes
to the Rust code.
This is an
21 matches
Mail list logo
