[GitHub] [arrow] pitrou commented on a change in pull request #7504: ARROW-9193: [C++] Add method to parse date from null-terminated string

2020-06-22 Thread GitBox
pitrou commented on a change in pull request #7504: URL: https://github.com/apache/arrow/pull/7504#discussion_r443441540 ## File path: cpp/src/gandiva/to_date_holder.cc ## @@ -83,7 +83,7 @@ int64_t ToDateHolder::operator()(ExecutionContext* context, const std::string& d //

[GitHub] [arrow] pitrou commented on a change in pull request #7504: ARROW-9193: [C++] Add method to parse date from null-terminated string

2020-06-22 Thread GitBox
pitrou commented on a change in pull request #7504: URL: https://github.com/apache/arrow/pull/7504#discussion_r443432735 ## File path: cpp/src/gandiva/to_date_holder.cc ## @@ -83,7 +83,7 @@ int64_t ToDateHolder::operator()(ExecutionContext* context, const std::string& d //

[GitHub] [arrow] pitrou commented on a change in pull request #7504: ARROW-9193: [C++] Add method to parse date from null-terminated string

2020-06-22 Thread GitBox
pitrou commented on a change in pull request #7504: URL: https://github.com/apache/arrow/pull/7504#discussion_r443428904 ## File path: cpp/src/arrow/util/value_parsing.h ## @@ -565,6 +565,39 @@ static inline bool ParseTimestampStrptime(const char* buf, size_t length,