[GitHub] [arrow] pitrou commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

2021-01-19 Thread GitBox
pitrou commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r560227216 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -186,16 +172,51 @@ struct UTF8Transform { } }; +#ifdef ARROW_WITH_UTF8PROC + +//

[GitHub] [arrow] pitrou commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

2021-01-04 Thread GitBox
pitrou commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r551437108 ## File path: cpp/src/arrow/util/utf8.h ## @@ -456,6 +456,67 @@ static inline bool UTF8Transform(const uint8_t* first, const uint8_t* last, return true;

[GitHub] [arrow] pitrou commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

2020-11-26 Thread GitBox
pitrou commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r530997361 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1231,6 +1251,302 @@ Result StrptimeResolve(KernelContext* ctx, const std::vector

[GitHub] [arrow] pitrou commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

2020-11-10 Thread GitBox
pitrou commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r520803595 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1231,6 +1252,302 @@ Result StrptimeResolve(KernelContext* ctx, const std::vector

[GitHub] [arrow] pitrou commented on a change in pull request #8621: ARROW-9128: [C++] Implement string space trimming kernels: trim, ltrim, and rtrim

2020-11-10 Thread GitBox
pitrou commented on a change in pull request #8621: URL: https://github.com/apache/arrow/pull/8621#discussion_r520675172 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -1231,6 +1252,302 @@ Result StrptimeResolve(KernelContext* ctx, const std::vector