[GitHub] [arrow] wesm commented on a change in pull request #7535: ARROW-9222: [Format][DONOTMERGE] Columnar.rst changes for removing validity bitmap from union types

2020-06-30 Thread GitBox 


wesm commented on a change in pull request #7535:
URL: https://github.com/apache/arrow/pull/7535#discussion_r447692444



##
File path: docs/source/format/Columnar.rst
##
@@ -688,11 +687,10 @@ will have the following layout: ::
 ||---|
 | joemark| unspecified (padding) |
 
-Similar to structs, a particular child array may have a non-null slot
-even if the validity bitmap of the parent union array indicates the
-slot is null.  Additionally, a child array may have a non-null slot
-even if the types array indicates that a slot contains a different
-type at the index.
+Note that a child array may have a non-null slot even if the types array
+indicates that a slot contains a different type at the index, so the

Review comment:
   OK





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] wesm commented on a change in pull request #7535: ARROW-9222: [Format][DONOTMERGE] Columnar.rst changes for removing validity bitmap from union types

2020-06-30 Thread GitBox 


wesm commented on a change in pull request #7535:
URL: https://github.com/apache/arrow/pull/7535#discussion_r447691975



##
File path: docs/source/format/Columnar.rst
##
@@ -566,33 +572,28 @@ having the values: ``[{f=1.2}, null, {f=3.4}, {i=5}]``
 ::
 
 * Length: 4, Null count: 1
-* Validity bitmap buffer:
-  |Byte 0 (validity bitmap) | Bytes 1-63|
-  |-|---|
-  |1101 | 0 (padding)   |
-
 * Types buffer:
 
   |Byte 0   | Byte 1  | Byte 2   | Byte 3   | Bytes 4-63  |
   |-|-|--|--|-|
-  | 0   | unspecified | 0| 1| unspecified |
+  | 0   | 0   | 0| 1| unspecified |
 
 * Offset buffer:
 
   |Bytes 0-3 | Bytes 4-7   | Bytes 8-11 | Bytes 12-15 | Bytes 16-63 |
   |--|-||-|-|
-  | 0| unspecified | 1  | 0   | unspecified |
+  | 0| 1   | 2  | 0   | unspecified |
 
 * Children arrays:
   * Field-0 array (f: float):
 * Length: 2, nulls: 0

Review comment:
   Yes





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org