[GitHub] [arrow] wesm commented on a change in pull request #7558: ARROW-9250: [C++] Instantiate fewer templates in IsIn, Match kernel implementations

[GitBox]

wesm commented on a change in pull request #7558:
URL: https://github.com/apache/arrow/pull/7558#discussion_r446571732



##########
File path: cpp/src/arrow/type.h
##########
@@ -900,7 +902,7 @@ class ARROW_EXPORT LargeStringType : public LargeBinaryType 
{
  public:
   static constexpr Type::type type_id = Type::LARGE_STRING;
   static constexpr bool is_utf8 = true;
-  using EquivalentBinaryType = LargeBinaryType;
+  using PhysicalType = LargeBinaryType;

Review comment:
       These changes are for consistency with the `PhysicalType` attributes 
added to the CType-based types




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org