wesm commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-639178716
+1. I'm going to go ahead and merge this and then I'll rebase #7352
This is an automated message from the Apache
wesm commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-637180635
I'll kick the tires on this re: performance. Is this ready to merge
otherwise?
This is an automated message from
wesm commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-622493938
> I might lean towards macros around FMV for clang/GCC that could enable
fallback to a slow version for MSVC
FTR, it would seem unfortunate to do the work of SIMD-ifying code
wesm commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-622409707
The 32-bit R failure seems like it could be real
This is an automated message from the Apache Git Service.
To
wesm commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-622373323
Take a look at how this is currently being handled in NumPy
* https://numpy.org/neps/nep-0038-SIMD-optimizations.html
* https://github.com/numpy/numpy/pull/13516
I
wesm commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-622371728
What I've seen other projects do (have to dig for some examples) is to have
files like
```
functionality_nosimd.cc
functionality_sse42.cc
functionality_avx2.cc
```
wesm commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-622155576
I think this is fine to merge once most of the typos in the comments are
fixed. A rebase will probably fix the Rust lint error
wesm commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-621993208
Yep sorry thanks for the nudge, will look today
This is an automated message from the Apache Git Service.
To
wesm commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-619653776
I'll try to have a closer look tomorrow or Tuesday
This is an automated message from the Apache Git Service.
To
