[GitHub] [arrow] xhochy commented on pull request #7656: ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels

2020-07-10 Thread GitBox
xhochy commented on pull request #7656: URL: https://github.com/apache/arrow/pull/7656#issuecomment-656648586 > Does that build maybe pick up an older version of utf8proc somehow? Yes, it is picking up `utf8proc` 2.1.0.

[GitHub] [arrow] xhochy commented on pull request #7656: ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels

2020-07-07 Thread GitBox
xhochy commented on pull request #7656: URL: https://github.com/apache/arrow/pull/7656#issuecomment-655000427 > Are there plans to support utf16/32? Seeing the code as it is now, it would be trivial to add. This would be a longer discussion. Personally I would vote "no" to limit the

[GitHub] [arrow] xhochy commented on pull request #7656: ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels

2020-07-07 Thread GitBox
xhochy commented on pull request #7656: URL: https://github.com/apache/arrow/pull/7656#issuecomment-654996646 I'm indifferent to `utf8_` vs `string_` (sometimes our codebase is too) but other than that I fully agree to @wesm naming scheme.