[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-07-14 Thread GitBox
nevi-me commented on pull request #389: URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-879957634 @alamb I need this PR to fix a test failure on the map PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-07-13 Thread GitBox
nevi-me commented on pull request #389: URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-878805545 @bjchambers I forgot to go back to #514 and add details there. I tried your test case on master and on this PR, and it passed on this PR, but with a slight change to the test

[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-07-13 Thread GitBox
nevi-me commented on pull request #389: URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-878803600 > A test for concatenation of sliced StructArrays would be nice to have. @jhorstmann this already exists at

[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-07-11 Thread GitBox
nevi-me commented on pull request #389: URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-877780039 @jorgecarleitao @jhorstmann @bjchambers this is ready for review, and partially fixes #514 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-06-05 Thread GitBox
nevi-me commented on pull request #389: URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-855295792 @jhorstmann I'm still looking into this. Nested list slices currently don't work in the main branch; that's what made me come back to this issue. The primitive in `>` only sees

[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-06-01 Thread GitBox
nevi-me commented on pull request #389: URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-852610400 @jorgecarleitao I have the below failures, which are mostly related to `MutableArrayData`. I need your help when you have some time to spare. I worked on this over the