[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-07-14 Thread GitBox 


nevi-me commented on pull request #389:
URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-879957634


   @alamb I need this PR to fix a test failure on the map PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-07-13 Thread GitBox 


nevi-me commented on pull request #389:
URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-878805545


   @bjchambers I forgot to go back to #514 and add details there. I tried your 
test case on master and on this PR, and it passed on this PR, but with a slight 
change to the test case.
   
   I made the below change, and the test passed. 
   
   ```diff
   let a = make_struct(vec![
   -   None,
   +   Some((None, None)),
   Some((Some("joe"), Some(1))),
   Some((None, Some(2))),
   Some((None, None)),
   Some((Some("mark"), Some(4))),
   Some((Some("doe"), Some(5))),
   ]);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-07-13 Thread GitBox 


nevi-me commented on pull request #389:
URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-878803600


   > A test for concatenation of sliced StructArrays would be nice to have.
   
   @jhorstmann this already exists at 
https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/concat.rs#L367-L409,
 it was added by @bjchambers 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-07-11 Thread GitBox 


nevi-me commented on pull request #389:
URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-877780039


   @jorgecarleitao @jhorstmann @bjchambers this is ready for review, and 
partially fixes #514 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-06-05 Thread GitBox 


nevi-me commented on pull request #389:
URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-855295792


   @jhorstmann I'm still looking into this. Nested list slices currently don't 
work in the main branch; that's what made me come back to this issue. The 
primitive in `>` only sees the offset and length of its 
parent list, which in `master` is not updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow-rs] nevi-me commented on pull request #389: make slice work for nested types

2021-06-01 Thread GitBox 


nevi-me commented on pull request #389:
URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-852610400


   @jorgecarleitao I have the below failures, which are mostly related to 
`MutableArrayData`. I need your help when you have some time to spare.
   
   I worked on this over the weekend out of curiousity, so I'll continue 
working on the other tests this week.
   
   ```
   failures:
   array::array_union::tests::test_dense_mixed_with_nulls_and_offset
   array::array_union::tests::test_sparse_mixed_with_nulls_and_offset
   array::transform::tests::test_list_append
   array::transform::tests::test_list_nulls_append
   array::transform::tests::test_struct_offset
   compute::kernels::cast::tests::test_list_cast_offsets
   compute::kernels::concat::tests::test_concat_struct_array_slices
   json::writer::tests::write_dictionary
   json::writer::tests::write_nested_list
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org