Re: [PR] GCP: fix copy (no) overwrite semantics [arrow-rs-object-store]
tustvold merged PR #713: URL: https://github.com/apache/arrow-rs-object-store/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GCP: fix copy (no) overwrite semantics [arrow-rs-object-store]
james-rms commented on PR #713: URL: https://github.com/apache/arrow-rs-object-store/pull/713#issuecomment-4481904483 @tustvold @crepererum sorry to bother - this feels reasonably high-impact to me as well as very simple to review. Are either of you available to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GCP: fix copy (no) overwrite semantics [arrow-rs-object-store]
james-rms commented on PR #713: URL: https://github.com/apache/arrow-rs-object-store/pull/713#issuecomment-4396409077 Note: I believe the GCS emulator used in tests does not support object versioning, so I didn't try to add a test here. Up to reviewers judgement though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] GCP: fix copy (no) overwrite semantics [arrow-rs-object-store]
james-rms opened a new pull request, #713: URL: https://github.com/apache/arrow-rs-object-store/pull/713 # Which issue does this PR close? Closes #712 The bug is explained in the PR description, can create an issue for completeness if required. # Rationale for this change On `main`, `GoogleCloudStorage::copy(src, dst)` fails with `Error::AlreadyExists` if `dst` is the path to an existing object. This is the wrong default behavior - CopyMode defaults to Overwrite, not Create. This happens because of a bug in `GoogleCloudStorage::copy_opts`, where CopyMode::Overwrite gets mapped to `if_not_exists = true` instead of `false`. This PR fixes and moves the boolean mapping closest to where it gets used, to minimise confusion. # What changes are included in this PR? # Are there any user-facing changes? Yes. Anyone using GoogleCloudStorage::copy today who is relying on the incorrect behavior will see objects getting overwritten instead of an error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
