Re: [I] Improve IPCTests [arrow-swift]
kou commented on issue #96: URL: https://github.com/apache/arrow-swift/issues/96#issuecomment-3574044870 > Maybe it's worth thinking about setting up executable targets to support Archery? These could probably be referenced in a Swift test target. If we want to use gold files, yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Improve IPCTests [arrow-swift]
willtemperley commented on issue #96: URL: https://github.com/apache/arrow-swift/issues/96#issuecomment-3574028594 I'd like to use the gold files in `arrow-ipc-stream/integration/cpp-21.0.0`, e.g. ``` generated_binary.arrow_file generated_binary.json.gz generated_binary.stream ``` My initial thought was to set up a test target to read the JSON files, however I now realise these are part of Archery. Maybe it's worth thinking about setting up executable targets to support Archery? These could probably be referenced in a Swift test target. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Improve IPCTests [arrow-swift]
willtemperley commented on issue #96: URL: https://github.com/apache/arrow-swift/issues/96#issuecomment-3573918722 I haven't thought much about the fuzz files yet. I want to use thes ones: https://github.com/apache/arrow-testing/tree/master/data/arrow-ipc-stream/integration/cpp-21.0.0 The directory is arrow-ipc-stream but it contains both IPC and stream files, e.g: generated_binary.arrow_file generated_binary.json.gz generated_binary.stream The generated json / arrow file combo is really useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Improve IPCTests [arrow-swift]
kou commented on issue #96: URL: https://github.com/apache/arrow-swift/issues/96#issuecomment-3573865128 We can do it. Do you want to use files generated by OSS-Fuzz, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Improve IPCTests [arrow-swift]
willtemperley commented on issue #96: URL: https://github.com/apache/arrow-swift/issues/96#issuecomment-3573845804 Maybe we could add arrow-testing as a git submodule? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Improve IPCTests [arrow-swift]
willtemperley commented on issue #96: URL: https://github.com/apache/arrow-swift/issues/96#issuecomment-3399874431 > Should our reader implementation rejects data that don't have padding as the first step? Yes agreed that should happen. However without testing against other implementations, the potential for matching bugs in reader and writer implementations remains. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Improve IPCTests [arrow-swift]
kou commented on issue #96: URL: https://github.com/apache/arrow-swift/issues/96#issuecomment-3397785742 The current our reader implementation accepts both of data that have padding and data that don't have padding, right? Should our reader implementation rejects data that don't have padding as the first step? We should use Archery based integration test eventually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
