Re: [PR] GH-37891: [C++] Refine class parquet::encryption::FileSystemKeyMaterialStore [arrow]
wgtmac commented on PR #46202: URL: https://github.com/apache/arrow/pull/46202#issuecomment-2822962291 Yes, I think we should not create similar PRs for a single issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-37891: [C++] Refine class parquet::encryption::FileSystemKeyMaterialStore [arrow]
kapoisu commented on PR #46202: URL: https://github.com/apache/arrow/pull/46202#issuecomment-2822932333 > Are these the only places that we can apply it? Any other similar place in the parquet subdirectory? I'm sure there are more (e.g. FileKeyWrapper). Further changes can be included in this PR if that is desirable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-37891: [C++] Refine class parquet::encryption::FileSystemKeyMaterialStore [arrow]
wgtmac commented on PR #46202: URL: https://github.com/apache/arrow/pull/46202#issuecomment-2822809864 Are these the only places that we can apply it? Any other similar place in the parquet subdirectory? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-37891: [C++] Refine class parquet::encryption::FileSystemKeyMaterialStore [arrow]
kapoisu commented on PR #46202: URL: https://github.com/apache/arrow/pull/46202#issuecomment-2821995362 I've reverted the incorrect change within key_wrapping_test.cc. The file_system shouldn't be moved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
