Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-21 Thread via GitHub


conbench-apache-arrow[bot] commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2605999871

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have 
been run so far on merge-commit 984519dd77629646f42a3bb6946b201ba4108c8e.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/35965186099) 
has more details. It also includes information about 4 possible false positives 
for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-21 Thread via GitHub


raulcd merged PR #45189:
URL: https://github.com/apache/arrow/pull/45189


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-17 Thread via GitHub


raulcd commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2598288981

   CI failures are unrelated, they are failing on main and I've opened 
individual issues to track them.
   
   @pitrou I've rebased after the required cython bump. This should be ready to 
review/merge now that there's no CI failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-17 Thread via GitHub


github-actions[bot] commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2598219939

   Revision: 0a1d214724874f475c47d8e7e4f640c044e9ed47
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-74244302df](https://github.com/ursacomputing/crossbow/branches/all?query=actions-74244302df)
   
   |Task|Status|
   ||--|
   |example-python-minimal-build-fedora-conda|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-example-python-minimal-build-fedora-conda)](https://github.com/ursacomputing/crossbow/actions/runs/12828672815/job/35773211969)|
   |example-python-minimal-build-ubuntu-venv|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-example-python-minimal-build-ubuntu-venv)](https://github.com/ursacomputing/crossbow/actions/runs/12828672732/job/35773211203)|
   |test-conda-python-3.10|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.10)](https://github.com/ursacomputing/crossbow/actions/runs/12828672879/job/35773212509)|
   |test-conda-python-3.10-hdfs-2.9.2|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.10-hdfs-2.9.2)](https://github.com/ursacomputing/crossbow/actions/runs/12828672739/job/35773211278)|
   |test-conda-python-3.10-hdfs-3.2.1|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.10-hdfs-3.2.1)](https://github.com/ursacomputing/crossbow/actions/runs/12828673008/job/35773213732)|
   |test-conda-python-3.10-pandas-latest-numpy-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.10-pandas-latest-numpy-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12828673043/job/35773213946)|
   |test-conda-python-3.10-substrait|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.10-substrait)](https://github.com/ursacomputing/crossbow/actions/runs/12828672607/job/35773210416)|
   |test-conda-python-3.11|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.11)](https://github.com/ursacomputing/crossbow/actions/runs/12828672838/job/35773212554)|
   |test-conda-python-3.11-dask-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.11-dask-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12828672765/job/35773211424)|
   |test-conda-python-3.11-dask-upstream_devel|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.11-dask-upstream_devel)](https://github.com/ursacomputing/crossbow/actions/runs/12828673359/job/35773215615)|
   |test-conda-python-3.11-hypothesis|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.11-hypothesis)](https://github.com/ursacomputing/crossbow/actions/runs/12828673021/job/35773213468)|
   |test-conda-python-3.11-pandas-latest-numpy-1.26|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.11-pandas-latest-numpy-1.26)](https://github.com/ursacomputing/crossbow/actions/runs/12828672793/job/35773211574)|
   |test-conda-python-3.11-pandas-latest-numpy-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.11-pandas-latest-numpy-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12828672941/job/35773213466)|
   |test-conda-python-3.11-pandas-nightly-numpy-nightly|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.11-pandas-nightly-numpy-nightly)](https://github.com/ursacomputing/crossbow/actions/runs/12828673343/job/35773215580)|
   |test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-74244302df-github-test-conda-python-3.11-pandas-upstream_devel-numpy-nightly)](https://github.com/ursacomputing/crossbow/actions/runs/12828673007/job/35773213690)|
   |test-conda-pyth

Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-17 Thread via GitHub


raulcd commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2598215431

   @github-actions crossbow submit -g python


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-13 Thread via GitHub


raulcd commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2586821746

   > I would say we can drop the cython 2 support.
   
   I created an issue to track that as it is not the first time we say the 
same. I'll do and then I'll rebase this one. I'll ping to merge once CI is 
green again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-13 Thread via GitHub


jorisvandenbossche commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2586762074

   I would say we can drop the cython 2 support. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-13 Thread via GitHub


pitrou commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2586751060

   Ok, so the shared_ptr version works but not the unique_ptr one? In this 
case, we can keep using the shared_ptr approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-13 Thread via GitHub


pitrou commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2586751954

   By the way, why do we want to support Cython 2? @jorisvandenbossche 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-08 Thread via GitHub


github-actions[bot] commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2577242733

   Revision: f292cc101be901b98b0d9357db5b564efee76de7
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-58dca82b3c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-58dca82b3c)
   
   |Task|Status|
   ||--|
   |test-conda-python-3.10-cython2|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-58dca82b3c-github-test-conda-python-3.10-cython2)](https://github.com/ursacomputing/crossbow/actions/runs/12668055777/job/35302662763)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-08 Thread via GitHub


raulcd commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2577237942

   @github-actions crossbow submit test-conda-python-3.10-cython2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-08 Thread via GitHub


pitrou commented on code in PR #45189:
URL: https://github.com/apache/arrow/pull/45189#discussion_r1906665168


##
python/pyarrow/_parquet.pxd:
##
@@ -484,11 +484,9 @@ cdef extern from "parquet/arrow/reader.h" namespace 
"parquet::arrow" nogil:
   const vector[int]& column_indices,
   shared_ptr[CTable]* out)
 
-CStatus GetRecordBatchReader(const vector[int]& row_group_indices,
- const vector[int]& column_indices,
- unique_ptr[CRecordBatchReader]* out)
-CStatus GetRecordBatchReader(const vector[int]& row_group_indices,
- unique_ptr[CRecordBatchReader]* out)
+CResult[shared_ptr[CRecordBatchReader]] GetRecordBatchReader(const 
vector[int]& row_group_indices,
+ const 
vector[int]& column_indices)
+CResult[shared_ptr[CRecordBatchReader]] GetRecordBatchReader(const 
vector[int]& row_group_indices)

Review Comment:
   `GetRecordBatchReader` on the C++ side returns a `unique_ptr`, not a 
`shared_ptr`, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-07 Thread via GitHub


github-actions[bot] commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2575586507

   Revision: babbe9fa049f5fcc1144f45150cae737aa8425bf
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-f876b9ef9d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f876b9ef9d)
   
   |Task|Status|
   ||--|
   |example-python-minimal-build-fedora-conda|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-example-python-minimal-build-fedora-conda)](https://github.com/ursacomputing/crossbow/actions/runs/12654261988/job/35261707624)|
   |example-python-minimal-build-ubuntu-venv|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-example-python-minimal-build-ubuntu-venv)](https://github.com/ursacomputing/crossbow/actions/runs/12654262038/job/35261707930)|
   |test-conda-python-3.10|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.10)](https://github.com/ursacomputing/crossbow/actions/runs/12654262169/job/35261708621)|
   |test-conda-python-3.10-cython2|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.10-cython2)](https://github.com/ursacomputing/crossbow/actions/runs/12654261733/job/35261705611)|
   |test-conda-python-3.10-hdfs-2.9.2|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.10-hdfs-2.9.2)](https://github.com/ursacomputing/crossbow/actions/runs/12654262768/job/35261710600)|
   |test-conda-python-3.10-hdfs-3.2.1|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.10-hdfs-3.2.1)](https://github.com/ursacomputing/crossbow/actions/runs/12654261525/job/35261705239)|
   |test-conda-python-3.10-pandas-latest-numpy-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.10-pandas-latest-numpy-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12654262485/job/35261709945)|
   |test-conda-python-3.10-substrait|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.10-substrait)](https://github.com/ursacomputing/crossbow/actions/runs/12654261533/job/35261704802)|
   |test-conda-python-3.11|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.11)](https://github.com/ursacomputing/crossbow/actions/runs/12654261621/job/35261705007)|
   |test-conda-python-3.11-dask-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.11-dask-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12654262270/job/35261709286)|
   |test-conda-python-3.11-dask-upstream_devel|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.11-dask-upstream_devel)](https://github.com/ursacomputing/crossbow/actions/runs/12654261804/job/35261706268)|
   |test-conda-python-3.11-hypothesis|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.11-hypothesis)](https://github.com/ursacomputing/crossbow/actions/runs/12654262195/job/35261708948)|
   |test-conda-python-3.11-pandas-latest-numpy-1.26|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.11-pandas-latest-numpy-1.26)](https://github.com/ursacomputing/crossbow/actions/runs/12654261537/job/35261704684)|
   |test-conda-python-3.11-pandas-latest-numpy-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.11-pandas-latest-numpy-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12654261691/job/35261705251)|
   |test-conda-python-3.11-pandas-nightly-numpy-nightly|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f876b9ef9d-github-test-conda-python-3.11-pandas-nightly-numpy-nightly)](https://github.com/ursacomputing/crossbow/actions/runs/12654262024/job/35261707920)|
   |test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[![GitHub 
A

Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-07 Thread via GitHub


raulcd commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2575579781

   @github-actions crossbow submit -g python


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-07 Thread via GitHub


github-actions[bot] commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2575570144

   Revision: 07f7acdb3c41b8299ebe2903c39ab6c3c562faed
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-37f20dc9c3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-37f20dc9c3)
   
   |Task|Status|
   ||--|
   |example-python-minimal-build-fedora-conda|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-example-python-minimal-build-fedora-conda)](https://github.com/ursacomputing/crossbow/actions/runs/12654144417/job/35261314549)|
   |example-python-minimal-build-ubuntu-venv|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-example-python-minimal-build-ubuntu-venv)](https://github.com/ursacomputing/crossbow/actions/runs/12654144483/job/35261315989)|
   |test-conda-python-3.10|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.10)](https://github.com/ursacomputing/crossbow/actions/runs/12654144606/job/35261317173)|
   |test-conda-python-3.10-cython2|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.10-cython2)](https://github.com/ursacomputing/crossbow/actions/runs/1265412/job/35261314597)|
   |test-conda-python-3.10-hdfs-2.9.2|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.10-hdfs-2.9.2)](https://github.com/ursacomputing/crossbow/actions/runs/12654144468/job/35261316006)|
   |test-conda-python-3.10-hdfs-3.2.1|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.10-hdfs-3.2.1)](https://github.com/ursacomputing/crossbow/actions/runs/1265411/job/35261314908)|
   |test-conda-python-3.10-pandas-latest-numpy-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.10-pandas-latest-numpy-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12654144377/job/35261314213)|
   |test-conda-python-3.10-substrait|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.10-substrait)](https://github.com/ursacomputing/crossbow/actions/runs/1265419/job/35261314570)|
   |test-conda-python-3.11|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.11)](https://github.com/ursacomputing/crossbow/actions/runs/12654144675/job/35261317175)|
   |test-conda-python-3.11-dask-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.11-dask-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12654144741/job/35261317875)|
   |test-conda-python-3.11-dask-upstream_devel|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.11-dask-upstream_devel)](https://github.com/ursacomputing/crossbow/actions/runs/12654143927/job/35261311381)|
   |test-conda-python-3.11-hypothesis|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.11-hypothesis)](https://github.com/ursacomputing/crossbow/actions/runs/12654144299/job/35261314205)|
   |test-conda-python-3.11-pandas-latest-numpy-1.26|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.11-pandas-latest-numpy-1.26)](https://github.com/ursacomputing/crossbow/actions/runs/12654144960/job/35261318180)|
   |test-conda-python-3.11-pandas-latest-numpy-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.11-pandas-latest-numpy-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12654144094/job/35261312977)|
   |test-conda-python-3.11-pandas-nightly-numpy-nightly|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-37f20dc9c3-github-test-conda-python-3.11-pandas-nightly-numpy-nightly)](https://github.com/ursacomputing/crossbow/actions/runs/12654143827/job/35261311377)|
   |test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[![GitHub 
A

Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-07 Thread via GitHub


raulcd commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2575563981

   @github-actions crossbow submit -g python


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-07 Thread via GitHub


github-actions[bot] commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2575473908

   Revision: 07f7acdb3c41b8299ebe2903c39ab6c3c562faed
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-3db166d478](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3db166d478)
   
   |Task|Status|
   ||--|
   |test-conda-python-3.10-cython2|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-3db166d478-github-test-conda-python-3.10-cython2)](https://github.com/ursacomputing/crossbow/actions/runs/12653507859/job/35259041516)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-07 Thread via GitHub


raulcd commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2575468666

   @github-actions crossbow submit test-conda-python-3.10-cython2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-07 Thread via GitHub


raulcd commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2575443307

   The cython2 failure is related:
   ```
 In file included from /build/python/pyarrow/src/arrow/python/async.h:22,
  from 
/build/python/build/temp.linux-x86_64-cpython-310/_parquet.cpp:830:
 /build/python/pyarrow/src/arrow/python/common.h: In instantiation of 
'arrow::py::SmartPtrNoGIL& arrow::py::SmartPtrNoGIL::operator=(V&&) [with V = std::unique_ptr&; 
SmartPtr = std::unique_ptr; Ts = {arrow::RecordBatchReader}]':
 /build/python/build/temp.linux-x86_64-cpython-310/_parquet.cpp:25556:56:   
required from here
 /build/python/pyarrow/src/arrow/python/common.h:263:20: error: use of 
deleted function 'std::unique_ptr<_Tp, _Dp>& std::unique_ptr<_Tp, 
_Dp>::operator=(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = 
arrow::RecordBatchReader; _Dp = std::default_delete]'
   263 | Base::operator=(std::forward(v));
   | ~~~^~~~
 In file included from 
/opt/conda/envs/arrow/lib/gcc/x86_64-conda-linux-gnu/13.3.0/include/c++/memory:78,
  from 
/build/python/build/temp.linux-x86_64-cpython-310/_parquet.cpp:770:
 
/opt/conda/envs/arrow/lib/gcc/x86_64-conda-linux-gnu/13.3.0/include/c++/bits/unique_ptr.h:523:19:
 note: declared here
   523 |   unique_ptr& operator=(const unique_ptr&) = delete;
   |   ^~~~
   ```
   the following patch would work but I don't think this should be the fix, as 
I am pretty sure `std::forward` should be used here for other operators:
   ```diff
   diff --git a/python/pyarrow/src/arrow/python/common.h 
b/python/pyarrow/src/arrow/python/common.h
   index 4a7886695e..30acf0d6ed 100644
   --- a/python/pyarrow/src/arrow/python/common.h
   +++ b/python/pyarrow/src/arrow/python/common.h
   @@ -260,7 +260,7 @@ class SmartPtrNoGIL : public SmartPtr {
  template 
  SmartPtrNoGIL& operator=(V&& v) {
auto release_guard = optional_gil_release();
   -Base::operator=(std::forward(v));
   +Base::operator=(std::move(v));
return *this;
  }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-07 Thread via GitHub


github-actions[bot] commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2575207188

   Revision: c1deb19cdb624e1f5e8363fc73c6afe28529270f
   
   Submitted crossbow builds: [ursacomputing/crossbow @ 
actions-d40040ac1a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d40040ac1a)
   
   |Task|Status|
   ||--|
   |example-python-minimal-build-fedora-conda|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-example-python-minimal-build-fedora-conda)](https://github.com/ursacomputing/crossbow/actions/runs/12651794386/job/35253089210)|
   |example-python-minimal-build-ubuntu-venv|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-example-python-minimal-build-ubuntu-venv)](https://github.com/ursacomputing/crossbow/actions/runs/12651794527/job/35253090152)|
   |test-conda-python-3.10|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.10)](https://github.com/ursacomputing/crossbow/actions/runs/12651794327/job/35253088557)|
   |test-conda-python-3.10-cython2|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.10-cython2)](https://github.com/ursacomputing/crossbow/actions/runs/12651794736/job/35253090163)|
   |test-conda-python-3.10-hdfs-2.9.2|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.10-hdfs-2.9.2)](https://github.com/ursacomputing/crossbow/actions/runs/12651794701/job/35253090160)|
   |test-conda-python-3.10-hdfs-3.2.1|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.10-hdfs-3.2.1)](https://github.com/ursacomputing/crossbow/actions/runs/12651794153/job/35253087699)|
   |test-conda-python-3.10-pandas-latest-numpy-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.10-pandas-latest-numpy-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12651794523/job/35253089475)|
   |test-conda-python-3.10-substrait|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.10-substrait)](https://github.com/ursacomputing/crossbow/actions/runs/12651795198/job/35253092458)|
   |test-conda-python-3.11|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.11)](https://github.com/ursacomputing/crossbow/actions/runs/12651794143/job/35253087361)|
   |test-conda-python-3.11-dask-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.11-dask-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12651794206/job/35253087467)|
   |test-conda-python-3.11-dask-upstream_devel|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.11-dask-upstream_devel)](https://github.com/ursacomputing/crossbow/actions/runs/12651794815/job/35253091520)|
   |test-conda-python-3.11-hypothesis|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.11-hypothesis)](https://github.com/ursacomputing/crossbow/actions/runs/12651794605/job/35253090165)|
   |test-conda-python-3.11-pandas-latest-numpy-1.26|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.11-pandas-latest-numpy-1.26)](https://github.com/ursacomputing/crossbow/actions/runs/12651794794/job/35253091106)|
   |test-conda-python-3.11-pandas-latest-numpy-latest|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.11-pandas-latest-numpy-latest)](https://github.com/ursacomputing/crossbow/actions/runs/12651794353/job/35253088508)|
   |test-conda-python-3.11-pandas-nightly-numpy-nightly|[![GitHub 
Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-d40040ac1a-github-test-conda-python-3.11-pandas-nightly-numpy-nightly)](https://github.com/ursacomputing/crossbow/actions/runs/12651794352/job/35253088512)|
   |test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[![GitHub 
A

Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-07 Thread via GitHub


raulcd commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2575196342

   @github-actions crossbow submit -g python


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow [arrow]

2025-01-07 Thread via GitHub


github-actions[bot] commented on PR #45189:
URL: https://github.com/apache/arrow/pull/45189#issuecomment-2575168523

   :warning: GitHub issue #45129 **has been automatically assigned in GitHub** 
to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org