Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
kou commented on code in PR #46101:
URL: https://github.com/apache/arrow/pull/46101#discussion_r2041292188
##
cpp/src/arrow/filesystem/meson.build:
##
@@ -0,0 +1,87 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+install_headers(
+[
+'api.h',
+'azurefs.h',
+'filesystem.h',
+'filesystem_library.h',
+'gcsfs.h',
+'hdfs.h',
+'localfs.h',
+'mockfs.h',
+'path_util.h',
+'s3fs.h',
+'s3_test_util.h',
+'test_util.h',
+'type_fwd.h',
+],
+subdir: 'arrow/filesystem',
+)
+
+pkg.generate(
+filebase: 'arrow-filesystem',
+name: 'Apache Arrow Filesystem',
+description: 'Filesystem API for accessing local and remote filesystems',
+requires: ['arrow'],
+)
+
+test_cpp_arg = '-DARROW_FILESYSTEM_EXAMPLE_LIBPATH="@0@"'.format(
+arrow_filesystem_example.full_path(),
+)
+exc = executable(
+'arrow-filesystem-test',
+sources: ['filesystem_test.cc', 'localfs_test.cc'],
+dependencies: [arrow_test_dep],
+cpp_args: test_cpp_arg,
+)
+test('arrow-filesystem-test', exc)
+
+exc = executable(
+'arrow-filesystem-localfs-benchmark',
+sources: ['localfs_benchmark.cc'],
+dependencies: [arrow_benchmark_dep],
+)
+benchmark('arrow-filesystem-localfs-benchmark', exc)
+
+exc = executable(
+'arrow-gcsfs-test',
+sources: ['gcsfs_test.cc'],
+dependencies: [arrow_test_dep, gcs_dep],
+)
+test('arrow-gcsfs-test', exc)
+
+exc = executable(
+'arrow-azurefs-test',
+sources: ['azurefs_test.cc'],
+dependencies: [arrow_test_dep, azure_dep],
+)
+test('arrow-azurefs-test', exc)
+
+
+if needs_s3
+endif
+
+if needs_hdfs
Review Comment:
Ah, sorry. You're right. I misunderstood.
I thought that we have `disabler()` dependency for `needs_hdfs` here but it
doesn't exist. We need this `if needs_hdfs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
WillAyd commented on code in PR #46101: URL: https://github.com/apache/arrow/pull/46101#discussion_r2042425912 ## cpp/cmake_modules/DefineOptions.cmake: ## @@ -346,7 +346,7 @@ takes precedence over ccache if a storage backend is configured" ON) ARROW_WITH_UTF8PROC) define_option(ARROW_GCS -"Build Arrow with GCS support (requires the GCloud SDK for C++)" +"Build Arrow with GCS support (requires the Google Cloud Platform C++ Client Libraries)" Review Comment: Whoops - should be fixed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
kou commented on code in PR #46101: URL: https://github.com/apache/arrow/pull/46101#discussion_r2041292830 ## cpp/cmake_modules/DefineOptions.cmake: ## @@ -346,7 +346,7 @@ takes precedence over ccache if a storage backend is configured" ON) ARROW_WITH_UTF8PROC) define_option(ARROW_GCS -"Build Arrow with GCS support (requires the GCloud SDK for C++)" +"Build Arrow with GCS support (requires the Google Cloud Platform C++ Client Libraries)" Review Comment: Could you fix this failure? https://github.com/apache/arrow/actions/runs/14430422114/job/40464526899?pr=46101#step:7:423 ```text CMake Error at cmake_modules/DefineOptions.cmake:27 (message): description for ARROW_GCS contained a line 86 characters long! (max is 80). Split it into more lines with semicolons Call Stack (most recent call first): cmake_modules/DefineOptions.cmake:47 (check_description_length) cmake_modules/DefineOptions.cmake:348 (define_option) CMakeLists.txt:224 (include) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
WillAyd commented on code in PR #46101:
URL: https://github.com/apache/arrow/pull/46101#discussion_r2041137598
##
cpp/src/arrow/filesystem/meson.build:
##
@@ -0,0 +1,87 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+install_headers(
+[
+'api.h',
+'azurefs.h',
+'filesystem.h',
+'filesystem_library.h',
+'gcsfs.h',
+'hdfs.h',
+'localfs.h',
+'mockfs.h',
+'path_util.h',
+'s3fs.h',
+'s3_test_util.h',
+'test_util.h',
+'type_fwd.h',
+],
+subdir: 'arrow/filesystem',
+)
+
+pkg.generate(
+filebase: 'arrow-filesystem',
+name: 'Apache Arrow Filesystem',
+description: 'Filesystem API for accessing local and remote filesystems',
+requires: ['arrow'],
+)
+
+test_cpp_arg = '-DARROW_FILESYSTEM_EXAMPLE_LIBPATH="@0@"'.format(
+arrow_filesystem_example.full_path(),
+)
+exc = executable(
+'arrow-filesystem-test',
+sources: ['filesystem_test.cc', 'localfs_test.cc'],
+dependencies: [arrow_test_dep],
+cpp_args: test_cpp_arg,
+)
+test('arrow-filesystem-test', exc)
+
+exc = executable(
+'arrow-filesystem-localfs-benchmark',
+sources: ['localfs_benchmark.cc'],
+dependencies: [arrow_benchmark_dep],
+)
+benchmark('arrow-filesystem-localfs-benchmark', exc)
+
+exc = executable(
+'arrow-gcsfs-test',
+sources: ['gcsfs_test.cc'],
+dependencies: [arrow_test_dep, gcs_dep],
+)
+test('arrow-gcsfs-test', exc)
+
+exc = executable(
+'arrow-azurefs-test',
+sources: ['azurefs_test.cc'],
+dependencies: [arrow_test_dep, azure_dep],
+)
+test('arrow-azurefs-test', exc)
+
+
+if needs_s3
+endif
+
+if needs_hdfs
Review Comment:
I think I am misunderstanding the request - I removed all the empty branches
but this one has a test in it. I think we want to keep this around right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
kou commented on code in PR #46101:
URL: https://github.com/apache/arrow/pull/46101#discussion_r2041037993
##
cpp/src/arrow/filesystem/meson.build:
##
@@ -0,0 +1,87 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+install_headers(
+[
+'api.h',
+'azurefs.h',
+'filesystem.h',
+'filesystem_library.h',
+'gcsfs.h',
+'hdfs.h',
+'localfs.h',
+'mockfs.h',
+'path_util.h',
+'s3fs.h',
+'s3_test_util.h',
+'test_util.h',
+'type_fwd.h',
+],
+subdir: 'arrow/filesystem',
+)
+
+pkg.generate(
+filebase: 'arrow-filesystem',
+name: 'Apache Arrow Filesystem',
+description: 'Filesystem API for accessing local and remote filesystems',
+requires: ['arrow'],
+)
+
+test_cpp_arg = '-DARROW_FILESYSTEM_EXAMPLE_LIBPATH="@0@"'.format(
+arrow_filesystem_example.full_path(),
+)
+exc = executable(
+'arrow-filesystem-test',
+sources: ['filesystem_test.cc', 'localfs_test.cc'],
+dependencies: [arrow_test_dep],
+cpp_args: test_cpp_arg,
+)
+test('arrow-filesystem-test', exc)
+
+exc = executable(
+'arrow-filesystem-localfs-benchmark',
+sources: ['localfs_benchmark.cc'],
+dependencies: [arrow_benchmark_dep],
+)
+benchmark('arrow-filesystem-localfs-benchmark', exc)
+
+exc = executable(
+'arrow-gcsfs-test',
+sources: ['gcsfs_test.cc'],
+dependencies: [arrow_test_dep, gcs_dep],
+)
+test('arrow-gcsfs-test', exc)
+
+exc = executable(
+'arrow-azurefs-test',
+sources: ['azurefs_test.cc'],
+dependencies: [arrow_test_dep, azure_dep],
+)
+test('arrow-azurefs-test', exc)
+
+
+if needs_s3
+endif
+
+if needs_hdfs
Review Comment:
@WillAyd I think that we can merge this once this is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
kou commented on code in PR #46101: URL: https://github.com/apache/arrow/pull/46101#discussion_r2041035955 ## cpp/meson.options: ## @@ -29,6 +36,20 @@ option( value: false, ) +option( +'filesystem', +type: 'boolean', +description: 'Build the Arrow Filesystem Layer', +value: false, +) + +option( +'gcs', +type: 'boolean', +description: 'Build Arrow with GCS support (requires the GCloud SDK for C++)', Review Comment: Yes, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
WillAyd commented on PR #46101: URL: https://github.com/apache/arrow/pull/46101#issuecomment-2796818453 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
github-actions[bot] commented on PR #46101: URL: https://github.com/apache/arrow/pull/46101#issuecomment-2796823476 Revision: 33552287561c7cc966171f9441ef13a4af8c4e45 Submitted crossbow builds: [ursacomputing/crossbow @ actions-f11410af11](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f11410af11) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14403480399/job/40394273256)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
WillAyd commented on code in PR #46101:
URL: https://github.com/apache/arrow/pull/46101#discussion_r2039500252
##
cpp/src/arrow/meson.build:
##
@@ -264,6 +264,79 @@ else
rapidjson_dep = disabler()
endif
+azure_dep = disabler()
+gcs_dep = disabler()
+s3_dep = disabler()
+if needs_filesystem
+arrow_filesystem_srcs = [
+'filesystem/filesystem.cc',
+'filesystem/localfs.cc',
+'filesystem/mockfs.cc',
+'filesystem/path_util.cc',
+'filesystem/util_internal.cc',
+]
+
+arrow_filesystem_deps = []
+
+if needs_azure
+arrow_filesystem_srcs += ['filesystem/azurefs.cc']
+cmake = import('cmake')
+azure_opt = cmake.subproject_options()
+azure_opt.add_cmake_defines(
+{'BUILD_PERFORMANCE_TESTS': 'FALSE'},
+{'BUILD_SAMPLES': 'FALSE'},
+{'BUILD_TESTING': 'FALSE'},
+{'BUILD_WINDOWS_UWP': 'TRUE'},
+{'CMAKE_UNITY_BUILD': 'FALSE'},
+{'DISABLE_AZURE_CORE_OPENTELEMETRY': 'TRUE'},
+# TODO: couldn't find any usage of this in Arrow - do we need?
+# set(ENV{AZURE_SDK_DISABLE_AUTO_VCPKG} TRUE)
+{'WARNINGS_AS_ERRORS': 'FALSE'},
+)
+azure_opt.append_compile_args('cpp', '-fPIC')
+azure_proj = cmake.subproject('azure', options: azure_opt)
+
+azure_dep = declare_dependency(
+dependencies: [
+azure_proj.dependency('azure-core'),
+azure_proj.dependency('azure-identity'),
+azure_proj.dependency('azure-storage-blobs'),
+azure_proj.dependency('azure-storage-common'),
+azure_proj.dependency('azure-storage-files-datalake'),
+],
+)
+arrow_filesystem_deps += [azure_dep]
+endif
+
+if needs_gcs
+error('gcs filesystem support is not yet implemented in Meson')
+arrow_filesystem_srcs += [
+'filesystem/gcsfs.cc',
+'filesystem/gcsfs_internal.cc',
+]
+gcs_dep = dependency('google-cloud-cpp')
+arrow_filesystem_deps += [gcs_dep]
Review Comment:
No problem at all (for gcs and s3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
WillAyd commented on code in PR #46101:
URL: https://github.com/apache/arrow/pull/46101#discussion_r2039497395
##
cpp/src/arrow/meson.build:
##
@@ -264,6 +264,79 @@ else
rapidjson_dep = disabler()
endif
+azure_dep = disabler()
+gcs_dep = disabler()
+s3_dep = disabler()
+if needs_filesystem
+arrow_filesystem_srcs = [
+'filesystem/filesystem.cc',
+'filesystem/localfs.cc',
+'filesystem/mockfs.cc',
+'filesystem/path_util.cc',
+'filesystem/util_internal.cc',
+]
+
+arrow_filesystem_deps = []
+
+if needs_azure
+arrow_filesystem_srcs += ['filesystem/azurefs.cc']
+cmake = import('cmake')
+azure_opt = cmake.subproject_options()
+azure_opt.add_cmake_defines(
+{'BUILD_PERFORMANCE_TESTS': 'FALSE'},
+{'BUILD_SAMPLES': 'FALSE'},
+{'BUILD_TESTING': 'FALSE'},
+{'BUILD_WINDOWS_UWP': 'TRUE'},
+{'CMAKE_UNITY_BUILD': 'FALSE'},
+{'DISABLE_AZURE_CORE_OPENTELEMETRY': 'TRUE'},
+# TODO: couldn't find any usage of this in Arrow - do we need?
+# set(ENV{AZURE_SDK_DISABLE_AUTO_VCPKG} TRUE)
Review Comment:
Ah nevermind - ignore comment above. I was thinking this ENABLED something
but I see it DISABLEs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
WillAyd commented on code in PR #46101:
URL: https://github.com/apache/arrow/pull/46101#discussion_r2039496409
##
cpp/src/arrow/meson.build:
##
@@ -264,6 +264,79 @@ else
rapidjson_dep = disabler()
endif
+azure_dep = disabler()
+gcs_dep = disabler()
+s3_dep = disabler()
+if needs_filesystem
+arrow_filesystem_srcs = [
+'filesystem/filesystem.cc',
+'filesystem/localfs.cc',
+'filesystem/mockfs.cc',
+'filesystem/path_util.cc',
+'filesystem/util_internal.cc',
+]
+
+arrow_filesystem_deps = []
+
+if needs_azure
+arrow_filesystem_srcs += ['filesystem/azurefs.cc']
+cmake = import('cmake')
+azure_opt = cmake.subproject_options()
+azure_opt.add_cmake_defines(
+{'BUILD_PERFORMANCE_TESTS': 'FALSE'},
+{'BUILD_SAMPLES': 'FALSE'},
+{'BUILD_TESTING': 'FALSE'},
+{'BUILD_WINDOWS_UWP': 'TRUE'},
+{'CMAKE_UNITY_BUILD': 'FALSE'},
+{'DISABLE_AZURE_CORE_OPENTELEMETRY': 'TRUE'},
+# TODO: couldn't find any usage of this in Arrow - do we need?
+# set(ENV{AZURE_SDK_DISABLE_AUTO_VCPKG} TRUE)
Review Comment:
Ok great - I will set to FALSE then. Should I update the CMake configuration
as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
WillAyd commented on code in PR #46101: URL: https://github.com/apache/arrow/pull/46101#discussion_r2039493806 ## cpp/meson.options: ## @@ -29,6 +36,20 @@ option( value: false, ) +option( +'filesystem', +type: 'boolean', +description: 'Build the Arrow Filesystem Layer', +value: false, +) + +option( +'gcs', +type: 'boolean', +description: 'Build Arrow with GCS support (requires the GCloud SDK for C++)', Review Comment: No problem - do you want me to update `DefineOptions.cmake` with the new description as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
kou commented on code in PR #46101:
URL: https://github.com/apache/arrow/pull/46101#discussion_r2038390930
##
cpp/meson.options:
##
@@ -29,6 +36,20 @@ option(
value: false,
)
+option(
+'filesystem',
+type: 'boolean',
+description: 'Build the Arrow Filesystem Layer',
+value: false,
+)
+
+option(
+'gcs',
+type: 'boolean',
+description: 'Build Arrow with GCS support (requires the GCloud SDK for
C++)',
Review Comment:
Based on its README:
https://github.com/googleapis/google-cloud-cpp?tab=readme-ov-file#google-cloud-platform-c-client-libraries
```suggestion
description: 'Build Arrow with GCS support (requires the Google Cloud
Platform C++ Client Libraries)',
```
##
cpp/src/arrow/filesystem/meson.build:
##
@@ -0,0 +1,87 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+install_headers(
+[
+'api.h',
+'azurefs.h',
+'filesystem.h',
+'filesystem_library.h',
+'gcsfs.h',
+'hdfs.h',
+'localfs.h',
+'mockfs.h',
+'path_util.h',
+'s3fs.h',
+'s3_test_util.h',
+'test_util.h',
+'type_fwd.h',
+],
+subdir: 'arrow/filesystem',
+)
+
+pkg.generate(
+filebase: 'arrow-filesystem',
+name: 'Apache Arrow Filesystem',
+description: 'Filesystem API for accessing local and remote filesystems',
+requires: ['arrow'],
+)
+
+test_cpp_arg = '-DARROW_FILESYSTEM_EXAMPLE_LIBPATH="@0@"'.format(
+arrow_filesystem_example.full_path(),
+)
+exc = executable(
+'arrow-filesystem-test',
+sources: ['filesystem_test.cc', 'localfs_test.cc'],
+dependencies: [arrow_test_dep],
+cpp_args: test_cpp_arg,
+)
+test('arrow-filesystem-test', exc)
+
+exc = executable(
+'arrow-filesystem-localfs-benchmark',
+sources: ['localfs_benchmark.cc'],
+dependencies: [arrow_benchmark_dep],
+)
+benchmark('arrow-filesystem-localfs-benchmark', exc)
+
+exc = executable(
+'arrow-gcsfs-test',
+sources: ['gcsfs_test.cc'],
+dependencies: [arrow_test_dep, gcs_dep],
+)
+test('arrow-gcsfs-test', exc)
+
+exc = executable(
+'arrow-azurefs-test',
+sources: ['azurefs_test.cc'],
+dependencies: [arrow_test_dep, azure_dep],
+)
+test('arrow-azurefs-test', exc)
+
+
+if needs_s3
+endif
+
Review Comment:
```suggestion
```
##
cpp/src/arrow/meson.build:
##
@@ -264,6 +264,79 @@ else
rapidjson_dep = disabler()
endif
+azure_dep = disabler()
+gcs_dep = disabler()
+s3_dep = disabler()
+if needs_filesystem
+arrow_filesystem_srcs = [
+'filesystem/filesystem.cc',
+'filesystem/localfs.cc',
+'filesystem/mockfs.cc',
+'filesystem/path_util.cc',
+'filesystem/util_internal.cc',
+]
+
+arrow_filesystem_deps = []
+
+if needs_azure
+arrow_filesystem_srcs += ['filesystem/azurefs.cc']
+cmake = import('cmake')
+azure_opt = cmake.subproject_options()
+azure_opt.add_cmake_defines(
+{'BUILD_PERFORMANCE_TESTS': 'FALSE'},
+{'BUILD_SAMPLES': 'FALSE'},
+{'BUILD_TESTING': 'FALSE'},
+{'BUILD_WINDOWS_UWP': 'TRUE'},
+{'CMAKE_UNITY_BUILD': 'FALSE'},
+{'DISABLE_AZURE_CORE_OPENTELEMETRY': 'TRUE'},
+# TODO: couldn't find any usage of this in Arrow - do we need?
+# set(ENV{AZURE_SDK_DISABLE_AUTO_VCPKG} TRUE)
+{'WARNINGS_AS_ERRORS': 'FALSE'},
+)
+azure_opt.append_compile_args('cpp', '-fPIC')
+azure_proj = cmake.subproject('azure', options: azure_opt)
+
+azure_dep = declare_dependency(
+dependencies: [
+azure_proj.dependency('azure-core'),
+azure_proj.dependency('azure-identity'),
+azure_proj.dependency('azure-storage-blobs'),
+azure_proj.dependency('azure-storage-common'),
+azure_proj.dependency('azure-storage-files-datalake'),
+],
+)
+arrow_filesystem_deps += [azure_dep]
+endif
+
+if needs_gcs
+error('gcs filesystem support is not yet implemented in Meson')
+arrow_filesystem_srcs += [
+'filesystem/gcsfs.
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
github-actions[bot] commented on PR #46101: URL: https://github.com/apache/arrow/pull/46101#issuecomment-2795184630 Revision: a2bdd12cfadb5fb4c0ff33410b437cfc3e9637b4 Submitted crossbow builds: [ursacomputing/crossbow @ actions-df2349b5fe](https://github.com/ursacomputing/crossbow/branches/all?query=actions-df2349b5fe) |Task|Status| ||--| |test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14390442522/job/40356050792)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]
WillAyd commented on PR #46101: URL: https://github.com/apache/arrow/pull/46101#issuecomment-2795180568 @github-actions crossbow submit *meson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
