Re: [PR] GH-46092: [C++] Add filesystem related options to Meson [arrow]
WillAyd commented on code in PR #46101: URL: https://github.com/apache/arrow/pull/46101#discussion_r2056176577 ## cpp/subprojects/azure.wrap: ## @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[wrap-file] Review Comment: Sure no problem - I'll add a README to the directory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46092: [C++] Add filesystem related options to Meson [arrow]
pitrou commented on code in PR #46101: URL: https://github.com/apache/arrow/pull/46101#discussion_r2056150156 ## cpp/subprojects/azure.wrap: ## @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[wrap-file] Review Comment: Since there is nothing in the filename that says so, can we please add comments to those files mentioning that they are used by Meson? Or perhaps add a README in this directory. ## cpp/subprojects/azure.wrap: ## @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[wrap-file] Review Comment: Since there is nothing in the filename that says so, can we please add comments to those files mentioning that they are used by Meson? Or perhaps add a README in this directory. @WillAyd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46092: [C++] Add filesystem related options to Meson [arrow]
conbench-apache-arrow[bot] commented on PR #46101: URL: https://github.com/apache/arrow/pull/46101#issuecomment-2803816784 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6b64396dfedfb42e00a484f7ade21c099914e0db. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/40555435115) has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46092: [C++] Add filesystem related options to Meson [arrow]
kou merged PR #46101: URL: https://github.com/apache/arrow/pull/46101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46092: [C++] Add filesystem related options to Meson [arrow]
github-actions[bot] commented on PR #46101: URL: https://github.com/apache/arrow/pull/46101#issuecomment-2803098378 :warning: GitHub issue #46092 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
