Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on code in PR #46742:
URL: https://github.com/apache/arrow/pull/46742#discussion_r2163716263
##
cpp/src/arrow/filesystem/s3fs.cc:
##
@@ -78,42 +83,18 @@
#include
#include
-// AWS_SDK_VERSION_{MAJOR,MINOR,PATCH} are available since 1.9.7.
-#if defined(AWS_SDK_VERSION_MAJOR) && defined(AWS_SDK_VERSION_MINOR) && \
-defined(AWS_SDK_VERSION_PATCH)
// Redundant "(...)" are for suppressing "Weird number of spaces at
// line-start. Are you using a 2-space indent? [whitespace/indent]
// [3]" errors...
-# define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch)
\
-((AWS_SDK_VERSION_MAJOR > (major) ||
\
- (AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR > (minor)) ||
\
- ((AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR == (minor)
&& \
-AWS_SDK_VERSION_PATCH >= (patch)
-#else
-# define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch) 0
-#endif
-
-// This feature is available since 1.9.0 but
-// AWS_SDK_VERSION_{MAJOR,MINOR,PATCH} are available since 1.9.7. So
-// we can't use this feature for [1.9.0,1.9.6]. If it's a problem,
-// please report it to our issue tracker.
-#if ARROW_AWS_SDK_VERSION_CHECK(1, 9, 0)
-# define ARROW_S3_HAS_CRT
-#endif
-
-#if ARROW_AWS_SDK_VERSION_CHECK(1, 10, 0)
-# define ARROW_S3_HAS_S3CLIENT_CONFIGURATION
-#endif
-
-#ifdef ARROW_S3_HAS_CRT
-# include
-# include
-# include
-#endif
-
-#ifdef ARROW_S3_HAS_S3CLIENT_CONFIGURATION
-# include
-# include
+#define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch) \
+ ((AWS_SDK_VERSION_MAJOR > (major) ||\
+(AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR > (minor)) || \
+((AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR == (minor) && \
+ AWS_SDK_VERSION_PATCH >= (patch)
+
+// Keep this in sync with ThirdPartyToolChain.cmake
+#if !defined(AWS_SDK_VERSION_MAJOR) || !ARROW_AWS_SDK_VERSION_CHECK(1, 11, 0)
+# error "AWS SDK version 1.11.0 or later is required"
#endif
Review Comment:
I thought this might be useful for Meson.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
github-actions[bot] commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2999156802 Revision: bcbeaf9ff9d57f0510041151e005450159a9f14e Submitted crossbow builds: [ursacomputing/crossbow @ actions-c8b603b831](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c8b603b831) |Task|Status| ||--| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844177816/job/44662438381)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844177894/job/44662438795)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844177813/job/44662438532)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844177699/job/44662438128)| |wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844177604/job/44662437868)| |wheel-manylinux-2-28-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844178187/job/44662439362)| |wheel-manylinux-2-28-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844178014/job/44662438993)| |wheel-manylinux-2-28-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844178088/job/44662439176)| |wheel-manylinux-2014-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844178247/job/44662439668)| |wheel-manylinux-2014-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844177820/job/44662438396)| |wheel-manylinux-2014-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844178158/job/44662439299)| |wheel-manylinux-2014-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844177492/job/44662437570)| |wheel-musllinux-1-2-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844177907/job/44662438640)| |wheel-musllinux-1-2-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844177501/job/44662437589)| |wheel-musllinux-1-2-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15844178369/job/44662439875)|
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou merged PR #46742: URL: https://github.com/apache/arrow/pull/46742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
github-actions[bot] commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2999158469 Revision: bcbeaf9ff9d57f0510041151e005450159a9f14e Submitted crossbow builds: [ursacomputing/crossbow @ actions-0e0f175ff0](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0e0f175ff0) |Task|Status| ||--| |example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/15844174515/job/44662429866)| |example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/15844174628/job/44662430006)| |example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/15844174307/job/44662429178)| |example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/15844174899/job/44662430927)| |example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/15844175416/job/44662432356)| |test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/15844175486/job/44662432570)| |test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/15844174268/job/44662429050)| |test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/15844175186/job/44662431729)| |test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/15844175086/job/44662431568)| |test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/15844174092/job/44662428591)| |test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/15844175159/job/44662431670)| |test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/15844174606/job/44662430068)| |test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/15844175385/job/44662432287)| |test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/15844174239/job/44662428988)| |test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/15844174428/job/44662429571)| |test-conda-python-3.11-hypothesis|[![GitHub
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
kou commented on code in PR #46742:
URL: https://github.com/apache/arrow/pull/46742#discussion_r2163714672
##
cpp/src/arrow/filesystem/s3fs.cc:
##
@@ -78,42 +83,18 @@
#include
#include
-// AWS_SDK_VERSION_{MAJOR,MINOR,PATCH} are available since 1.9.7.
-#if defined(AWS_SDK_VERSION_MAJOR) && defined(AWS_SDK_VERSION_MINOR) && \
-defined(AWS_SDK_VERSION_PATCH)
// Redundant "(...)" are for suppressing "Weird number of spaces at
// line-start. Are you using a 2-space indent? [whitespace/indent]
// [3]" errors...
-# define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch)
\
-((AWS_SDK_VERSION_MAJOR > (major) ||
\
- (AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR > (minor)) ||
\
- ((AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR == (minor)
&& \
-AWS_SDK_VERSION_PATCH >= (patch)
-#else
-# define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch) 0
-#endif
-
-// This feature is available since 1.9.0 but
-// AWS_SDK_VERSION_{MAJOR,MINOR,PATCH} are available since 1.9.7. So
-// we can't use this feature for [1.9.0,1.9.6]. If it's a problem,
-// please report it to our issue tracker.
-#if ARROW_AWS_SDK_VERSION_CHECK(1, 9, 0)
-# define ARROW_S3_HAS_CRT
-#endif
-
-#if ARROW_AWS_SDK_VERSION_CHECK(1, 10, 0)
-# define ARROW_S3_HAS_S3CLIENT_CONFIGURATION
-#endif
-
-#ifdef ARROW_S3_HAS_CRT
-# include
-# include
-# include
-#endif
-
-#ifdef ARROW_S3_HAS_S3CLIENT_CONFIGURATION
-# include
-# include
+#define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch) \
+ ((AWS_SDK_VERSION_MAJOR > (major) ||\
+(AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR > (minor)) || \
+((AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR == (minor) && \
+ AWS_SDK_VERSION_PATCH >= (patch)
+
+// Keep this in sync with ThirdPartyToolChain.cmake
+#if !defined(AWS_SDK_VERSION_MAJOR) || !ARROW_AWS_SDK_VERSION_CHECK(1, 11, 0)
+# error "AWS SDK version 1.11.0 or later is required"
#endif
Review Comment:
We can remove this because we have the same check in CMake. CMake rejects
older AWS SDK for C++. So we don't need to check this here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
WillAyd commented on code in PR #46742:
URL: https://github.com/apache/arrow/pull/46742#discussion_r2164253998
##
cpp/src/arrow/filesystem/s3fs.cc:
##
@@ -78,42 +83,18 @@
#include
#include
-// AWS_SDK_VERSION_{MAJOR,MINOR,PATCH} are available since 1.9.7.
-#if defined(AWS_SDK_VERSION_MAJOR) && defined(AWS_SDK_VERSION_MINOR) && \
-defined(AWS_SDK_VERSION_PATCH)
// Redundant "(...)" are for suppressing "Weird number of spaces at
// line-start. Are you using a 2-space indent? [whitespace/indent]
// [3]" errors...
-# define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch)
\
-((AWS_SDK_VERSION_MAJOR > (major) ||
\
- (AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR > (minor)) ||
\
- ((AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR == (minor)
&& \
-AWS_SDK_VERSION_PATCH >= (patch)
-#else
-# define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch) 0
-#endif
-
-// This feature is available since 1.9.0 but
-// AWS_SDK_VERSION_{MAJOR,MINOR,PATCH} are available since 1.9.7. So
-// we can't use this feature for [1.9.0,1.9.6]. If it's a problem,
-// please report it to our issue tracker.
-#if ARROW_AWS_SDK_VERSION_CHECK(1, 9, 0)
-# define ARROW_S3_HAS_CRT
-#endif
-
-#if ARROW_AWS_SDK_VERSION_CHECK(1, 10, 0)
-# define ARROW_S3_HAS_S3CLIENT_CONFIGURATION
-#endif
-
-#ifdef ARROW_S3_HAS_CRT
-# include
-# include
-# include
-#endif
-
-#ifdef ARROW_S3_HAS_S3CLIENT_CONFIGURATION
-# include
-# include
+#define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch) \
+ ((AWS_SDK_VERSION_MAJOR > (major) ||\
+(AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR > (minor)) || \
+((AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR == (minor) && \
+ AWS_SDK_VERSION_PATCH >= (patch)
+
+// Keep this in sync with ThirdPartyToolChain.cmake
+#if !defined(AWS_SDK_VERSION_MAJOR) || !ARROW_AWS_SDK_VERSION_CHECK(1, 11, 0)
+# error "AWS SDK version 1.11.0 or later is required"
#endif
Review Comment:
No problem - that and GCS support are likely some of the last things to be
done for full Meson coverage, so we have some time :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
conbench-apache-arrow[bot] commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-3000816844 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 85b4e6d0af00f795a4530896d5c3779f2e95ccea. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/44693815141) has more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
kou commented on code in PR #46742:
URL: https://github.com/apache/arrow/pull/46742#discussion_r2163733600
##
cpp/src/arrow/filesystem/s3fs.cc:
##
@@ -78,42 +83,18 @@
#include
#include
-// AWS_SDK_VERSION_{MAJOR,MINOR,PATCH} are available since 1.9.7.
-#if defined(AWS_SDK_VERSION_MAJOR) && defined(AWS_SDK_VERSION_MINOR) && \
-defined(AWS_SDK_VERSION_PATCH)
// Redundant "(...)" are for suppressing "Weird number of spaces at
// line-start. Are you using a 2-space indent? [whitespace/indent]
// [3]" errors...
-# define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch)
\
-((AWS_SDK_VERSION_MAJOR > (major) ||
\
- (AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR > (minor)) ||
\
- ((AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR == (minor)
&& \
-AWS_SDK_VERSION_PATCH >= (patch)
-#else
-# define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch) 0
-#endif
-
-// This feature is available since 1.9.0 but
-// AWS_SDK_VERSION_{MAJOR,MINOR,PATCH} are available since 1.9.7. So
-// we can't use this feature for [1.9.0,1.9.6]. If it's a problem,
-// please report it to our issue tracker.
-#if ARROW_AWS_SDK_VERSION_CHECK(1, 9, 0)
-# define ARROW_S3_HAS_CRT
-#endif
-
-#if ARROW_AWS_SDK_VERSION_CHECK(1, 10, 0)
-# define ARROW_S3_HAS_S3CLIENT_CONFIGURATION
-#endif
-
-#ifdef ARROW_S3_HAS_CRT
-# include
-# include
-# include
-#endif
-
-#ifdef ARROW_S3_HAS_S3CLIENT_CONFIGURATION
-# include
-# include
+#define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch) \
+ ((AWS_SDK_VERSION_MAJOR > (major) ||\
+(AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR > (minor)) || \
+((AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR == (minor) && \
+ AWS_SDK_VERSION_PATCH >= (patch)
+
+// Keep this in sync with ThirdPartyToolChain.cmake
+#if !defined(AWS_SDK_VERSION_MAJOR) || !ARROW_AWS_SDK_VERSION_CHECK(1, 11, 0)
+# error "AWS SDK version 1.11.0 or later is required"
#endif
Review Comment:
Ah. @WillAyd Could you remove this when you add AWS SDK for C++ support to
our Meson configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2999149414 @github-actions crossbow submit *wheel*cp313* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2999148979 @github-actions crossbow submit -g cpp -g python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
kou commented on code in PR #46742:
URL: https://github.com/apache/arrow/pull/46742#discussion_r2155865244
##
cpp/src/arrow/filesystem/s3fs.cc:
##
@@ -78,42 +83,17 @@
#include
#include
-// AWS_SDK_VERSION_{MAJOR,MINOR,PATCH} are available since 1.9.7.
-#if defined(AWS_SDK_VERSION_MAJOR) && defined(AWS_SDK_VERSION_MINOR) && \
-defined(AWS_SDK_VERSION_PATCH)
// Redundant "(...)" are for suppressing "Weird number of spaces at
// line-start. Are you using a 2-space indent? [whitespace/indent]
// [3]" errors...
-# define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch)
\
-((AWS_SDK_VERSION_MAJOR > (major) ||
\
- (AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR > (minor)) ||
\
- ((AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR == (minor)
&& \
-AWS_SDK_VERSION_PATCH >= (patch)
-#else
-# define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch) 0
-#endif
-
-// This feature is available since 1.9.0 but
-// AWS_SDK_VERSION_{MAJOR,MINOR,PATCH} are available since 1.9.7. So
-// we can't use this feature for [1.9.0,1.9.6]. If it's a problem,
-// please report it to our issue tracker.
-#if ARROW_AWS_SDK_VERSION_CHECK(1, 9, 0)
-# define ARROW_S3_HAS_CRT
-#endif
-
-#if ARROW_AWS_SDK_VERSION_CHECK(1, 10, 0)
-# define ARROW_S3_HAS_S3CLIENT_CONFIGURATION
-#endif
-
-#ifdef ARROW_S3_HAS_CRT
-# include
-# include
-# include
-#endif
-
-#ifdef ARROW_S3_HAS_S3CLIENT_CONFIGURATION
-# include
-# include
+#define ARROW_AWS_SDK_VERSION_CHECK(major, minor, patch) \
+ ((AWS_SDK_VERSION_MAJOR > (major) ||\
+(AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR > (minor)) || \
+((AWS_SDK_VERSION_MAJOR == (major) && AWS_SDK_VERSION_MINOR == (minor) && \
+ AWS_SDK_VERSION_PATCH >= (patch)
+
+#if !defined(AWS_SDK_VERSION_MAJOR) || !ARROW_AWS_SDK_VERSION_CHECK(1, 11, 0)
+# error "The AWS SDK is too old, version 1.11.0 or later is required"
#endif
Review Comment:
Could you check this in CMake?
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 5264beed78..753e4e80f3 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -5277,7 +5277,7 @@ function(build_awssdk)
endfunction()
if(ARROW_S3)
- resolve_dependency(AWSSDK HAVE_ALT TRUE)
+ resolve_dependency(AWSSDK HAVE_ALT TRUE REQUIRED_VERSION 1.11.0)
message(STATUS "Found AWS SDK headers: ${AWSSDK_INCLUDE_DIR}")
message(STATUS "Found AWS SDK libraries: ${AWSSDK_LINK_LIBRARIES}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
github-actions[bot] commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2984269842 Revision: 33cfd2d29365e3c4aeb9e119ac102aa87f838e3a Submitted crossbow builds: [ursacomputing/crossbow @ actions-2943bea279](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2943bea279) |Task|Status| ||--| |r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/15734447346/job/44343294114)| |r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/15734446924/job/44343292657)| |test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/15734446833/job/44343292335)| |test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/44343302417)| |test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/15734447107/job/44343293230)| |test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/15734447243/job/44343293676)| |test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/15734447551/job/44343294528)| |test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/15734446753/job/44343292087)| |test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/15734447184/job/44343293515)| |test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/15734447483/job/44343294445)| |test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/15734446744/job/44343292173)| |test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/15734447683/job/44343295079)| |test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/15734446937/job/44343292728)| |test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/15734447065/job/44343293136)| |test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/15734446747/job/44343292256)| |test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/15734446854/job/44343292355)| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/15734446840/job/44343292338)| |test-r-macos-as-cran|[![GitHub
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2984259289 @github-actions crossbow submit -g r -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
github-actions[bot] commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2983079457 ``` No such command '*wheel*cp313*'. The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/15727028902 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
github-actions[bot] commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2983101982 Revision: 33cfd2d29365e3c4aeb9e119ac102aa87f838e3a Submitted crossbow builds: [ursacomputing/crossbow @ actions-5d2b9004d1](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5d2b9004d1) |Task|Status| ||--| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095720/job/44319268067)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095520/job/44319267299)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095687/job/44319268032)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095291/job/44319266437)| |wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095366/job/44319266671)| |wheel-manylinux-2-28-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095549/job/44319267391)| |wheel-manylinux-2-28-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095341/job/44319266541)| |wheel-manylinux-2-28-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095352/job/44319266591)| |wheel-manylinux-2014-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095413/job/44319266842)| |wheel-manylinux-2014-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095668/job/44319267820)| |wheel-manylinux-2014-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095278/job/44319266385)| |wheel-manylinux-2014-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095826/job/44319268421)| |wheel-musllinux-1-2-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095802/job/44319268361)| |wheel-musllinux-1-2-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095287/job/44319266448)| |wheel-musllinux-1-2-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15727095556/job/44319267382)|
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
github-actions[bot] commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2983101146 Revision: 33cfd2d29365e3c4aeb9e119ac102aa87f838e3a Submitted crossbow builds: [ursacomputing/crossbow @ actions-dbfdbdd772](https://github.com/ursacomputing/crossbow/branches/all?query=actions-dbfdbdd772) |Task|Status| ||--| |r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/15727084693/job/44319233263)| |r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/15727083976/job/44319231081)| |test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/15727084002/job/44319231153)| |test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/44319235750)| |test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/15727083584/job/44319229742)| |test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/15727083337/job/44319229177)| |test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/15727084365/job/44319232074)| |test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/15727084541/job/44319232545)| |test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/15727083885/job/44319230849)| |test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/15727084537/job/44319232625)| |test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/15727083669/job/44319230278)| |test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/15727083527/job/44319229646)| |test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/15727083754/job/44319230468)| |test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/15727083557/job/44319229753)| |test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/15727083866/job/44319230749)| |test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/15727084211/job/44319231641)| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/15727083339/job/44319229131)| |test-r-macos-as-cran|[![GitHub
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
github-actions[bot] commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2983095539 Revision: 33cfd2d29365e3c4aeb9e119ac102aa87f838e3a Submitted crossbow builds: [ursacomputing/crossbow @ actions-ec21fe9db9](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ec21fe9db9) |Task|Status| ||--| |example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/15727049247/job/44319125658)| |example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/15727049679/job/44319127090)| |example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/15727049795/job/44319127420)| |example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/15727049340/job/44319126008)| |example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/15727050459/job/44319129641)| |test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/15727049278/job/44319125738)| |test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/15727050409/job/44319129465)| |test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/15727050246/job/44319128909)| |test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/15727050223/job/44319128804)| |test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/15727050699/job/44319130171)| |test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/15727049580/job/44319126754)| |test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/15727049402/job/44319126211)| |test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/15727049966/job/44319127902)| |test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/15727049684/job/44319127099)| |test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/15727050018/job/44319128167)| |test-conda-python-3.11-hypothesis|[![GitHub
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2983091484 @github-actions crossbow submit *wheel*cp313* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou closed pull request #46742: GH-46746: [C++] Assume AWS SDK >= 1.11.0 URL: https://github.com/apache/arrow/pull/46742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2983076965 @github-actions crossbow submit -g cpp -g python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2983077665 @github-actions crossbow submit -g r -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2983077447 @github-actions crossbow *wheel*cp313* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2955283493 I'm switching to draft until https://github.com/apache/arrow/pull/45306 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2955259526 @github-actions crossbow submit *wheel*cp313* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2955269824 Oh, I had missed that our bundled version is still 1.10.55 (!). It was released in January 2023... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
github-actions[bot] commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2955267262 Revision: 9448f1402fee4dc9e74bcd02597a4a30b15e4fe3 Submitted crossbow builds: [ursacomputing/crossbow @ actions-3f936fb3ce](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3f936fb3ce) |Task|Status| ||--| |r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/15531639116/job/43721694979)| |r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/15531639100/job/43721696073)| |test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/15531638343/job/43721689939)| |test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/43721694852)| |test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/15531638912/job/43721693978)| |test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/15531638493/job/43721690579)| |test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/15531639445/job/43721696640)| |test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/15531639594/job/43721696093)| |test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/15531639108/job/43721694769)| |test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/15531638462/job/43721690569)| |test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/15531638727/job/43721692665)| |test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/15531638836/job/43721693776)| |test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/15531638662/job/43721695215)| |test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/15531638753/job/43721691971)| |test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/15531639069/job/43721696361)| |test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/15531639150/job/43721695161)| |test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/15531638812/job/43721692821)| |test-r-macos-as-cran|[![GitHub
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2955189639 CI failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
github-actions[bot] commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2955266945 Revision: 9448f1402fee4dc9e74bcd02597a4a30b15e4fe3 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1ff451d45b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1ff451d45b) |Task|Status| ||--| |example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/15531631852/job/43721671087)| |example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/15531632817/job/43721677098)| |example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/15531632286/job/43721672801)| |example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/15531632065/job/43721671887)| |example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/15531632282/job/43721673038)| |test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/15531631611/job/43721669880)| |test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/15531631160/job/43721668066)| |test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/15531632214/job/43721672523)| |test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/15531631379/job/43721668787)| |test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/15531631724/job/43721670677)| |test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/15531632246/job/43721672730)| |test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/15531632403/job/43721674508)| |test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/15531631573/job/43721669462)| |test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/15531631205/job/43721668106)| |test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/15531632306/job/43721673891)| |test-conda-python-3.11-hypothesis|[![GitHub
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
github-actions[bot] commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2955266422 Revision: 9448f1402fee4dc9e74bcd02597a4a30b15e4fe3 Submitted crossbow builds: [ursacomputing/crossbow @ actions-fe91e15b58](https://github.com/ursacomputing/crossbow/branches/all?query=actions-fe91e15b58) |Task|Status| ||--| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636152/job/43721683916)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636213/job/43721684233)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636186/job/43721684211)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636235/job/43721684484)| |wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636145/job/43721683940)| |wheel-manylinux-2-28-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636357/job/43721684973)| |wheel-manylinux-2-28-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636613/job/43721686041)| |wheel-manylinux-2-28-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636646/job/43721686027)| |wheel-manylinux-2014-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636417/job/43721685315)| |wheel-manylinux-2014-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636346/job/43721684985)| |wheel-manylinux-2014-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636520/job/43721685550)| |wheel-manylinux-2014-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636463/job/43721685483)| |wheel-musllinux-1-2-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531635840/job/43721682711)| |wheel-musllinux-1-2-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636183/job/43721684242)| |wheel-musllinux-1-2-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15531636208/job/43721684219)|
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2955260027 @github-actions crossbow submit -g r -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46746: [C++] Assume AWS SDK >= 1.11.0 [arrow]
pitrou commented on PR #46742: URL: https://github.com/apache/arrow/pull/46742#issuecomment-2955258925 @github-actions crossbow submit -g cpp -g python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
