Re: [PR] GH-46897: [Docs][C++][Python] Fix asof join documentation [arrow]
conbench-apache-arrow[bot] commented on PR #46898: URL: https://github.com/apache/arrow/pull/46898#issuecomment-3048068055 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e411851738c2528a5ce24857805e0eac57e2c659. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/45542609745) has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46897: [Docs][C++][Python] Fix asof join documentation [arrow]
zanmato1984 merged PR #46898: URL: https://github.com/apache/arrow/pull/46898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46897: [Docs][C++][Python] Fix asof join documentation [arrow]
zanmato1984 commented on PR #46898: URL: https://github.com/apache/arrow/pull/46898#issuecomment-3047147361 CI failures are unrelated (seems like #47015). I'll merge later. Thanks @hadrian-reppas a lot for fixing this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46897: [Docs][C++][Python] Fix asof join documentation [arrow]
hadrian-reppas commented on PR #46898: URL: https://github.com/apache/arrow/pull/46898#issuecomment-3046677848 Yeah I like that a bit better. I also updated the Python docs with the new wording. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46897: [Docs][C++][Python] Fix asof join documentation [arrow]
zanmato1984 commented on code in PR #46898:
URL: https://github.com/apache/arrow/pull/46898#discussion_r2189346502
##
cpp/src/arrow/acero/options.h:
##
@@ -723,10 +723,14 @@ class ARROW_ACERO_EXPORT AsofJoinNodeOptions : public
ExecNodeOptions {
/// \see `Keys` for details.
std::vector input_keys;
/// \brief Tolerance for inexact "on" key matching. A right row is
considered a match
- /// with the left row if `right.on - left.on <= tolerance`. The `tolerance`
may be:
- /// - negative, in which case a past-as-of-join occurs;
- /// - or positive, in which case a future-as-of-join occurs;
- /// - or zero, in which case an exact-as-of-join occurs.
+ /// with a left row if `right.on - left.on` is between 0 and `tolerance`.
`tolerance`
+ /// may be:
Review Comment:
```suggestion
/// with a left row if `right.on - left.on` is within the range `[min(0,
tolerance),
/// max(0, tolerance)]`. `tolerance` may be:
```
##
cpp/src/arrow/acero/options.h:
##
@@ -700,8 +700,8 @@ class ARROW_ACERO_EXPORT AsofJoinNodeOptions : public
ExecNodeOptions {
/// \brief "on" key for the join.
///
/// The input table must be sorted by the "on" key. Must be a single field
of a common
-/// type. Inexact match is used on the "on" key. i.e., a row is considered
a match iff
-/// left_on - tolerance <= right_on <= left_on.
+/// type. An inexact match is used on the "on" key, i.e. a row is
considered a
+/// match if and only if `right.on - left.on` is between 0 and `tolerance`.
Review Comment:
```suggestion
/// match if and only if `right.on - left.on` is `right.on - left.on` is
within the
/// range `[min(0, tolerance), max(0, tolerance)]`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-46897: [Docs][C++][Python] Fix asof join documentation [arrow]
zanmato1984 commented on PR #46898: URL: https://github.com/apache/arrow/pull/46898#issuecomment-3026129831 I'll take a look soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46897: [Docs][C++][Python] Fix asof join documentation [arrow]
raulcd commented on PR #46898: URL: https://github.com/apache/arrow/pull/46898#issuecomment-3003808604 @zanmato1984 do you have some time to review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-46897: [Docs][C++][Python] Fix asof join documentation [arrow]
github-actions[bot] commented on PR #46898: URL: https://github.com/apache/arrow/pull/46898#issuecomment-3001752343 :warning: GitHub issue #46897 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
