Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
conbench-apache-arrow[bot] commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-4000729828 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 06861307a2498c6e7dc12ec90a12428ce31fe1e2. There were no benchmark performance regressions. 🎉 The [full Conbench report](https://github.com/apache/arrow/runs/65791721846) has more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd merged PR #49383: URL: https://github.com/apache/arrow/pull/49383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
github-actions[bot] commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3996899214 Revision: 0833694e1117b19293e734c23426a20981f1dfc6 Submitted crossbow builds: [ursacomputing/crossbow @ actions-754dfe4da3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-754dfe4da3) |Task|Status| ||--| |wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22667168674/job/65701740431)| |wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22667168726/job/65701740512)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3996889039 Sorry, wrong issue link on the comment (but correct on the code reference) the one I've created is this one: https://github.com/apache/arrow/issues/49447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3996884617 > Follow-up issue would be great to have I've opened https://github.com/apache/arrow/issues/49382 and have added a minor comment about the issue on the test for reference. Will validate a couple of wheels and will merge once green. Thanks @AlenkaF -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3996877783 @github-actions crossbow submit wheel-windows-cp313-cp313-amd64 wheel-manylinux-2-28-cp313-cp313-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on code in PR #49383: URL: https://github.com/apache/arrow/pull/49383#discussion_r2883221954 ## python/pyarrow/tests/test_flight.py: ## @@ -2644,6 +2646,37 @@ def test_tracing(): pass [email protected](sys.platform == "win32", Review Comment: ```suggestion # More info about the skip: GH-49447 @pytest.mark.skipif(sys.platform == "win32", ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
AlenkaF commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3996466655 Follow-up issue would be great to have, thanks! Looking at it would be worth it, I think, if the investigation doesn't take too much time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3996344062 > any idea why the traces are not visible on Windows? Thanks @AlenkaF , not really. I had to push several fixes for OpenTelemetry on Windows to even compile. I think there might be something more to that to have it fully working on Windows, not only talking about Python but Opentelemetry on Windows for C++ in general might not be working as expected. I was planning on opening an issue to investigate after this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
AlenkaF commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3996035118 Yes, will have a look at it now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3995995096 @AlenkaF @rok are you able to take a look here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
github-actions[bot] commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3983028560 Revision: 70b4611bf035fa924cc463472de3c774fde26eb8 Submitted crossbow builds: [ursacomputing/crossbow @ actions-c00a7a271f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c00a7a271f) |Task|Status| ||--| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572283/job/65370295591)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572536/job/65370296301)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572161/job/65370295261)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572831/job/65370297360)| |wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572819/job/65370297340)| |wheel-manylinux-2-28-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572677/job/65370296779)| |wheel-manylinux-2-28-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572679/job/65370296777)| |wheel-manylinux-2-28-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568573054/job/65370297976)| |wheel-musllinux-1-2-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572421/job/65370295995)| |wheel-musllinux-1-2-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572257/job/65370295456)| |wheel-musllinux-1-2-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572036/job/65370295287)| |wheel-musllinux-1-2-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572006/job/65370295237)| |wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572001/job/65370295247)| |wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22568572229/job/65370295451)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3983017004 @github-actions crossbow submit wheel-*cp313* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3983015643 @github-actions crossbow submit wheel-cp313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
github-actions[bot] commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3982967373 ``` 502 b'\r\n
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3982956771 @github-actions crossbow submit wheel-*cp313* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
github-actions[bot] commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3962316530 Revision: 2bbd485bf753e54b95a344a4ba47628ecc2c48a0 Submitted crossbow builds: [ursacomputing/crossbow @ actions-b2c694ec7c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b2c694ec7c) |Task|Status| ||--| |python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/22417492476/job/64906760088)| |wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417489333/job/64906749465)| |wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417492962/job/64906761912)| |wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417490976/job/64906754924)| |wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/2241749/job/64906748335)| |wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417489868/job/64906751290)| |wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417490642/job/64906753853)| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417490664/job/64906753984)| |wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417492789/job/64906761145)| |wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417490064/job/64906752075)| |wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417492387/job/64906759958)| |wheel-macos-monterey-cp314-cp314-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417492159/job/64906759139)| |wheel-macos-monterey-cp314-cp314-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417489966/job/64906751673)| |wheel-macos-monterey-cp314-cp314t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417491116/job/64906755407)| |wheel-macos-monterey-cp314-cp314t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/22417491644/job/64906757144)| |wheel-manylinux-2-28-cp310-cp310-amd64|[![GitHub Actions](https://github.com/ursacomputing
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3962302997 @github-actions crossbow submit -g wheel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on code in PR #49383:
URL: https://github.com/apache/arrow/pull/49383#discussion_r2854787186
##
cpp/src/arrow/util/tracing_internal.h:
##
@@ -123,13 +125,13 @@ struct Scope {
opentelemetry::trace::Scope scope_impl;
};
-opentelemetry::nostd::shared_ptr& UnwrapSpan(
+ARROW_EXPORT opentelemetry::nostd::shared_ptr&
UnwrapSpan(
Review Comment:
These symbols seem to be required to be exported for Windows:
```
2026-02-25T17:46:03.6802906Z
2026-02-25T17:46:03.6803059Z Finished searching libraries
2026-02-25T17:46:03.6813183Z unity_3_cxx.obj : error LNK2001: unresolved
external symbol "class opentelemetry::v1::nostd::shared_ptr & __cdecl
arrow::internal::tracing::RewrapSpan(class arrow::util::tracing::SpanDetails
*,class opentelemetry::v1::nostd::shared_ptr)"
(?RewrapSpan@tracing@internal@arrow@@YAAEAV?$shared_ptr@VSpan@trace@v1@opentelemetry@@@nostd@v1@opentelemetry@@PEAVSpanDetails@1util@3@V4567@@Z)
[C:\arrow-build\src\arrow\acero\arrow_acero_shared.vcxproj]
2026-02-25T17:46:03.6817761Z unity_2_cxx.obj : error LNK2001: unresolved
external symbol "class opentelemetry::v1::nostd::shared_ptr & __cdecl
arrow::internal::tracing::UnwrapSpan(class arrow::util::tracing::SpanDetails
*)"
(?UnwrapSpan@tracing@internal@arrow@@YAAEAV?$shared_ptr@VSpan@trace@v1@opentelemetry@@@nostd@v1@opentelemetry@@PEAVSpanDetails@1util@3@@Z)
[C:\arrow-build\src\arrow\acero\arrow_acero_shared.vcxproj]
2026-02-25T17:46:03.6820710Z C:\arrow-build\release\Release\arrow_acero.dll
: fatal error LNK1120: 2 unresolved externals
[C:\arrow-build\src\arrow\acero\arrow_acero_shared.vcxproj]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
github-actions[bot] commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3961203967 Revision: 2bbd485bf753e54b95a344a4ba47628ecc2c48a0 Submitted crossbow builds: [ursacomputing/crossbow @ actions-2be70cfc4f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2be70cfc4f) |Task|Status| ||--| |wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22410444951/job/64882152387)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3961192952 @github-actions crossbow submit wheel-windows-cp313-cp313-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
github-actions[bot] commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3959711180 Revision: be1de48537a9311b43456dfdef3f256c203d1df0 Submitted crossbow builds: [ursacomputing/crossbow @ actions-3168ee0ef2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3168ee0ef2) |Task|Status| ||--| |wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22401602974/job/64849518262)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3959697231 @github-actions crossbow submit wheel-windows-cp313-cp313-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
lidavidm commented on code in PR #49383:
URL: https://github.com/apache/arrow/pull/49383#discussion_r2852762154
##
cpp/src/arrow/flight/server_tracing_middleware.cc:
##
@@ -136,7 +136,7 @@ class TracingServerMiddlewareFactory : public
ServerMiddlewareFactory {
options.kind = otel::trace::SpanKind::kServer;
options.parent = otel::trace::GetSpan(new_otel_context)->GetContext();
-auto tracer =
otel::trace::Provider::GetTracerProvider()->GetTracer("arrow");
+auto tracer = arrow::internal::tracing::GetTracer();
Review Comment:
I think this is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on code in PR #49383:
URL: https://github.com/apache/arrow/pull/49383#discussion_r2852697131
##
cpp/src/arrow/flight/server_tracing_middleware.cc:
##
@@ -136,7 +136,7 @@ class TracingServerMiddlewareFactory : public
ServerMiddlewareFactory {
options.kind = otel::trace::SpanKind::kServer;
options.parent = otel::trace::GetSpan(new_otel_context)->GetContext();
-auto tracer =
otel::trace::Provider::GetTracerProvider()->GetTracer("arrow");
+auto tracer = arrow::internal::tracing::GetTracer();
Review Comment:
yeah, that was my feeling too, either not being initialized or something to
do with `libarrow.so` and `libarrow_flight.so` both linking opentelementry
statically and getting their own copy of the static opentelemetry provider
that's why I thought `CMAKE_INTERPROCEDUREAL_OPTIMIZATION` might be related
(but proved it wasn't).
The Arrow util one should cross the shared object boundary and use the
already initialized one (or initialize it) which I think is correct.
I just wanted to validate the change looks ok to you or whether do you think
it would be better to keep investigating and try to configure when calling
`MakeTracingServerMiddlewareFactory` instead of using the one initialized via
`libarrow.so`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on code in PR #49383:
URL: https://github.com/apache/arrow/pull/49383#discussion_r2852697131
##
cpp/src/arrow/flight/server_tracing_middleware.cc:
##
@@ -136,7 +136,7 @@ class TracingServerMiddlewareFactory : public
ServerMiddlewareFactory {
options.kind = otel::trace::SpanKind::kServer;
options.parent = otel::trace::GetSpan(new_otel_context)->GetContext();
-auto tracer =
otel::trace::Provider::GetTracerProvider()->GetTracer("arrow");
+auto tracer = arrow::internal::tracing::GetTracer();
Review Comment:
yeah, that was my feeling too, either not being initialized or something to
do with `libarrow.so` and libarrow_flight.so` both linking opentelementry
statically and getting their own copy of the static opentelemetry provider
that's why I thought `CMAKE_INTERPROCEDUREAL_OPTIMIZATION` might be related
(but proved it wasn't).
The Arrow util one should cross the shared object boundary and use the
already initialized one (or initialize it) which I think is correct.
I just wanted to validate the change looks ok to you or whether do you think
it would be better to keep investigating and try to configure when calling
`MakeTracingServerMiddlewareFactory` instead of using the one initialized via
`libarrow.so`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
lidavidm commented on code in PR #49383:
URL: https://github.com/apache/arrow/pull/49383#discussion_r2852617690
##
cpp/src/arrow/flight/server_tracing_middleware.cc:
##
@@ -136,7 +136,7 @@ class TracingServerMiddlewareFactory : public
ServerMiddlewareFactory {
options.kind = otel::trace::SpanKind::kServer;
options.parent = otel::trace::GetSpan(new_otel_context)->GetContext();
-auto tracer =
otel::trace::Provider::GetTracerProvider()->GetTracer("arrow");
+auto tracer = arrow::internal::tracing::GetTracer();
Review Comment:
Hmm, it's been a while since I've worked with OTel...possibly the OTel trace
provider isn't being configured (vs the hardcoded Arrow one)? The Arrow util is
about equivalent, but does some static initialization first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
github-actions[bot] commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3958552069 Revision: 8d2daf836ef338f1b4b9418e4acc518ef8f6092c Submitted crossbow builds: [ursacomputing/crossbow @ actions-4d34d6d1e1](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4d34d6d1e1) |Task|Status| ||--| |wheel-musllinux-1-2-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22394399125/job/64824294894)| |wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22394399171/job/64824294806)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3958540682 @github-actions crossbow submit wheel-windows-cp313-cp313-amd64 wheel-musllinux-1-2-cp313-cp313-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
github-actions[bot] commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3958528872 Revision: 9ccb832f492a584be5494fa1ceb7a6d7d8d20731 Submitted crossbow builds: [ursacomputing/crossbow @ actions-c6d347423f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c6d347423f) |Task|Status| ||--| |wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22394258158/job/64823822442)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3958515101 @github-actions crossbow submit wheel-macos-monterey-cp313-cp313-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on code in PR #49383:
URL: https://github.com/apache/arrow/pull/49383#discussion_r2852364170
##
cpp/src/arrow/flight/server_tracing_middleware.cc:
##
@@ -136,7 +136,7 @@ class TracingServerMiddlewareFactory : public
ServerMiddlewareFactory {
options.kind = otel::trace::SpanKind::kServer;
options.parent = otel::trace::GetSpan(new_otel_context)->GetContext();
-auto tracer =
otel::trace::Provider::GetTracerProvider()->GetTracer("arrow");
+auto tracer = arrow::internal::tracing::GetTracer();
Review Comment:
@lidavidm I am not entirely sure why this is necessary but using the example
`middleware.py` enabling otel as updated below with a running server:
```
$ export OTEL_SERVICE_NAME=arrow-raul
$ ARROW_TRACING_BACKEND=otlp_http python examples/flight/middleware.py
server --listen grpc://localhost:5050 --otel
```
and client:
```
python examples/flight/middleware.py client grpc://localhost:5050
```
I wasn't able to get traces unless I update this to use
`arrow::internal::tracing::GetTracer`. Example of local traces with the built
wheel and this changes:
https://github.com/user-attachments/assets/6c0a129f-10ac-48b3-81bd-ea7cbc26b76e";
/>
Initially I thought it might be due to the addition of
`CMAKE_INTERPROCEDURAL_OPTIMIZATION` to the wheels but I've validated is
unrelated.
Without this change I haven't been able to get opentelemetry traces using
the `flight.TracingServerMiddlewareFactory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
github-actions[bot] commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3953607433 Revision: 7426f25ba3869418816623d2410e0d17edba0995 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1e10ae4c04](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1e10ae4c04) |Task|Status| ||--| |wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/22362127705/job/64718266464)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
raulcd commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3953594776 @github-actions crossbow submit wheel-manylinux-2-28-cp313-cp313-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] GH-49382: [Python] Enable OpenTelemetry on PyArrow wheels [arrow]
github-actions[bot] commented on PR #49383: URL: https://github.com/apache/arrow/pull/49383#issuecomment-3953593965 :warning: GitHub issue #49382 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
