Re: [PR] fix duration conversion error [arrow-rs]
alamb commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-2494500138 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
EddyXorb commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-2494474636 I would love to help, but at the moment I am very very busy. Once I have time (mid december), I can try to provide a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
alamb commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-2494400307 Thanks @EddyXorb -- any chance you can make a PR with a test? It seems that that is all that is missing to be able to get this fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
EddyXorb commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-2494378232 I have the same problem with type pl.Time. When I write a column with pl.Time to a parquet file, it reads the column as int64. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
tustvold commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-2400580425 Closing as this PR has been inactive for a while -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
tustvold closed pull request #5626: fix duration conversion error URL: https://github.com/apache/arrow-rs/pull/5626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
alamb commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-2059374095 or put another way there is no way to write a duration to a parquet file with arrow-rs yet (but polars can do so). So the ideal solution is support writing duration to parquet too (but I suspect there might be work to sort out what the desired behavior is) Perhaps for this PR we can just check in a small parquet file that was written by polars and ensure we can read it back correctly 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
tustvold commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-2056601144 > write duration to parquet get a panic... Yes I think we would need #1938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
Liyixin95 commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-2054356414 > > > Could we get a test of this please > > > > > > sorry for the noob question, where should I add a test for it？ > > I think we could add a round trip test here perhaps: > > https://github.com/apache/arrow-rs/blob/91f0b1771308609ca27db0fb1d2d49571b3980d8/parquet/src/arrow/arrow_writer/mod.rs#L1996-L2007 write duration to parquet get a panic... https://github.com/apache/arrow-rs/blob/a999fb86764e9310bb4822c7e7c6551f247e0e0b/parquet/src/arrow/schema/mod.rs#L445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
alamb commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-2053633987 > > Could we get a test of this please > > sorry for the noob question, where should I add a test for it？ I think we could add a round trip test here perhaps: https://github.com/apache/arrow-rs/blob/91f0b1771308609ca27db0fb1d2d49571b3980d8/parquet/src/arrow/arrow_writer/mod.rs#L1996-L2007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
Liyixin95 commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-2053611229 > Could we get a test of this please sorry for the noob question, where should I add a test for it？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
alamb commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-205107 I agree -- a test is important to make sure we don't break this fix in some future refactor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix duration conversion error [arrow-rs]
tustvold commented on PR #5626: URL: https://github.com/apache/arrow-rs/pull/5626#issuecomment-2049233191 Could we get a test of this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
