[GitHub] [beam] pabloem commented on pull request #11634: Change TestStreamImpl to a producer/consumer pattern

pabloem commented on pull request #11634: URL: https://github.com/apache/beam/pull/11634#issuecomment-626259982 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11637: Waiting for BQ Query and Export jobs for more than 5 minutes.

pabloem commented on pull request #11637: URL: https://github.com/apache/beam/pull/11637#issuecomment-626259977 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-626259948 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] stale[bot] commented on pull request #11019: Reducing the number of API calls to BQ table.get

stale[bot] commented on pull request #11019: URL: https://github.com/apache/beam/pull/11019#issuecomment-626265059 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

[GitHub] [beam] mszb commented on a change in pull request #11210: [BEAM-8949] SpannerIO integration tests

mszb commented on a change in pull request #11210: URL: https://github.com/apache/beam/pull/11210#discussion_r422567474 ## File path: sdks/python/apache_beam/io/gcp/experimental/spannerio.py ## @@ -1008,31 +1007,30 @@ def _reset_count(self): self._cells = 0 def

[GitHub] [beam] mszb commented on a change in pull request #11210: [BEAM-8949] SpannerIO integration tests

mszb commented on a change in pull request #11210: URL: https://github.com/apache/beam/pull/11210#discussion_r422567566 ## File path: sdks/python/apache_beam/io/gcp/experimental/spannerio_test.py ## @@ -499,6 +499,7 @@ def test_batch_byte_size( # and each bach should

[GitHub] [beam] mszb commented on pull request #11210: [BEAM-8949] SpannerIO integration tests

mszb commented on pull request #11210: URL: https://github.com/apache/beam/pull/11210#issuecomment-626257027 @chamikaramj: i've made some changes, could you please trigger the tests! -Thanks This is an automated message

[GitHub] [beam] pabloem commented on pull request #11637: Waiting for BQ Query and Export jobs for more than 5 minutes.

pabloem commented on pull request #11637: URL: https://github.com/apache/beam/pull/11637#issuecomment-626277647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-626277631 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] mszb commented on a change in pull request #11210: [BEAM-8949] SpannerIO integration tests

mszb commented on a change in pull request #11210: URL: https://github.com/apache/beam/pull/11210#discussion_r422567587 ## File path: sdks/python/apache_beam/io/gcp/experimental/spannerio.py ## @@ -1008,31 +1007,30 @@ def _reset_count(self): self._cells = 0 def

[GitHub] [beam] lukecwik removed a comment on pull request #11646: [BEAM-9941] Add a BeamJava test with Flatten with different input and output Coders

lukecwik removed a comment on pull request #11646: URL: https://github.com/apache/beam/pull/11646#issuecomment-626095827 Craig, has the fix been rolled out to Dataflow service production? This is an automated message from

[GitHub] [beam] darshanj commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r422465074 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -187,83 +237,112 @@ *

[GitHub] [beam] darshanj commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r422504818 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -187,83 +237,112 @@ *

[GitHub] [beam] stale[bot] commented on pull request #9977: [BEAM-7434] [BEAM-5895] and [BEAM-5894] Fix upgrade to rabbit amqp-client 5.x

stale[bot] commented on pull request #9977: URL: https://github.com/apache/beam/pull/9977#issuecomment-626193330 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

[GitHub] [beam] pabloem commented on pull request #11637: Waiting for BQ Query and Export jobs for more than 5 minutes.

pabloem commented on pull request #11637: URL: https://github.com/apache/beam/pull/11637#issuecomment-626214601 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11634: Change TestStreamImpl to a producer/consumer pattern

pabloem commented on pull request #11634: URL: https://github.com/apache/beam/pull/11634#issuecomment-626214641 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-626214612 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] darshanj commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r422465290 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -187,83 +237,112 @@ *

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-626165907 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] darshanj commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r422465290 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -187,83 +237,112 @@ *

[GitHub] [beam] darshanj commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r422465224 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] darshanj commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r422465074 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -187,83 +237,112 @@ *

[GitHub] [beam] darshanj commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r422464890 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -187,83 +237,112 @@ *

[GitHub] [beam] robertwb opened a new pull request #11652: [BEAM-9945] Report data channel progress via a designated counter.

robertwb opened a new pull request #11652: URL: https://github.com/apache/beam/pull/11652 This turned out to make things a lot cleaner IMHO than depending on the (more distant) output PCollection element counts. Also the index here is now the same space as that used for splitting.

[GitHub] [beam] robertwb commented on pull request #11652: [BEAM-9945] Report data channel progress via a designated counter.

robertwb commented on pull request #11652: URL: https://github.com/apache/beam/pull/11652#issuecomment-626128559 R: @lukecwik This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] rahul8383 commented on pull request #11609: [BEAM-9887] Throw IllegalArgumentException when building Row with logical types with Invalid input

rahul8383 commented on pull request #11609: URL: https://github.com/apache/beam/pull/11609#issuecomment-626139746 If there are no comments, can we close this PR? This is an automated message from the Apache Git Service. To

[GitHub] [beam] rahul8383 commented on pull request #11581: [BEAM-8307] NPE in Calcite dialect when input PCollection has logical…

rahul8383 commented on pull request #11581: URL: https://github.com/apache/beam/pull/11581#issuecomment-626139548 R: @TheNeuralBit I found a bug while implementing this feature and raised PR #11609 to fix the bug as I thought that the bug fix could be cherry-picked in 2.21.0

[GitHub] [beam] robertwb opened a new pull request #11653: [BEAM-9935] Respect allowed split points in Python.

robertwb opened a new pull request #11653: URL: https://github.com/apache/beam/pull/11653 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] darshanj commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r422465074 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -187,83 +237,112 @@ *

[GitHub] [beam] rahul8383 commented on pull request #11609: [BEAM-9887] Throw IllegalArgumentException when building Row with logical types with Invalid input

rahul8383 commented on pull request #11609: URL: https://github.com/apache/beam/pull/11609#issuecomment-626140088 > I'd be +1 for just dropping the padding logic. I don't think it should be the responsibility of the LogicalType to coerce values like this. What do you think @reuvenlax?

[GitHub] [beam] robertwb commented on pull request #11653: [BEAM-9935] Respect allowed split points in Python.

robertwb commented on pull request #11653: URL: https://github.com/apache/beam/pull/11653#issuecomment-626144465 R: @lukecwik This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] mwalenia commented on pull request #11566: [BEAM-9723] Add DLP integration transforms

mwalenia commented on pull request #11566: URL: https://github.com/apache/beam/pull/11566#issuecomment-626131577 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please