[GitHub] [beam] henryken commented on a change in pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
henryken commented on a change in pull request #11883: URL: https://github.com/apache/beam/pull/11883#discussion_r435314757 ## File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-04 Thread GitBox
aromanenko-dev commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r435354750 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the

[GitHub] [beam] TobKed commented on pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
TobKed commented on pull request #11877: URL: https://github.com/apache/beam/pull/11877#issuecomment-638978380 > How can I preview the action on the fork: [TobKed#3](https://github.com/TobKed/beam/pull/3) ? @aaltay

[GitHub] [beam] lastomato opened a new pull request #11920: Minor formatting updates.

2020-06-04 Thread GitBox
lastomato opened a new pull request #11920: URL: https://github.com/apache/beam/pull/11920 - Chain constructors instead of assigning directly; - Typo fixes. The changes in this PR were from an internal code review. R: @pabloem cc @jaketf

[GitHub] [beam] lastomato commented on pull request #11920: Minor formatting updates.

2020-06-04 Thread GitBox
lastomato commented on pull request #11920: URL: https://github.com/apache/beam/pull/11920#issuecomment-638928233 I am not entirely sure if I need to create a JIRA issue for such a trivial change. This is an automated

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11766: [BEAM-10036] More flexible dataframes partitioning.

2020-06-04 Thread GitBox
TheNeuralBit commented on a change in pull request #11766: URL: https://github.com/apache/beam/pull/11766#discussion_r435422511 ## File path: sdks/python/apache_beam/dataframe/expressions.py ## @@ -85,16 +87,10 @@ def evaluate_at(self, session): # type: (Session) -> T

[GitHub] [beam] damondouglas commented on pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
damondouglas commented on pull request #11883: URL: https://github.com/apache/beam/pull/11883#issuecomment-638992758 I've incorporated all the helpful comments. I'll wait for Henry's final approval before updating stepik/committing `*-remote.yaml` files. Thank you, both.

[GitHub] [beam] damondouglas commented on a change in pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
damondouglas commented on a change in pull request #11883: URL: https://github.com/apache/beam/pull/11883#discussion_r435303784 ## File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation

[GitHub] [beam] damondouglas commented on a change in pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
damondouglas commented on a change in pull request #11883: URL: https://github.com/apache/beam/pull/11883#discussion_r435349866 ## File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go ## @@ -47,9 +47,9 @@ func (c *averageFn) MergeAccumulators(accumA,

[GitHub] [beam] chamikaramj commented on pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

2020-06-04 Thread GitBox
chamikaramj commented on pull request #11919: URL: https://github.com/apache/beam/pull/11919#issuecomment-638938144 @dpmills @slavachernyak @reuvenlax are you interested in reviewing this ? This is an automated message from

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11918: Add instructions to programmatically publish release to Github

2020-06-04 Thread GitBox
TheNeuralBit commented on a change in pull request #11918: URL: https://github.com/apache/beam/pull/11918#discussion_r435351070 ## File path: website/www/site/content/en/contribute/release-guide.md ## @@ -1134,12 +1134,29 @@ Create and push a new signed tag for the released

[GitHub] [beam] henryken commented on a change in pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
henryken commented on a change in pull request #11883: URL: https://github.com/apache/beam/pull/11883#discussion_r435317881 ## File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go ## @@ -47,9 +47,9 @@ func (c *averageFn) MergeAccumulators(accumA,

[GitHub] [beam] lostluck commented on a change in pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
lostluck commented on a change in pull request #11883: URL: https://github.com/apache/beam/pull/11883#discussion_r435344008 ## File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-04 Thread GitBox
aromanenko-dev commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r434729096 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-04 Thread GitBox
aromanenko-dev commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r435359001 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java ## @@ -906,19 +955,110 @@ public void

[GitHub] [beam] lostluck commented on a change in pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
lostluck commented on a change in pull request #11883: URL: https://github.com/apache/beam/pull/11883#discussion_r435397313 ## File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go ## @@ -47,9 +47,9 @@ func (c *averageFn) MergeAccumulators(accumA,

[GitHub] [beam] ibzib opened a new pull request #11921: [BEAM-10194] Call println() in Katas test failures.

2020-06-04 Thread GitBox
ibzib opened a new pull request #11921: URL: https://github.com/apache/beam/pull/11921 R: @henryken Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] ibzib commented on a change in pull request #11918: Add instructions to programmatically publish release to Github

2020-06-04 Thread GitBox
ibzib commented on a change in pull request #11918: URL: https://github.com/apache/beam/pull/11918#discussion_r435356754 ## File path: website/www/site/content/en/contribute/release-guide.md ## @@ -1134,12 +1134,29 @@ Create and push a new signed tag for the released version

[GitHub] [beam] robertwb commented on a change in pull request #11766: [BEAM-10036] More flexible dataframes partitioning.

2020-06-04 Thread GitBox
robertwb commented on a change in pull request #11766: URL: https://github.com/apache/beam/pull/11766#discussion_r435373732 ## File path: sdks/python/apache_beam/dataframe/expressions.py ## @@ -85,16 +87,10 @@ def evaluate_at(self, session): # type: (Session) -> T

[GitHub] [beam] y1chi commented on pull request #11916: [BEAM-10189] Add ValueState user state to python sdk

2020-06-04 Thread GitBox
y1chi commented on pull request #11916: URL: https://github.com/apache/beam/pull/11916#issuecomment-638950281 > Last time someone started adding this feature, we decided to call it ReadModifyWrite state. Java SDK still calls this ValueState, ReadModifyWriteState is only used in

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435403856 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435404202 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] lukecwik merged pull request #11915: [BEAM-10190] Reduce cost of toString of MetricKey and MetricName

2020-06-04 Thread GitBox
lukecwik merged pull request #11915: URL: https://github.com/apache/beam/pull/11915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] ibzib commented on pull request #11921: [BEAM-10194] Call println() in Katas test failures.

2020-06-04 Thread GitBox
ibzib commented on pull request #11921: URL: https://github.com/apache/beam/pull/11921#issuecomment-638977383 > @ibzib, may I know what kind of error that you encountered that needs this fix? Please see the related jira: https://issues.apache.org/jira/browse/BEAM-10194

[GitHub] [beam] lukecwik commented on pull request #11915: [BEAM-10190] Reduce cost of toString of MetricKey and MetricName

2020-06-04 Thread GitBox
lukecwik commented on pull request #11915: URL: https://github.com/apache/beam/pull/11915#issuecomment-638977891 Nice article on the performance impact of the different string concatenation methods. This is an automated

[GitHub] [beam] aromanenko-dev removed a comment on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

2020-06-04 Thread GitBox
aromanenko-dev removed a comment on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-638983908 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

2020-06-04 Thread GitBox
aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-638984333 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

2020-06-04 Thread GitBox
aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-638984073 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aromanenko-dev removed a comment on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

2020-06-04 Thread GitBox
aromanenko-dev removed a comment on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-638984073 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11920: Minor formatting updates.

2020-06-04 Thread GitBox
pabloem commented on pull request #11920: URL: https://github.com/apache/beam/pull/11920#issuecomment-638947008 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435407993 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] kamilwu commented on a change in pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-06-04 Thread GitBox
kamilwu commented on a change in pull request #11856: URL: https://github.com/apache/beam/pull/11856#discussion_r435308264 ## File path: .test-infra/jenkins/job_LoadTests_SideInput_Python.groovy ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [beam] dpcollins-google opened a new pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

2020-06-04 Thread GitBox
dpcollins-google opened a new pull request #11919: URL: https://github.com/apache/beam/pull/11919 Also adapt to beam conventions and restrictions. This is staged here https://github.com/googleapis/java-pubsublite/tree/master/pubsublite-beam-io

[GitHub] [beam] ibzib commented on pull request #11918: Add instructions to programmatically publish release to Github

2020-06-04 Thread GitBox
ibzib commented on pull request #11918: URL: https://github.com/apache/beam/pull/11918#issuecomment-638943733 I didn't realize Brian had already reviewed... and we had almost the exact same comments ´ść This is an automated

[GitHub] [beam] robertwb commented on pull request #11835: Various fixes to allow Java PAssert to run on Python

2020-06-04 Thread GitBox
robertwb commented on pull request #11835: URL: https://github.com/apache/beam/pull/11835#issuecomment-638952489 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] chamikaramj commented on pull request #11846: [BEAM-9869] adding self-contained Kafka service jar for testing

2020-06-04 Thread GitBox
chamikaramj commented on pull request #11846: URL: https://github.com/apache/beam/pull/11846#issuecomment-638992107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] pabloem merged pull request #11898: [BEAM-10178] Improved error messages when option is not set

2020-06-04 Thread GitBox
pabloem merged pull request #11898: URL: https://github.com/apache/beam/pull/11898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] robertwb merged pull request #11787: [BEAM-10063] Better emulate the pandas testing environment.

2020-06-04 Thread GitBox
robertwb merged pull request #11787: URL: https://github.com/apache/beam/pull/11787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] robertwb commented on a change in pull request #11787: [BEAM-10063] Better emulate the pandas testing environment.

2020-06-04 Thread GitBox
robertwb commented on a change in pull request #11787: URL: https://github.com/apache/beam/pull/11787#discussion_r435370735 ## File path: sdks/python/apache_beam/dataframe/doctests.py ## @@ -66,30 +93,19 @@ def __init__(self): self._all_frames = {} def

[GitHub] [beam] apilloud commented on pull request #11836: [BEAM-8693] Remove workaround for bigquery client

2020-06-04 Thread GitBox
apilloud commented on pull request #11836: URL: https://github.com/apache/beam/pull/11836#issuecomment-639007691 R: @suztomo This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] TheNeuralBit merged pull request #11918: [BEAM-10188] Add instructions to programmatically publish release to Github

2020-06-04 Thread GitBox
TheNeuralBit merged pull request #11918: URL: https://github.com/apache/beam/pull/11918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] lukecwik commented on pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window.

2020-06-04 Thread GitBox
lukecwik commented on pull request #11922: URL: https://github.com/apache/beam/pull/11922#issuecomment-639020928 R: @boyuanzz @chamikaramj This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik opened a new pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window.

2020-06-04 Thread GitBox
lukecwik opened a new pull request #11922: URL: https://github.com/apache/beam/pull/11922 This fixes a bug where we would output within all the windows instead of just the current window. This would not impact any SDF that used only a single window while processing.

[GitHub] [beam] rehmanmuradali commented on pull request #11924: [BEAM-8543] Dataflow streaming timers are not strictly time ordered when set earlier mid-bundle

2020-06-04 Thread GitBox
rehmanmuradali commented on pull request #11924: URL: https://github.com/apache/beam/pull/11924#issuecomment-639088647 R: @reuvenlax Could you please take a look that I am on right track? This is an automated message

[GitHub] [beam] chamikaramj commented on pull request #11846: [BEAM-9869] adding self-contained Kafka service jar for testing

2020-06-04 Thread GitBox
chamikaramj commented on pull request #11846: URL: https://github.com/apache/beam/pull/11846#issuecomment-639098591 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

2020-06-04 Thread GitBox
lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r435546832 ## File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FnApiDoFnRunnerTest.java ## @@ -1593,6 +1601,391 @@ public void

[GitHub] [beam] apilloud commented on pull request #11836: [BEAM-8693] Remove workaround for bigquery client

2020-06-04 Thread GitBox
apilloud commented on pull request #11836: URL: https://github.com/apache/beam/pull/11836#issuecomment-639023595 I get `No new linkage errors`. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] chunyang commented on pull request #11923: [BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types

2020-06-04 Thread GitBox
chunyang commented on pull request #11923: URL: https://github.com/apache/beam/pull/11923#issuecomment-639047436 R: @pabloem This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] jaketf edited a comment on pull request #11893: [BEAM-10175] use bearer token header instead of url param for token

2020-06-04 Thread GitBox
jaketf edited a comment on pull request #11893: URL: https://github.com/apache/beam/pull/11893#issuecomment-639055068 Hmmm my latest commit was just `spotlessApply` and this entire PR's change (how we pass the auth token for HCAPI requests for FHIR) seems unrelated to the GCS object

[GitHub] [beam] bashir2 commented on pull request #11617: Update programming-guide.md with some typo fixes.

2020-06-04 Thread GitBox
bashir2 commented on pull request #11617: URL: https://github.com/apache/beam/pull/11617#issuecomment-639060524 Closing this for now; will try to recreate another one later if I come back to Beam documentation. This is an

[GitHub] [beam] bashir2 closed pull request #11617: Update programming-guide.md with some typo fixes.

2020-06-04 Thread GitBox
bashir2 closed pull request #11617: URL: https://github.com/apache/beam/pull/11617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] apilloud commented on a change in pull request #11868: [BEAM-9363] Support HOP and SESSION as TVF

2020-06-04 Thread GitBox
apilloud commented on a change in pull request #11868: URL: https://github.com/apache/beam/pull/11868#discussion_r435497089 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/TVFSlidingWindowFn.java ## @@ -0,0 +1,101 @@ +/* + *

[GitHub] [beam] xinyuiscool commented on pull request #11915: [BEAM-10190] Reduce cost of toString of MetricKey and MetricName

2020-06-04 Thread GitBox
xinyuiscool commented on pull request #11915: URL: https://github.com/apache/beam/pull/11915#issuecomment-639006539 @lukecwik : thanks for merging it! This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] chunyang opened a new pull request #11923: [BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types

2020-06-04 Thread GitBox
chunyang opened a new pull request #11923: URL: https://github.com/apache/beam/pull/11923 Support STRUCT, FLOAT64, INT64 BigQuery types in BIgQuery to Avro schema conversion. We already support RECORD, FLOAT, and INTEGER, which are aliases of the three types being added.

[GitHub] [beam] jaketf commented on pull request #11893: [BEAM-10175] use bearer token header instead of url param for token

2020-06-04 Thread GitBox
jaketf commented on pull request #11893: URL: https://github.com/apache/beam/pull/11893#issuecomment-639055068 Hmmm my latest commit was just `spotlessApply` and this entire PR's change (how we pass the auth token for HCAPI requests for FHIR) seems unrelated to the GCS object moving logic

[GitHub] [beam] ibzib commented on pull request #11918: [BEAM-10188] Add instructions to programmatically publish release to Github

2020-06-04 Thread GitBox
ibzib commented on pull request #11918: URL: https://github.com/apache/beam/pull/11918#issuecomment-639062174 > All the variables used should already be set in script.config. Does that work? That's probably fine, but if that's the expectation we need to `source script.config`.

[GitHub] [beam] lukecwik commented on pull request #11821: [BEAM-10097, BEAM-5982, BEAM-3080] Use primitive views directly instead of transforming KV> to the view type via a naive ma

2020-06-04 Thread GitBox
lukecwik commented on pull request #11821: URL: https://github.com/apache/beam/pull/11821#issuecomment-639108631 R: @Ardagan @amaliujia This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11766: [BEAM-10036] More flexible dataframes partitioning.

2020-06-04 Thread GitBox
TheNeuralBit commented on a change in pull request #11766: URL: https://github.com/apache/beam/pull/11766#discussion_r435426414 ## File path: sdks/python/apache_beam/dataframe/partitionings.py ## @@ -0,0 +1,136 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [beam] jphalip commented on pull request #11918: [BEAM-10188] Add instructions to programmatically publish release to Github

2020-06-04 Thread GitBox
jphalip commented on pull request #11918: URL: https://github.com/apache/beam/pull/11918#issuecomment-639064988 Ok, I've loaded `script.config`. I've also added a confirmation message before submitting the API request. This

[GitHub] [beam] pabloem commented on pull request #11920: Minor formatting updates.

2020-06-04 Thread GitBox
pabloem commented on pull request #11920: URL: https://github.com/apache/beam/pull/11920#issuecomment-639065558 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lostluck opened a new pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-04 Thread GitBox
lostluck opened a new pull request #11925: URL: https://github.com/apache/beam/pull/11925 This adds initial utility functions for encoding and decoding utf8 strings in the Go SDK. Doesn't make use of them yet. In practice this is already how strings are encoded in the Go SDK, but

[GitHub] [beam] suztomo commented on pull request #11836: [BEAM-8693] Remove workaround for bigquery client

2020-06-04 Thread GitBox
suztomo commented on pull request #11836: URL: https://github.com/apache/beam/pull/11836#issuecomment-639010785 Does `sdks/java/build-tools/beam-linkage-check.sh` ([wiki](https://cwiki.apache.org/confluence/display/BEAM/Dependency+Upgrades)), without arguments, complain anything now?

[GitHub] [beam] apilloud merged pull request #11836: [BEAM-8693] Remove workaround for bigquery client

2020-06-04 Thread GitBox
apilloud merged pull request #11836: URL: https://github.com/apache/beam/pull/11836 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #11893: [BEAM-10175] use bearer token header instead of url param for token

2020-06-04 Thread GitBox
pabloem commented on pull request #11893: URL: https://github.com/apache/beam/pull/11893#issuecomment-639059270 Ah great observation! I'll merge. I am not aware of it being flaky otherwise. This is an automated message from

[GitHub] [beam] pabloem merged pull request #11893: [BEAM-10175] use bearer token header instead of url param for token

2020-06-04 Thread GitBox
pabloem merged pull request #11893: URL: https://github.com/apache/beam/pull/11893 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] jphalip commented on pull request #11918: [BEAM-10188] Add instructions to programmatically publish release to Github

2020-06-04 Thread GitBox
jphalip commented on pull request #11918: URL: https://github.com/apache/beam/pull/11918#issuecomment-639058954 @ibzib @TheNeuralBit Thank you both for the feedback. I've moved the code to a separate script. All the variables used should already be set in `script.config`. Does that work?

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

2020-06-04 Thread GitBox
vmarquez commented on a change in pull request #10546: URL: https://github.com/apache/beam/pull/10546#discussion_r434870508 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ## @@ -1170,4 +898,44 @@ private void

[GitHub] [beam] lostluck opened a new pull request #11926: [BEAM-9615] Additional coder unit tests

2020-06-04 Thread GitBox
lostluck opened a new pull request #11926: URL: https://github.com/apache/beam/pull/11926 Adds a unit test for the "user side" type encoders /decoders. This will help avoiding having a broken state as we change the string coder, and default custom type coders. Also adjusts the

[GitHub] [beam] lostluck commented on pull request #11926: [BEAM-9615] Additional coder unit tests

2020-06-04 Thread GitBox
lostluck commented on pull request #11926: URL: https://github.com/apache/beam/pull/11926#issuecomment-639122665 R: @tysonjh cc: @youngoli This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] Zhangyx39 commented on pull request #11915: [BEAM-10190] Reduce cost of toString of MetricKey and MetricName

2020-06-04 Thread GitBox
Zhangyx39 commented on pull request #11915: URL: https://github.com/apache/beam/pull/11915#issuecomment-639009096 Thank you, Likasz and Xinyu. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] rehmanmuradali opened a new pull request #11924: [BEAM-8543] Dataflow streaming timers are not strictly time ordered when set earlier mid-bundle

2020-06-04 Thread GitBox
rehmanmuradali opened a new pull request #11924: URL: https://github.com/apache/beam/pull/11924 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] boyuanzz commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

2020-06-04 Thread GitBox
boyuanzz commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r435521657 ## File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FnApiDoFnRunnerTest.java ## @@ -1593,6 +1601,391 @@ public void

[GitHub] [beam] pabloem merged pull request #11920: Minor formatting updates.

2020-06-04 Thread GitBox
pabloem merged pull request #11920: URL: https://github.com/apache/beam/pull/11920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] lostluck commented on pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-04 Thread GitBox
lostluck commented on pull request #11925: URL: https://github.com/apache/beam/pull/11925#issuecomment-639119430 R: @tysonjh cc: @youngoli This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robertwb commented on pull request #11916: [BEAM-10189] Add ValueState user state to python sdk

2020-06-04 Thread GitBox
robertwb commented on pull request #11916: URL: https://github.com/apache/beam/pull/11916#issuecomment-639157754 Yes, the plan was to consider changing Java too, though that's harder due to backwards compatibility issues.

[GitHub] [beam] kennknowles commented on a change in pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-04 Thread GitBox
kennknowles commented on a change in pull request #11820: URL: https://github.com/apache/beam/pull/11820#discussion_r435594096 ## File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/zetasql/ZetaSqlQuery0.java ## @@ -0,0 +1,92 @@ +/* + *

[GitHub] [beam] aaltay commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
aaltay commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435630823 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] aaltay commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
aaltay commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435631141 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] robertwb commented on pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

2020-06-04 Thread GitBox
robertwb commented on pull request #11884: URL: https://github.com/apache/beam/pull/11884#issuecomment-639161004 There's a lot of files there that don't seem relevant; I think we should go through and figure out what's needed for the actual plugin vs. what's "extras" that just got copied

[GitHub] [beam] lostluck commented on pull request #11927: [BEAM-9615] finish standardizing proto import names

2020-06-04 Thread GitBox
lostluck commented on pull request #11927: URL: https://github.com/apache/beam/pull/11927#issuecomment-639183557 R: @tysonjh cc: @youngoli This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robertwb commented on a change in pull request #11766: [BEAM-10036] More flexible dataframes partitioning.

2020-06-04 Thread GitBox
robertwb commented on a change in pull request #11766: URL: https://github.com/apache/beam/pull/11766#discussion_r435632933 ## File path: sdks/python/apache_beam/dataframe/expressions.py ## @@ -85,16 +87,10 @@ def evaluate_at(self, session): # type: (Session) -> T

[GitHub] [beam] suztomo commented on pull request #11586: [BEAM-9444] GCP Library BOM as a Map

2020-06-04 Thread GitBox
suztomo commented on pull request #11586: URL: https://github.com/apache/beam/pull/11586#issuecomment-639232697 This idea was a bad idea; a hack on top of another hack. This is an automated message from the Apache Git

[GitHub] [beam] aaltay commented on pull request #11804: Corrected the input to execute the Java JAR file

2020-06-04 Thread GitBox
aaltay commented on pull request #11804: URL: https://github.com/apache/beam/pull/11804#issuecomment-639232691 Are not both `gcpTempLocation` or `tempLocation` both valid? This is an automated message from the Apache Git

[GitHub] [beam] suztomo closed pull request #11586: [BEAM-9444] GCP Library BOM as a Map

2020-06-04 Thread GitBox
suztomo closed pull request #11586: URL: https://github.com/apache/beam/pull/11586 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] apilloud commented on a change in pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-04 Thread GitBox
apilloud commented on a change in pull request #11820: URL: https://github.com/apache/beam/pull/11820#discussion_r435598706 ## File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/zetasql/ZetaSqlQuery0.java ## @@ -0,0 +1,92 @@ +/* + *

[GitHub] [beam] kennknowles commented on a change in pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-04 Thread GitBox
kennknowles commented on a change in pull request #11820: URL: https://github.com/apache/beam/pull/11820#discussion_r435622797 ## File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/zetasql/ZetaSqlQuery0.java ## @@ -0,0 +1,92 @@ +/* + *

[GitHub] [beam] lostluck opened a new pull request #11927: [BEAM-9615] finish standardizing proto import names

2020-06-04 Thread GitBox
lostluck opened a new pull request #11927: URL: https://github.com/apache/beam/pull/11927 I noticed that there were several stranglers that were not following the import name conventions, and this PR completes that work. pipepb, fnpb, jobpb for the Pipeline protos, Fn Execution

[GitHub] [beam] chamikaramj opened a new pull request #11928: [ BEAM-3788] Updates kafka.py pydocs

2020-06-04 Thread GitBox
chamikaramj opened a new pull request #11928: URL: https://github.com/apache/beam/pull/11928 Also removes it from in-progress IO connectors list now that it's supported by portable runners as well as Dataflow. Thank you for your contribution! Follow

[GitHub] [beam] kennknowles commented on a change in pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-04 Thread GitBox
kennknowles commented on a change in pull request #11820: URL: https://github.com/apache/beam/pull/11820#discussion_r435597049 ## File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/zetasql/ZetaSqlQuery0.java ## @@ -0,0 +1,92 @@ +/* + *

[GitHub] [beam] chamikaramj commented on pull request #11928: [ BEAM-3788] Updates kafka.py pydocs

2020-06-04 Thread GitBox
chamikaramj commented on pull request #11928: URL: https://github.com/apache/beam/pull/11928#issuecomment-639190896 R: @robertwb CC: @mxm This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] aaltay commented on pull request #11805: Add documentation for python apache-beam[aws] installation

2020-06-04 Thread GitBox
aaltay commented on pull request #11805: URL: https://github.com/apache/beam/pull/11805#issuecomment-639232145 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] robertwb commented on pull request #11835: Various fixes to allow Java PAssert to run on Python

2020-06-04 Thread GitBox
robertwb commented on pull request #11835: URL: https://github.com/apache/beam/pull/11835#issuecomment-639152041 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] kennknowles commented on a change in pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-04 Thread GitBox
kennknowles commented on a change in pull request #11820: URL: https://github.com/apache/beam/pull/11820#discussion_r435597049 ## File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/zetasql/ZetaSqlQuery0.java ## @@ -0,0 +1,92 @@ +/* + *

[GitHub] [beam] aaltay commented on pull request #11882: [BEAM-10112] Add state and timer python examples to website

2020-06-04 Thread GitBox
aaltay commented on pull request #11882: URL: https://github.com/apache/beam/pull/11882#issuecomment-639231673 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] henryken commented on pull request #11921: [BEAM-10194] Call println() in Katas test failures.

2020-06-04 Thread GitBox
henryken commented on pull request #11921: URL: https://github.com/apache/beam/pull/11921#issuecomment-639237442 @pabloem, can help to merge? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robertwb commented on a change in pull request #11894: [BEAM-7074] Enable test_pardo_timers_clear for fn_runner

2020-06-04 Thread GitBox
robertwb commented on a change in pull request #11894: URL: https://github.com/apache/beam/pull/11894#discussion_r435595283 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py ## @@ -377,11 +377,6 @@ def process_timer(

[GitHub] [beam] aaltay commented on pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
aaltay commented on pull request #11877: URL: https://github.com/apache/beam/pull/11877#issuecomment-639190586 > > How can I preview the action on the fork: [TobKed#3](https://github.com/TobKed/beam/pull/3) ? > > @aaltay

[GitHub] [beam] lostluck commented on pull request #11927: [BEAM-9615] finish standardizing proto import names

2020-06-04 Thread GitBox
lostluck commented on pull request #11927: URL: https://github.com/apache/beam/pull/11927#issuecomment-639196604 Run Go PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11706: [BEAM-8451] annotate python only sections

2020-06-04 Thread GitBox
aaltay commented on pull request #11706: URL: https://github.com/apache/beam/pull/11706#issuecomment-639230979 @rosetn - did you have a chance to review this? This is an automated message from the Apache Git Service. To

[GitHub] [beam] amaliujia commented on pull request #11868: [BEAM-9363] Support HOP and SESSION as TVF

2020-06-04 Thread GitBox
amaliujia commented on pull request #11868: URL: https://github.com/apache/beam/pull/11868#issuecomment-639251081 Thank you Andrew! Will address your comments soon! This is an automated message from the Apache Git Service.

  1   2   >