TheNeuralBit commented on pull request #12399:
URL: https://github.com/apache/beam/pull/12399#issuecomment-665898624
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the
amaliujia merged pull request #12400:
URL: https://github.com/apache/beam/pull/12400
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
robertwb merged pull request #11974:
URL: https://github.com/apache/beam/pull/11974
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chamikaramj commented on a change in pull request #12399:
URL: https://github.com/apache/beam/pull/12399#discussion_r462658530
##
File path: sdks/python/apache_beam/examples/sql_taxi.py
##
@@ -0,0 +1,97 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
boyuanzz opened a new pull request #12419:
URL: https://github.com/apache/beam/pull/12419
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
jiyongjung0 commented on pull request #12404:
URL: https://github.com/apache/beam/pull/12404#issuecomment-666007314
R: @aaltay
Could you please take a look?
This is an automated message from the Apache Git Service.
rohdesamuel opened a new pull request #12414:
URL: https://github.com/apache/beam/pull/12414
Change-Id: I52a4f36b09e6f6899d7c59756c9702ba983e083b
PR 5/7
The logic to stop reading from cache was incorrect and did not properly stop
if the cache changed.
pabloem commented on pull request #12418:
URL: https://github.com/apache/beam/pull/12418#issuecomment-665868369
oddly I got this to pass on my machine.
This is an automated message from the Apache Git Service.
To respond to
tvalentyn commented on a change in pull request #12212:
URL: https://github.com/apache/beam/pull/12212#discussion_r462566471
##
File path: website/www/site/content/en/get-started/downloads.md
##
@@ -87,6 +87,13 @@ versions denoted `0.x.y`.
## Releases
+### 2.23.0
iindyk commented on pull request #12420:
URL: https://github.com/apache/beam/pull/12420#issuecomment-666062605
R: @chrisgorgo
This is an automated message from the Apache Git Service.
To respond to the message, please log
rohdesamuel commented on pull request #12410:
URL: https://github.com/apache/beam/pull/12410#issuecomment-665827616
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kennknowles commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-665951261
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
saavannanavati commented on pull request #12009:
URL: https://github.com/apache/beam/pull/12009#issuecomment-666071126
run python precommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem opened a new pull request #12418:
URL: https://github.com/apache/beam/pull/12418
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
robinyqiu commented on a change in pull request #12348:
URL: https://github.com/apache/beam/pull/12348#discussion_r462568818
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SupportedZetaSqlBuiltinFunctions.java
##
@@
KevinGG commented on pull request #12372:
URL: https://github.com/apache/beam/pull/12372#issuecomment-665888592
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tvalentyn merged pull request #12212:
URL: https://github.com/apache/beam/pull/12212
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tysonjh opened a new pull request #12416:
URL: https://github.com/apache/beam/pull/12416
Update google-api-services* versions and google-client version to latest.
Thank you for your contribution! Follow this checklist to help us
incorporate your
lostluck merged pull request #12393:
URL: https://github.com/apache/beam/pull/12393
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rohdesamuel opened a new pull request #12411:
URL: https://github.com/apache/beam/pull/12411
Change-Id: I9f7030999f2ce38073ca72512c71794dbdbc301e
PR 2/7
This will allow for the cache to stop reading based on elements. Currently,
the cache can only stop based on global
lostluck commented on pull request #12393:
URL: https://github.com/apache/beam/pull/12393#issuecomment-665916062
Thank you for the contribution!
This is an automated message from the Apache Git Service.
To respond to the
henryken commented on pull request #12362:
URL: https://github.com/apache/beam/pull/12362#issuecomment-666093915
Thanks for the change @robertwb! LGTM.
After the merge, I'll help to update the course on Stepik.
This is an
iindyk opened a new pull request #12420:
URL: https://github.com/apache/beam/pull/12420
Extending functionality of ApproximateQuantiles PTransform to calculate
quantiles of a data stream with custom weights. In case of weighted quantiles,
input PCollection is expected to contain tuples of
rohdesamuel opened a new pull request #12412:
URL: https://github.com/apache/beam/pull/12412
Change-Id: I093e1dc1f99c31b1e0bb868fc3bcfc507bd24c8d
PR 3/7
This builds on https://github.com/apache/beam/pull/12411 to utilize the
ElementLimiters to stop reading from cache. This
rohdesamuel opened a new pull request #12410:
URL: https://github.com/apache/beam/pull/12410
Change-Id: I1b25694c2f8f52d5335da889610ae1871deb0917
PR 1/7
When the DirectRunner gets canceled, there is no signal to pass to the
evaluation context to gracefully shut it down. The
piotr-szuberski commented on a change in pull request #12406:
URL: https://github.com/apache/beam/pull/12406#discussion_r462771399
##
File path: sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py
##
@@ -91,7 +90,12 @@ def setUp(self):
self.host, self.port,
ibzib commented on a change in pull request #12212:
URL: https://github.com/apache/beam/pull/12212#discussion_r462571597
##
File path: website/www/site/content/en/get-started/downloads.md
##
@@ -87,6 +87,13 @@ versions denoted `0.x.y`.
## Releases
+### 2.23.0 (2020-07-16)
chamikaramj commented on a change in pull request #12406:
URL: https://github.com/apache/beam/pull/12406#discussion_r462656463
##
File path: sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py
##
@@ -91,7 +90,12 @@ def setUp(self):
self.host, self.port,
prodonjs commented on a change in pull request #12372:
URL: https://github.com/apache/beam/pull/12372#discussion_r462515880
##
File path:
sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/kernel/KernelModel.ts
##
@@ -0,0 +1,161 @@
+//
aaltay commented on pull request #12118:
URL: https://github.com/apache/beam/pull/12118#issuecomment-665835545
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
ihji commented on pull request #12106:
URL: https://github.com/apache/beam/pull/12106#issuecomment-665922796
LGTM. Thanks.
@chamikaramj Any additional comment?
This is an automated message from the Apache Git
KevinGG commented on a change in pull request #12372:
URL: https://github.com/apache/beam/pull/12372#discussion_r462542550
##
File path:
sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/kernel/KernelModel.ts
##
@@ -0,0 +1,161 @@
+//
kennknowles commented on pull request #12400:
URL: https://github.com/apache/beam/pull/12400#issuecomment-666032661
It is a good point that `CalcMergeRule` and `FilterToCalcRule` should be
enough so this rule is not needed. You might ask on dev@calcite why they both
exist.
But how
aaltay commented on pull request #12409:
URL: https://github.com/apache/beam/pull/12409#issuecomment-665836821
LGTM. Ping me when ready.
This is an automated message from the Apache Git Service.
To respond to the message,
aaltay merged pull request #12394:
URL: https://github.com/apache/beam/pull/12394
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ihji commented on a change in pull request #12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r462534513
##
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImplTest.java
##
@@ -733,26 +734,29 @@
kennknowles merged pull request #11924:
URL: https://github.com/apache/beam/pull/11924
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rohdesamuel opened a new pull request #12413:
URL: https://github.com/apache/beam/pull/12413
Change-Id: I9a2fbf1532b3d22a612e7a09f4f1fb2b9635c40b
PR 4/7
Reading elements from cache can yield TestStreamFileRecords which can have
many elements that exceeds the requested element
tvalentyn merged pull request #12213:
URL: https://github.com/apache/beam/pull/12213
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tvalentyn commented on pull request #12212:
URL: https://github.com/apache/beam/pull/12212#issuecomment-665910356
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
davidyan74 commented on a change in pull request #12411:
URL: https://github.com/apache/beam/pull/12411#discussion_r462561306
##
File path:
sdks/python/apache_beam/runners/interactive/options/capture_limiters.py
##
@@ -71,3 +87,62 @@ def _trigger(self):
def
tysonjh commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-665843586
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
damondouglas commented on pull request #12402:
URL: https://github.com/apache/beam/pull/12402#issuecomment-665916576
@lostluck The `*-remote.yaml` files are now committed from updating the
[Stepik course](https://stepik.org/course/70387) and this PR is ready to merge.
simonepri commented on pull request #12421:
URL: https://github.com/apache/beam/pull/12421#issuecomment-666285522
R: @youngoli, @lostluck
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski opened a new pull request #12422:
URL: https://github.com/apache/beam/pull/12422
I've done this by the way of writing cross-language integration tests.
Thank you for your contribution! Follow this checklist to help us
incorporate your
piotr-szuberski commented on pull request #12422:
URL: https://github.com/apache/beam/pull/12422#issuecomment-666291814
R: @TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message,
rworley-monster removed a comment on pull request #12389:
URL: https://github.com/apache/beam/pull/12389#issuecomment-664974133
retest this please
This is an automated message from the Apache Git Service.
To respond to the
damgad commented on pull request #12407:
URL: https://github.com/apache/beam/pull/12407#issuecomment-666297321
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
damgad commented on pull request #12407:
URL: https://github.com/apache/beam/pull/12407#issuecomment-666303215
Verified that it works as expected:
```
INFO:root:Generating Committers.groovy
INFO:root:70 committers' GitHub usernames fetched correctly
kkucharc commented on pull request #12151:
URL: https://github.com/apache/beam/pull/12151#issuecomment-666319639
Friendly pinging after 3 days @pabloem :)
This is an automated message from the Apache Git Service.
To respond
simonepri opened a new pull request #12421:
URL: https://github.com/apache/beam/pull/12421
The documentation says
> CountElms counts the number of elements in a collection.
> It expects a PCollection as input and returns a PCollection of
**one element** containing the count.
TobKed commented on a change in pull request #12405:
URL: https://github.com/apache/beam/pull/12405#discussion_r462946005
##
File path: CI.md
##
@@ -0,0 +1,104 @@
+
+
+# Apache Beam
+
+## CI Environment
+
+Continuous Integration is important component of making Apache Beam
damgad commented on pull request #12407:
URL: https://github.com/apache/beam/pull/12407#issuecomment-666304130
R: @aaltay @udim
This is an automated message from the Apache Git Service.
To respond to the message, please log
piotr-szuberski commented on pull request #12422:
URL: https://github.com/apache/beam/pull/12422#issuecomment-666312635
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TobKed commented on a change in pull request #12405:
URL: https://github.com/apache/beam/pull/12405#discussion_r462952380
##
File path: CI.md
##
@@ -0,0 +1,104 @@
+
+
+# Apache Beam
+
+## CI Environment
+
+Continuous Integration is important component of making Apache Beam
piotr-szuberski edited a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666279110
@TheNeuralBit Sorry for lots of messages but every day brings something new.
I've managed to modify existing KinesisIOIT to work with localstack (I'll
push
piotr-szuberski commented on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666279110
@TheNeuralBit Sorry for lots of messages but every day brings something new.
I've managed to modify existing KinesisIOIT to work with localstack (I'll
push it in a
piotr-szuberski edited a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666279110
@TheNeuralBit Sorry for lots of messages but every day brings something new.
I've managed to modify existing KinesisIOIT to work with localstack (I'll
push
TobKed commented on pull request #12405:
URL: https://github.com/apache/beam/pull/12405#issuecomment-666329030
@aaltay thanks for review. I fixed typo and replied to your comments.
This is an automated message from the
TobKed commented on a change in pull request #12405:
URL: https://github.com/apache/beam/pull/12405#discussion_r462953052
##
File path: CI.md
##
@@ -0,0 +1,104 @@
+
+
+# Apache Beam
+
+## CI Environment
+
+Continuous Integration is important component of making Apache Beam
DariuszAniszewski commented on pull request #12099:
URL: https://github.com/apache/beam/pull/12099#issuecomment-666260179
Hey @TheNeuralBit @pabloem
The `2.23.0` version is released, so this PR can be merged ;)
This
rworley-monster commented on a change in pull request #12389:
URL: https://github.com/apache/beam/pull/12389#discussion_r462906573
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java
##
@@ -442,6 +450,17 @@
damgad commented on pull request #12407:
URL: https://github.com/apache/beam/pull/12407#issuecomment-666299886
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r462956031
##
File path: release/src/main/scripts/download_github_actions_artifacts.py
##
@@ -170,7 +170,7 @@ def get_last_run_id(
f"GCS location corresponding
TheNeuralBit merged pull request #12399:
URL: https://github.com/apache/beam/pull/12399
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tysonjh commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-666812699
No, my mistake. It fails locally too, I was running it incorrectly.
This is an automated message from the Apache
tysonjh commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-666812322
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ibzib commented on a change in pull request #12385:
URL: https://github.com/apache/beam/pull/12385#discussion_r463345888
##
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##
@@ -53,361 +53,380 @@
from apache_beam.transforms import userstate
from
pabloem commented on pull request #12203:
URL: https://github.com/apache/beam/pull/12203#issuecomment-666851408
only PullLicenses is failing @chamikaramj PTAL
This is an automated message from the Apache Git Service.
To
lostluck merged pull request #12425:
URL: https://github.com/apache/beam/pull/12425
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lostluck closed pull request #12429:
URL: https://github.com/apache/beam/pull/12429
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
TheNeuralBit commented on a change in pull request #12422:
URL: https://github.com/apache/beam/pull/12422#discussion_r463325571
##
File path:
sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/KinesisIOIT.java
##
@@ -34,34 +35,65 @@
import
tysonjh commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-666808017
More test failures. NPEs in what seems like unrelated code, but notably the
pubsub one again which passes locally when I run it for some reason.
chamikaramj commented on a change in pull request #12149:
URL: https://github.com/apache/beam/pull/12149#discussion_r463341503
##
File path: sdks/python/apache_beam/io/external/snowflake.py
##
@@ -0,0 +1,185 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
ibzib commented on a change in pull request #12385:
URL: https://github.com/apache/beam/pull/12385#discussion_r463346402
##
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##
@@ -53,361 +53,380 @@
from apache_beam.transforms import userstate
from
ibzib commented on a change in pull request #12385:
URL: https://github.com/apache/beam/pull/12385#discussion_r463348975
##
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##
@@ -53,361 +53,380 @@
from apache_beam.transforms import userstate
from
ibzib commented on a change in pull request #12385:
URL: https://github.com/apache/beam/pull/12385#discussion_r463348975
##
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##
@@ -53,361 +53,380 @@
from apache_beam.transforms import userstate
from
ibzib commented on pull request #12385:
URL: https://github.com/apache/beam/pull/12385#issuecomment-666850930
> I have already spent a long time trying to fix quotes, so I can't help but
wondering: why do we need flinkCompatibilityMatrixPROCESS in the first place,
when it is not being run
pabloem merged pull request #12082:
URL: https://github.com/apache/beam/pull/12082
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lostluck commented on a change in pull request #12350:
URL: https://github.com/apache/beam/pull/12350#discussion_r462445798
##
File path: sdks/go/pkg/beam/core/runtime/exec/datasource.go
##
@@ -302,31 +308,76 @@ func (n *DataSource) Split(splits []int64, frac float64,
bufSize
kennknowles merged pull request #12387:
URL: https://github.com/apache/beam/pull/12387
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chamikaramj commented on pull request #12198:
URL: https://github.com/apache/beam/pull/12198#issuecomment-666825962
Thanks for clarifying. LGTM.
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #12203:
URL: https://github.com/apache/beam/pull/12203#issuecomment-666858821
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
ZijieSong946 commented on a change in pull request #12348:
URL: https://github.com/apache/beam/pull/12348#discussion_r463375064
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlBeamTranslationUtils.java
##
@@
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r463382501
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -114,55 +115,60 @@
class DicomSearch(PTransform):
"""A PTransform used for
boyuanzz opened a new pull request #12430:
URL: https://github.com/apache/beam/pull/12430
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
simonepri commented on pull request #12429:
URL: https://github.com/apache/beam/pull/12429#issuecomment-666770785
R: @youngoli, @lostluck
Feel free to close it without merging if you don't feel it is needed.
This is
jiyongjung0 commented on pull request #12404:
URL: https://github.com/apache/beam/pull/12404#issuecomment-666770943
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
pabloem commented on pull request #12082:
URL: https://github.com/apache/beam/pull/12082#issuecomment-666774552
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12203:
URL: https://github.com/apache/beam/pull/12203#issuecomment-666830620
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
ibzib commented on pull request #12385:
URL: https://github.com/apache/beam/pull/12385#issuecomment-666846231
> I couldn't find the published test results in Jenkins. Do we have to add
this separately?
https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Commit/6126/
ibzib commented on pull request #12385:
URL: https://github.com/apache/beam/pull/12385#issuecomment-666849394
I got `flinkCompatibilityMatrixPROCESS` to pass on my machine by escaping
the arguments via `${1@Q}`. Apparently whatever shell Jenkins is using does not
support this. I will have
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r463382633
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -372,52 +420,63 @@ def __init__(self, destination_dict, input_type,
credential=None):
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r463382681
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -426,6 +485,44 @@ def process(self, element):
out = {}
out['status'] =
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r463382756
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -372,52 +420,63 @@ def __init__(self, destination_dict, input_type,
credential=None):
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r463383155
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -164,70 +167,109 @@ class DicomSearch(PTransform):
}
"""
- def __init__(self,
lostluck commented on pull request #12429:
URL: https://github.com/apache/beam/pull/12429#issuecomment-666901638
Going to close it, largely because while in terms of Beam Semantics it's
unlikely to trigger, not guarding a divide by zero seems fundamentally wrong.
Something could change
piotr-szuberski commented on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666458687
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit commented on pull request #12099:
URL: https://github.com/apache/beam/pull/12099#issuecomment-666476133
Thanks for the ping! Merging now :)
This is an automated message from the Apache Git Service.
To respond to
mxm commented on a change in pull request #12385:
URL: https://github.com/apache/beam/pull/12385#discussion_r463133822
##
File path: sdks/python/apache_beam/runners/portability/spark_runner_test.py
##
@@ -21,141 +21,158 @@
import argparse
import logging
-import sys
import
1 - 100 of 213 matches
Mail list logo
