kkucharc commented on pull request #12435:
URL: https://github.com/apache/beam/pull/12435#issuecomment-668080152
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
robertwb commented on a change in pull request #12426:
URL: https://github.com/apache/beam/pull/12426#discussion_r464550207
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -855,10 +855,21 @@ message StandardCoders {
// BOOLEAN:
lukecwik merged pull request #12450:
URL: https://github.com/apache/beam/pull/12450
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
amaliujia merged pull request #12232:
URL: https://github.com/apache/beam/pull/12232
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
boyuanzz commented on pull request #10375:
URL: https://github.com/apache/beam/pull/10375#issuecomment-668124211
> Excellent. I've been reading the example. Thank you.
> I have a follow on question, but that might be better asked on
Stackoverflow instead. Thanks
You can also post
aaltay merged pull request #12405:
URL: https://github.com/apache/beam/pull/12405
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robertwb commented on a change in pull request #12391:
URL: https://github.com/apache/beam/pull/12391#discussion_r464538362
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -2118,8 +2113,8 @@ public TimeDomain timeDomain(DoFn
robertwb commented on pull request #12185:
URL: https://github.com/apache/beam/pull/12185#issuecomment-668132171
@yifanmai could we get the combine fn packing stuff in this PR, and we can
defer the sibling deduplication to a subsequent one?
kanterov commented on pull request #12456:
URL: https://github.com/apache/beam/pull/12456#issuecomment-668145076
R: @TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message, please
kanterov opened a new pull request #12456:
URL: https://github.com/apache/beam/pull/12456
Schema#indexOf uses String.format to prepare error message.
It causes performance issues if schema has options, because
Schema.Options#toString allocates TreeMap.
Use formatter built-in
robertwb commented on a change in pull request #12426:
URL: https://github.com/apache/beam/pull/12426#discussion_r464554560
##
File path: sdks/python/apache_beam/coders/coder_impl.py
##
@@ -530,6 +530,88 @@ def estimate_size(self, unused_value, nested=False):
return 1
aaltay commented on a change in pull request #12455:
URL: https://github.com/apache/beam/pull/12455#discussion_r464570198
##
File path: website/www/site/content/en/contribute/release-guide.md
##
@@ -244,7 +247,21 @@ __Attention__: Only PMC has permission to perform this. If
kkucharc commented on pull request #12435:
URL: https://github.com/apache/beam/pull/12435#issuecomment-668081551
Run Python Load Tests ParDo Flink Streaming
This is an automated message from the Apache Git Service.
To
kkucharc commented on pull request #12435:
URL: https://github.com/apache/beam/pull/12435#issuecomment-668081268
Run Python Load Tests ParDo Dataflow Batch
This is an automated message from the Apache Git Service.
To respond
mayket04 commented on pull request #10375:
URL: https://github.com/apache/beam/pull/10375#issuecomment-668093320
Excellent. I've been reading the example. Thank you.
I have a follow on question, but that might be better asked on Stackoverflow
instead. Thanks
aromanenko-dev commented on a change in pull request #12397:
URL: https://github.com/apache/beam/pull/12397#discussion_r464504070
##
File path: website/www/site/content/en/get-started/wordcount-example.md
##
@@ -387,18 +387,20 @@ python -m apache_beam.examples.wordcount
aromanenko-dev commented on a change in pull request #12397:
URL: https://github.com/apache/beam/pull/12397#discussion_r464504070
##
File path: website/www/site/content/en/get-started/wordcount-example.md
##
@@ -387,18 +387,20 @@ python -m apache_beam.examples.wordcount
amaliujia closed pull request #12398:
URL: https://github.com/apache/beam/pull/12398
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
robertwb merged pull request #12447:
URL: https://github.com/apache/beam/pull/12447
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ibzib commented on a change in pull request #12397:
URL: https://github.com/apache/beam/pull/12397#discussion_r464552462
##
File path: website/www/site/content/en/get-started/wordcount-example.md
##
@@ -387,18 +387,20 @@ python -m apache_beam.examples.wordcount --input
amaliujia commented on pull request #12436:
URL: https://github.com/apache/beam/pull/12436#issuecomment-668151777
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
lukecwik commented on a change in pull request #12371:
URL: https://github.com/apache/beam/pull/12371#discussion_r464580334
##
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/SplittableParDoExpander.java
##
@@ -214,39
Mark-Zeng commented on a change in pull request #12232:
URL: https://github.com/apache/beam/pull/12232#discussion_r464337264
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/cep/CEPCall.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to
mwalenia opened a new pull request #12453:
URL: https://github.com/apache/beam/pull/12453
This is a followup to https://github.com/apache/beam/pull/11776
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
mwalenia commented on pull request #12453:
URL: https://github.com/apache/beam/pull/12453#issuecomment-668049303
R: @aaltay can you take a look at this?
This is an automated message from the Apache Git Service.
To respond to
KevinGG commented on pull request #12442:
URL: https://github.com/apache/beam/pull/12442#issuecomment-668111228
R: @pabloem
PTAL, thx!
This is an automated message from the Apache Git Service.
To respond to the
lazylynx commented on a change in pull request #12239:
URL: https://github.com/apache/beam/pull/12239#discussion_r464536071
##
File path: sdks/python/test-suites/dataflow/build.gradle
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
robertwb commented on a change in pull request #12440:
URL: https://github.com/apache/beam/pull/12440#discussion_r464566521
##
File path: sdks/python/apache_beam/dataframe/doctests.py
##
@@ -290,34 +298,60 @@ def to_callable(cond):
super(BeamDataframeDoctestRunner,
lazylynx commented on a change in pull request #12239:
URL: https://github.com/apache/beam/pull/12239#discussion_r464534655
##
File path: sdks/python/test-suites/dataflow/py37/build.gradle
##
@@ -20,10 +20,6 @@ apply plugin: org.apache.beam.gradle.BeamModulePlugin
robertwb commented on a change in pull request #12426:
URL: https://github.com/apache/beam/pull/12426#discussion_r464556809
##
File path: sdks/python/apache_beam/coders/coder_impl.py
##
@@ -530,6 +530,88 @@ def estimate_size(self, unused_value, nested=False):
return 1
amaliujia commented on pull request #12232:
URL: https://github.com/apache/beam/pull/12232#issuecomment-668147610
Interesting. I used the squash and merge button but it seems just create a
merge pull request. It might not matter that much.
saavannanavati commented on pull request #12242:
URL: https://github.com/apache/beam/pull/12242#issuecomment-668157896
R: @udim
R: @robertwb
PTAL - this is ready for review
This is an automated message from the
lazylynx commented on a change in pull request #12239:
URL: https://github.com/apache/beam/pull/12239#discussion_r464532005
##
File path: build.gradle
##
@@ -243,13 +241,16 @@ task pythonFormatterPreCommit() {
dependsOn 'sdks:python:test-suites:tox:py38:formatter'
}
chamikaramj commented on a change in pull request #12403:
URL: https://github.com/apache/beam/pull/12403#discussion_r464549909
##
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchModeExecutionContext.java
##
@@
davidcavazos commented on a change in pull request #12437:
URL: https://github.com/apache/beam/pull/12437#discussion_r464553800
##
File path:
website/www/site/content/en/documentation/transforms/python/aggregation/mean.md
##
@@ -16,23 +16,64 @@ limitations under the License.
amaliujia commented on a change in pull request #12436:
URL: https://github.com/apache/beam/pull/12436#discussion_r464567320
##
File path: settings.gradle
##
@@ -179,3 +179,4 @@ include "beam-test-tools"
project(":beam-test-tools").dir = file(".test-infra/tools")
include
rosetn commented on pull request #12437:
URL: https://github.com/apache/beam/pull/12437#issuecomment-668165492
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kkucharc commented on pull request #12149:
URL: https://github.com/apache/beam/pull/12149#issuecomment-668082016
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
piotr-szuberski commented on pull request #12325:
URL: https://github.com/apache/beam/pull/12325#issuecomment-668082714
@ihji @chamikaramj ping
This is an automated message from the Apache Git Service.
To respond to the
sclukas77 opened a new pull request #12454:
URL: https://github.com/apache/beam/pull/12454
Rely on instances of ExternalTransformBuilder rather than on class objects
in ExternalTransformBuilder. This is in anticipation of implementing cross
language transforms using the SchemaIOProvider
piotr-szuberski edited a comment on pull request #12423:
URL: https://github.com/apache/beam/pull/12423#issuecomment-667916022
> "During writing kinesis for cross-language it was suggested to emplace all
classes connected to cross-language in one file"
>
> I think Java generally
piotr-szuberski edited a comment on pull request #12423:
URL: https://github.com/apache/beam/pull/12423#issuecomment-667916022
> "During writing kinesis for cross-language it was suggested to emplace all
classes connected to cross-language in one file"
>
> I think Java generally
mxm opened a new pull request #12455:
URL: https://github.com/apache/beam/pull/12455
In the past, we have seen performance regressions in releases. We should make
sure that the release guide includes checking available performance
measurements.
Post-Commit Tests Status (on
lazylynx commented on pull request #12239:
URL: https://github.com/apache/beam/pull/12239#issuecomment-668129012
@tvalentyn Thank you for detail comments.
I made codes to just refactor current tests. PTAL.
This is an
davidcavazos opened a new pull request #12457:
URL: https://github.com/apache/beam/pull/12457
Add `Min` code snippets.
R: @aaltay
R: @rosetn
Staged:
amaliujia commented on pull request #12436:
URL: https://github.com/apache/beam/pull/12436#issuecomment-668151996
Run Spotless PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
boyuanzz commented on pull request #12430:
URL: https://github.com/apache/beam/pull/12430#issuecomment-668168142
Currently `Truncate` didn't report progress via
`addProgressRequestCallback`. It would result in incorrect progress when
`Truncate` observing windows. If `Truncate` reports
TobKed commented on pull request #12452:
URL: https://github.com/apache/beam/pull/12452#issuecomment-668023282
example run executed on my fork (all jobs)
This is an automated message from the Apache Git Service.
To respond
TobKed edited a comment on pull request #12452:
URL: https://github.com/apache/beam/pull/12452#issuecomment-668023282
example run executed on my fork (all jobs):
https://github.com/TobKed/beam/actions/runs/193255595
This
kkucharc commented on pull request #12435:
URL: https://github.com/apache/beam/pull/12435#issuecomment-668043676
Run Python Load Tests ParDo Dataflow Streaming
This is an automated message from the Apache Git Service.
To
mxm edited a comment on pull request #12451:
URL: https://github.com/apache/beam/pull/12451#issuecomment-667946121
Indeed, this fixes the issue:
mxm commented on pull request #12451:
URL: https://github.com/apache/beam/pull/12451#issuecomment-667946121
Indeed, this fixes the issue:
kkucharc commented on pull request #12435:
URL: https://github.com/apache/beam/pull/12435#issuecomment-667950842
Run Python Load Tests ParDo Dataflow Streaming
This is an automated message from the Apache Git Service.
To
kkucharc commented on pull request #12435:
URL: https://github.com/apache/beam/pull/12435#issuecomment-667950590
Run Python Load Tests ParDo Flink Streaming
This is an automated message from the Apache Git Service.
To
kkucharc commented on pull request #12435:
URL: https://github.com/apache/beam/pull/12435#issuecomment-667984682
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TobKed commented on pull request #12452:
URL: https://github.com/apache/beam/pull/12452#issuecomment-668016443
R: @aaltay @tvalentyn @kamilwu @damgad @potiuk
This is an automated message from the Apache Git Service.
To
TobKed closed pull request #12318:
URL: https://github.com/apache/beam/pull/12318
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
TobKed commented on pull request #12318:
URL: https://github.com/apache/beam/pull/12318#issuecomment-668016046
@aaltay @tvalentyn thank you for reviews.
I thought it over and decided to divide it into two PRs, separate for python
and for java.
Also keeping these workflows in separate
kkucharc commented on pull request #12435:
URL: https://github.com/apache/beam/pull/12435#issuecomment-668038221
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
viktorjonsson opened a new pull request #12450:
URL: https://github.com/apache/beam/pull/12450
Link to S3FileSystemRegistrar was incorrectly pointing at the Hadoop
filesystem package.
**Please** add a meaningful description for your change here
kkucharc commented on pull request #12435:
URL: https://github.com/apache/beam/pull/12435#issuecomment-667948244
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mxm commented on pull request #12449:
URL: https://github.com/apache/beam/pull/12449#issuecomment-667986746
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log
mxm opened a new pull request #12449:
URL: https://github.com/apache/beam/pull/12449
When using the FlinkRunner with master, the job server needs to be build
first. Beam prints out instructions for that, e.g.
```
RuntimeError:
Mark-Zeng commented on a change in pull request #12232:
URL: https://github.com/apache/beam/pull/12232#discussion_r464338700
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/cep/CEPUtil.java
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to
kkucharc commented on pull request #12149:
URL: https://github.com/apache/beam/pull/12149#issuecomment-668057340
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
echauchot commented on pull request #12432:
URL: https://github.com/apache/beam/pull/12432#issuecomment-667912069
@aaltay thanks ! fixed forgotten checkstyle. Waiting for green light to self
merge
This is an automated
echauchot commented on pull request #12432:
URL: https://github.com/apache/beam/pull/12432#issuecomment-667923980
Run Spotless PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
mxm commented on pull request #12451:
URL: https://github.com/apache/beam/pull/12451#issuecomment-667943812
I'm merging to see if that resolves the problem. Locally with the backup
data it worked.
CC @kamilwu @mwalenia
mxm merged pull request #12451:
URL: https://github.com/apache/beam/pull/12451
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kkucharc commented on pull request #12149:
URL: https://github.com/apache/beam/pull/12149#issuecomment-668031568
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
mwalenia commented on pull request #12453:
URL: https://github.com/apache/beam/pull/12453#issuecomment-668052572
Changes preview:
https://apache-beam-website-pull-requests.storage.googleapis.com/12453/documentation/patterns/ai-platform/index.html
davidak09 commented on a change in pull request #12050:
URL: https://github.com/apache/beam/pull/12050#discussion_r464331768
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/io/DefaultFilenamePolicy.java
##
@@ -182,19 +184,26 @@ public void encode(Params value,
Mark-Zeng commented on a change in pull request #12232:
URL: https://github.com/apache/beam/pull/12232#discussion_r464339127
##
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamMatchRelTest.java
##
@@ -0,0 +1,234 @@
+/*
+ *
echauchot merged pull request #12432:
URL: https://github.com/apache/beam/pull/12432
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
TobKed opened a new pull request #12452:
URL: https://github.com/apache/beam/pull/12452
## **Before merging it is required to setup related secrets:**
* `GCP_PROJECT_ID` - ID of the Google Cloud project e.g: apache-beam-testing
* `GCP_BUCKET` - beam-wheels-staging
*
piotr-szuberski commented on pull request #12423:
URL: https://github.com/apache/beam/pull/12423#issuecomment-667916022
> "During writing kinesis for cross-language it was suggested to emplace all
classes connected to cross-language in one file"
>
> I think Java generally recommends
TheNeuralBit commented on pull request #12454:
URL: https://github.com/apache/beam/pull/12454#issuecomment-668206369
Run XVR_Flink PostCommit
This is an automated message from the Apache Git Service.
To respond to the
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r464632452
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -0,0 +1,572 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
robertwb merged pull request #12391:
URL: https://github.com/apache/beam/pull/12391
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robertwb commented on pull request #12391:
URL: https://github.com/apache/beam/pull/12391#issuecomment-668214822
The one failure looks like BEAM-10252.
This is an automated message from the Apache Git Service.
To respond to
pabloem commented on a change in pull request #12339:
URL: https://github.com/apache/beam/pull/12339#discussion_r464650111
##
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##
@@ -364,26 +382,37 @@ def get_background_caching_job(self,
lukecwik commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r464651698
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -515,15 +515,18 @@
&&
boyuanzz commented on pull request #11749:
URL: https://github.com/apache/beam/pull/11749#issuecomment-668251029
Based on the [readAll
discussion](https://lists.apache.org/thread.html/rcb7538d5a2955d12e6d5f37a24830b929e5d65155d84f6d999801432%40%3Cdev.beam.apache.org%3E),
I decided to go
robertwb commented on pull request #12459:
URL: https://github.com/apache/beam/pull/12459#issuecomment-668251189
R: @apilloud
This is an automated message from the Apache Git Service.
To respond to the message, please log on
apilloud commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-668260372
LGTM. There is a script `sdks/java/build-tools/beam-linkage-check.sh` that
is suppose to validate version changes don't introduce new compatibility
issues. Can you run it and
lukecwik commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r464699501
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1035,6 +1046,130 @@ private Progress getProgress()
lukecwik commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r464699157
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1035,6 +1046,130 @@ private Progress getProgress()
danielxjd commented on a change in pull request #12223:
URL: https://github.com/apache/beam/pull/12223#discussion_r464701869
##
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##
@@ -230,12 +281,271 @@ public ReadFiles
KevinGG commented on pull request #12444:
URL: https://github.com/apache/beam/pull/12444#issuecomment-668183158
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
KevinGG commented on pull request #12444:
URL: https://github.com/apache/beam/pull/12444#issuecomment-668183021
> LGTM. Would it make sense to announce this on the dev@ list? Or do you
think this is will sufficiently have minimal impact.
Once we merge it, I'll check if new PRs would
KevinGG commented on pull request #12444:
URL: https://github.com/apache/beam/pull/12444#issuecomment-668183674
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
robertwb commented on pull request #12391:
URL: https://github.com/apache/beam/pull/12391#issuecomment-668213773
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
tysonjh commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-668212843
R: @apilloud
Could you take a look at this please?
This is an automated message from the Apache Git
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r464636772
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -0,0 +1,572 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
lostluck commented on a change in pull request #12426:
URL: https://github.com/apache/beam/pull/12426#discussion_r464647966
##
File path: sdks/python/apache_beam/coders/coder_impl.py
##
@@ -530,6 +530,88 @@ def estimate_size(self, unused_value, nested=False):
return 1
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r464632452
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -0,0 +1,572 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
amaliujia merged pull request #12436:
URL: https://github.com/apache/beam/pull/12436
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pabloem commented on pull request #12331:
URL: https://github.com/apache/beam/pull/12331#issuecomment-668233131
LGTM. I'll merge once tests pass.
This is an automated message from the Apache Git Service.
To respond to the
KevinGG commented on a change in pull request #12339:
URL: https://github.com/apache/beam/pull/12339#discussion_r464657824
##
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##
@@ -364,26 +382,37 @@ def get_background_caching_job(self,
chamikaramj commented on pull request #12071:
URL: https://github.com/apache/beam/pull/12071#issuecomment-668237855
Seems like commit history got messed up.
This is an automated message from the Apache Git Service.
To
1 - 100 of 163 matches
Mail list logo
