[GitHub] [beam] chamikaramj merged pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

chamikaramj merged pull request #12656: URL: https://github.com/apache/beam/pull/12656 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] youngoli commented on pull request #12845: [BEAM-6928] Update changelog with WriteToBigQuery changed requirements.

youngoli commented on pull request #12845: URL: https://github.com/apache/beam/pull/12845#issuecomment-692466752 R: @pabloem @chamikaramj I tested this fix and confirmed that it works in #12792 This is an automated

[GitHub] [beam] youngoli opened a new pull request #12845: [BEAM-6928] Update changelog with WriteToBigQuery changed requirements.

youngoli opened a new pull request #12845: URL: https://github.com/apache/beam/pull/12845 Also update a test in the release validation script. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and

[GitHub] [beam] chamikaramj commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

chamikaramj commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-692443824 PreCommit test suite passed and macos failure seems to be unrelated - https://issues.apache.org/jira/browse/BEAM-10866.

[GitHub] [beam] codecov[bot] commented on pull request #12845: [BEAM-6928] Update changelog with WriteToBigQuery changed requirements.

codecov[bot] commented on pull request #12845: URL: https://github.com/apache/beam/pull/12845#issuecomment-692472368 # [Codecov](https://codecov.io/gh/apache/beam/pull/12845?src=pr=h1) Report > Merging [#12845](https://codecov.io/gh/apache/beam/pull/12845?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12845: [BEAM-6928] Update changelog with WriteToBigQuery changed requirements.

codecov[bot] edited a comment on pull request #12845: URL: https://github.com/apache/beam/pull/12845#issuecomment-692472368 # [Codecov](https://codecov.io/gh/apache/beam/pull/12845?src=pr=h1) Report > Merging [#12845](https://codecov.io/gh/apache/beam/pull/12845?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12845: [BEAM-6928] Update changelog with WriteToBigQuery changed requirements.

codecov[bot] edited a comment on pull request #12845: URL: https://github.com/apache/beam/pull/12845#issuecomment-692472368 # [Codecov](https://codecov.io/gh/apache/beam/pull/12845?src=pr=h1) Report > Merging [#12845](https://codecov.io/gh/apache/beam/pull/12845?src=pr=desc) into

[GitHub] [beam] scwhittle commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

scwhittle commented on pull request #12825: URL: https://github.com/apache/beam/pull/12825#issuecomment-691867771 I am only changing how errors from within the DataflowWorkerLoggingHandler itself are reported, for example an error publishing to stackdriver. I agree that logging to stderr

[GitHub] [beam] rworley-monster commented on a change in pull request #12367: [BEAM-10564] Support more Avro field name formats when mapping to Jav…

rworley-monster commented on a change in pull request #12367: URL: https://github.com/apache/beam/pull/12367#discussion_r487819806 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java ## @@ -601,12 +601,26 @@ private void

[GitHub] [beam] piotr-szuberski opened a new pull request #12839: [BEAM-10893] Add Json support to Kafka Table Provider

piotr-szuberski opened a new pull request #12839: URL: https://github.com/apache/beam/pull/12839 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] piotr-szuberski commented on pull request #12839: [BEAM-10893] Add Json support to Kafka Table Provider

piotr-szuberski commented on pull request #12839: URL: https://github.com/apache/beam/pull/12839#issuecomment-692057876 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] piotr-szuberski commented on pull request #12838: [BEAM-10892] Add Proto support to Kafka Table Provider

piotr-szuberski commented on pull request #12838: URL: https://github.com/apache/beam/pull/12838#issuecomment-692058196 @TheNeuralBit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] piotr-szuberski commented on pull request #12838: [BEAM-10892] Add Proto support to Kafka Table Provider

piotr-szuberski commented on pull request #12838: URL: https://github.com/apache/beam/pull/12838#issuecomment-692057621 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] runningcode opened a new pull request #12840: [BEAM-10886] Also publish build scans from Github actions.

runningcode opened a new pull request #12840: URL: https://github.com/apache/beam/pull/12840 This will help in investigating the issue in the failing build on windows and other future Github Actions failures. Thank you for your contribution! Follow

[GitHub] [beam] pabloem commented on pull request #12779: [BEAM-10856] Support for NestedValueProvider for Python SDK

pabloem commented on pull request #12779: URL: https://github.com/apache/beam/pull/12779#issuecomment-692107896 A user has written a feature that they would find useful, and that will not change the experience for other users (if anything, it should improve it). The feature looks correct,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12731: [BEAM-10830] Twister2 quickstarts and the runner maven archetypes

codecov[bot] edited a comment on pull request #12731: URL: https://github.com/apache/beam/pull/12731#issuecomment-683376404 # [Codecov](https://codecov.io/gh/apache/beam/pull/12731?src=pr=h1) Report > Merging [#12731](https://codecov.io/gh/apache/beam/pull/12731?src=pr=desc) into

[GitHub] [beam] piotr-szuberski opened a new pull request #12838: [BEAM-10892] Add Proto support to Kafka Table Provider

piotr-szuberski opened a new pull request #12838: URL: https://github.com/apache/beam/pull/12838 Added support for protocol buffers to Kafka Table Providers Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] piotr-szuberski commented on pull request #12827: [BEAM-10885] Add Avro support to Kafka table provider

piotr-szuberski commented on pull request #12827: URL: https://github.com/apache/beam/pull/12827#issuecomment-692003556 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] rezarokni commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

rezarokni commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r487899783 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/contextualtextio/RecordWithMetadata.java ## @@ -0,0 +1,84 @@ +/* + *

[GitHub] [beam] piotr-szuberski commented on pull request #12827: [BEAM-10885] Add Avro support to Kafka table provider

piotr-szuberski commented on pull request #12827: URL: https://github.com/apache/beam/pull/12827#issuecomment-692058121 @TheNeuralBit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] piotr-szuberski commented on pull request #12839: [BEAM-10893] Add Json support to Kafka Table Provider

piotr-szuberski commented on pull request #12839: URL: https://github.com/apache/beam/pull/12839#issuecomment-692058319 @TheNeuralBit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem merged pull request #12686: Removing dead code from Interactive Beam.

pabloem merged pull request #12686: URL: https://github.com/apache/beam/pull/12686 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #12686: Removing dead code from Interactive Beam.

pabloem commented on pull request #12686: URL: https://github.com/apache/beam/pull/12686#issuecomment-692088106 Thanks @KevinGG @qinyeli ! We can merge as is. This is an automated message from the Apache Git Service. To

[GitHub] [beam] pabloem commented on pull request #12721: [BEAM-10871] Add deidentify for FhirIO connector

pabloem commented on pull request #12721: URL: https://github.com/apache/beam/pull/12721#issuecomment-692081450 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] piotr-szuberski commented on pull request #12838: [BEAM-10892] Add Proto support to Kafka Table Provider

piotr-szuberski commented on pull request #12838: URL: https://github.com/apache/beam/pull/12838#issuecomment-692003648 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] rezarokni commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

rezarokni commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r487897086 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/contextualtextio/ContextualTextIOSource.java ## @@ -0,0 +1,364 @@

[GitHub] [beam] iemejia merged pull request #12744: [BEAM-10463] Twister2 Beam Runner Documentation

iemejia merged pull request #12744: URL: https://github.com/apache/beam/pull/12744 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] rezarokni commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

rezarokni commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r487927710 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/contextualtextio/RecordWithMetadata.java ## @@ -0,0 +1,84 @@ +/* + *

[GitHub] [beam] rezarokni commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

rezarokni commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r487934071 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/contextualtextio/ContextualTextIO.java ## @@ -0,0 +1,631 @@ +/* + *

[GitHub] [beam] rezarokni commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

rezarokni commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r487933083 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/contextualtextio/ContextualTextIO.java ## @@ -0,0 +1,631 @@ +/* + *

[GitHub] [beam] iemejia commented on a change in pull request #12731: [BEAM-10830] Twister2 quickstarts and the runner maven archetypes

iemejia commented on a change in pull request #12731: URL: https://github.com/apache/beam/pull/12731#discussion_r487696110 ## File path: runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2PipelineResult.java ## @@ -17,15 +17,21 @@ */ package

[GitHub] [beam] iemejia merged pull request #12731: [BEAM-10830] Twister2 quickstarts and the runner maven archetypes

iemejia merged pull request #12731: URL: https://github.com/apache/beam/pull/12731 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] iemejia commented on pull request #12731: [BEAM-10830] Twister2 quickstarts and the runner maven archetypes

iemejia commented on pull request #12731: URL: https://github.com/apache/beam/pull/12731#issuecomment-692041712 Run Twister2 ValidatesRunner This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] rezarokni commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

rezarokni commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r487927710 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/contextualtextio/RecordWithMetadata.java ## @@ -0,0 +1,84 @@ +/* + *

[GitHub] [beam] piotr-szuberski commented on pull request #12827: [BEAM-10885] Add Avro support to Kafka table provider

piotr-szuberski commented on pull request #12827: URL: https://github.com/apache/beam/pull/12827#issuecomment-692062465 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #12813: write to file ability for java suite

pabloem commented on pull request #12813: URL: https://github.com/apache/beam/pull/12813#issuecomment-692116395 this LGTM. Waiting for @y1chi if he has any comments : ) This is an automated message from the Apache Git

[GitHub] [beam] kennknowles merged pull request #12840: [BEAM-10886] Also publish build scans from Github actions.

kennknowles merged pull request #12840: URL: https://github.com/apache/beam/pull/12840 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] lukecwik commented on pull request #12616: [BEAM-10670] Update Jet to be opt-out for SplittableDoFn powering the Read transform.

lukecwik commented on pull request #12616: URL: https://github.com/apache/beam/pull/12616#issuecomment-692196137 > What kind of test coverage is there for these transform replacements on the Jet runner? The `@ValidatesRunner` junit category gives us coverage. The `@ValidatesRunner`

[GitHub] [beam] kennknowles commented on a change in pull request #12540: [BEAM-10620] Eliminate nullability errors from :sdks:java:extensions:sql:perf-tests

kennknowles commented on a change in pull request #12540: URL: https://github.com/apache/beam/pull/12540#discussion_r488104689 ## File path: sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/IOTestPipelineOptions.java ## @@ -45,19 +45,16 @@ void

[GitHub] [beam] rworley-monster commented on pull request #12367: [BEAM-10564] Support more Avro field name formats when mapping to Jav…

rworley-monster commented on pull request #12367: URL: https://github.com/apache/beam/pull/12367#issuecomment-692166530 I have looked into both of the failing checks and the first appears to be a syntax error in `beam\examples\java\build.gradle` and the second I am not able to reproduce

[GitHub] [beam] lukecwik commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

lukecwik commented on pull request #12825: URL: https://github.com/apache/beam/pull/12825#issuecomment-692173705 @scwhittle I see how the deadlock occurs but why introduce the synchronized(buffer) if we are swapping out the error manager? Also, wouldn't we solve the locking

[GitHub] [beam] codecov[bot] edited a comment on pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

codecov[bot] edited a comment on pull request #12811: URL: https://github.com/apache/beam/pull/12811#issuecomment-690521374 # [Codecov](https://codecov.io/gh/apache/beam/pull/12811?src=pr=h1) Report > Merging [#12811](https://codecov.io/gh/apache/beam/pull/12811?src=pr=desc) into

[GitHub] [beam] pabloem commented on pull request #12721: [BEAM-10871] Add deidentify for FhirIO connector

pabloem commented on pull request #12721: URL: https://github.com/apache/beam/pull/12721#issuecomment-692114831 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] yifanmai commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

yifanmai commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-692172601 The failures are on `DataChannelTest.test_time_based_flush_grpc_data_channel` which does not seem related to the PR. @chamikaramj is this ready for merge or is there more

[GitHub] [beam] y1chi commented on pull request #12807: [BEAM-2855] implement query 10

y1chi commented on pull request #12807: URL: https://github.com/apache/beam/pull/12807#issuecomment-692203332 @pabloem Pablo could you help merge this? This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] lukecwik commented on pull request #12367: [BEAM-10564] Support more Avro field name formats when mapping to Jav…

lukecwik commented on pull request #12367: URL: https://github.com/apache/beam/pull/12367#issuecomment-692185073 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] nehsyc commented on pull request #12726: [BEAM-10475] Add max buffering duration to GroupIntoBatches (Java)

nehsyc commented on pull request #12726: URL: https://github.com/apache/beam/pull/12726#issuecomment-692200394 > Please fix spotlessCheck and squash all commits into me. Then I can merge it. Thanks! Done. Thanks!

[GitHub] [beam] boyuanzz commented on pull request #12773: [BEAM-10505][BEAM-10530] Add truncate capability.

boyuanzz commented on pull request #12773: URL: https://github.com/apache/beam/pull/12773#issuecomment-692206185 Kindly pinging : ) This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] boyuanzz commented on pull request #12806: [BEAM-10869] Use PubsubMessagePayloadOnlyCoder when writing to Pubsub.

boyuanzz commented on pull request #12806: URL: https://github.com/apache/beam/pull/12806#issuecomment-692206454 Kindly pinging : ) This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on pull request #12367: [BEAM-10564] Support more Avro field name formats when mapping to Jav…

lukecwik commented on pull request #12367: URL: https://github.com/apache/beam/pull/12367#issuecomment-692210480 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12808: add readme file to python nexmark

pabloem commented on pull request #12808: URL: https://github.com/apache/beam/pull/12808#issuecomment-692113058 This looks fine to me. I'd rather it be more hand-holdy, but it has the commands we need, and Leiyi is done with internship, so I'm happy to merge. LMK what you think @y1chi

[GitHub] [beam] y1chi commented on pull request #12808: add readme file to python nexmark

y1chi commented on pull request #12808: URL: https://github.com/apache/beam/pull/12808#issuecomment-692169272 > This looks fine to me. I'd rather it be more hand-holdy, but it has the commands we need, and Leiyi is done with internship, so I'm happy to merge. LMK what you think @y1chi

[GitHub] [beam] robertwb commented on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

robertwb commented on pull request #12841: URL: https://github.com/apache/beam/pull/12841#issuecomment-692174531 R: @chamikaramj This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] robertwb opened a new pull request #12841: [BEAM-10894] Basic CSV reading and writing.

robertwb opened a new pull request #12841: URL: https://github.com/apache/beam/pull/12841 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] lukecwik commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

lukecwik commented on pull request #12825: URL: https://github.com/apache/beam/pull/12825#issuecomment-692175069 @kennknowles `system.err` is always intended to log at ERROR level. Are you saying that logging is being misconfigured somehow and logs for other severities are being sent to

[GitHub] [beam] lukecwik commented on a change in pull request #12616: [BEAM-10670] Update Jet to be opt-out for SplittableDoFn powering the Read transform.

lukecwik commented on a change in pull request #12616: URL: https://github.com/apache/beam/pull/12616#discussion_r488095723 ## File path: runners/jet/src/main/java/org/apache/beam/runners/jet/JetRunner.java ## @@ -186,7 +189,15 @@ private JetInstance

[GitHub] [beam] boyuanzz commented on pull request #12726: [BEAM-10475] Add max buffering duration to GroupIntoBatches (Java)

boyuanzz commented on pull request #12726: URL: https://github.com/apache/beam/pull/12726#issuecomment-692205395 Run Dataflow ValidatesRunner This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

codecov[bot] edited a comment on pull request #12811: URL: https://github.com/apache/beam/pull/12811#issuecomment-690521374 # [Codecov](https://codecov.io/gh/apache/beam/pull/12811?src=pr=h1) Report > Merging [#12811](https://codecov.io/gh/apache/beam/pull/12811?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

codecov[bot] edited a comment on pull request #12811: URL: https://github.com/apache/beam/pull/12811#issuecomment-690521374 # [Codecov](https://codecov.io/gh/apache/beam/pull/12811?src=pr=h1) Report > Merging [#12811](https://codecov.io/gh/apache/beam/pull/12811?src=pr=desc) into

[GitHub] [beam] kennknowles commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

kennknowles commented on pull request #12825: URL: https://github.com/apache/beam/pull/12825#issuecomment-692236055 @lukecwik that is how I feel about System.err as well. Java disagrees and writes all logs to stderr unless you disconnect that. IIRC I discovered through some other work

[GitHub] [beam] tvalentyn commented on pull request #12833: Updates Dataflow containers used by unreleased SDKs.

tvalentyn commented on pull request #12833: URL: https://github.com/apache/beam/pull/12833#issuecomment-692261224 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] kennknowles commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

kennknowles commented on pull request #12825: URL: https://github.com/apache/beam/pull/12825#issuecomment-692268316 Had a chat and we confirmed that the worker logging setup already handles my concern appropriately. Please disregard all comments.

[GitHub] [beam] lukecwik commented on pull request #12794: [BEAM-10865] Support for Kafka deserialization API with headers (since Kafka API 2.1.0)

lukecwik commented on pull request #12794: URL: https://github.com/apache/beam/pull/12794#issuecomment-692278596 Waiting on tests that use Kafka 2.1.0 explicitly as described in my first review. This is an automated message

[GitHub] [beam] boyuanzz commented on pull request #12726: [BEAM-10475] Add max buffering duration to GroupIntoBatches (Java)

boyuanzz commented on pull request #12726: URL: https://github.com/apache/beam/pull/12726#issuecomment-692291612 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] qinyeli commented on pull request #12686: Removing dead code from Interactive Beam.

qinyeli commented on pull request #12686: URL: https://github.com/apache/beam/pull/12686#issuecomment-692296995 Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] lukecwik merged pull request #12773: [BEAM-10505][BEAM-10530] Add truncate capability.

lukecwik merged pull request #12773: URL: https://github.com/apache/beam/pull/12773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

codecov[bot] edited a comment on pull request #12811: URL: https://github.com/apache/beam/pull/12811#issuecomment-690521374 # [Codecov](https://codecov.io/gh/apache/beam/pull/12811?src=pr=h1) Report > Merging [#12811](https://codecov.io/gh/apache/beam/pull/12811?src=pr=desc) into

[GitHub] [beam] NikeNano commented on pull request #12842: Update quickstart-java.md to used -P correctly in the documentations.

NikeNano commented on pull request #12842: URL: https://github.com/apache/beam/pull/12842#issuecomment-692302200 R: @iemejia This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] emilymye commented on pull request #12505: [WIP][BEAM-8106] Add version to java container image name

emilymye commented on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-692228990 run java postcommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] codecov[bot] edited a comment on pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

codecov[bot] edited a comment on pull request #12811: URL: https://github.com/apache/beam/pull/12811#issuecomment-690521374 # [Codecov](https://codecov.io/gh/apache/beam/pull/12811?src=pr=h1) Report > Merging [#12811](https://codecov.io/gh/apache/beam/pull/12811?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12505: [WIP][BEAM-8106] Add version to java container image name

codecov[bot] edited a comment on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-684502100 # [Codecov](https://codecov.io/gh/apache/beam/pull/12505?src=pr=h1) Report > Merging [#12505](https://codecov.io/gh/apache/beam/pull/12505?src=pr=desc) into

[GitHub] [beam] scwhittle commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

scwhittle commented on pull request #12825: URL: https://github.com/apache/beam/pull/12825#issuecomment-692275145 @lukecwik I think to have a single lock, we would need to use the PrintStream lock itself, as that is what is synchronized on by Throwable.printStackTrace and which can be

[GitHub] [beam] NikeNano opened a new pull request #12842: Update quickstart-java.md to used -P correctly in the documentations in "Getting started Java"

NikeNano opened a new pull request #12842: URL: https://github.com/apache/beam/pull/12842 Update to clarify that the `-P` is used for maven. **Please** add a meaningful description for your change here Thank you for your contribution! Follow

[GitHub] [beam] lukecwik commented on a change in pull request #12836: [BEAM-10887] Expose clear() to FnApiTimer.

lukecwik commented on a change in pull request #12836: URL: https://github.com/apache/beam/pull/12836#discussion_r488206104 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/state/Timer.java ## @@ -81,6 +81,9 @@ */ void setRelative(); + /** Clears the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12834: Document GroupBy transform.

codecov[bot] edited a comment on pull request #12834: URL: https://github.com/apache/beam/pull/12834#issuecomment-691369145 # [Codecov](https://codecov.io/gh/apache/beam/pull/12834?src=pr=h1) Report > Merging [#12834](https://codecov.io/gh/apache/beam/pull/12834?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12834: Document GroupBy transform.

codecov[bot] edited a comment on pull request #12834: URL: https://github.com/apache/beam/pull/12834#issuecomment-691369145 # [Codecov](https://codecov.io/gh/apache/beam/pull/12834?src=pr=h1) Report > Merging [#12834](https://codecov.io/gh/apache/beam/pull/12834?src=pr=desc) into

[GitHub] [beam] TheNeuralBit merged pull request #12831: [BEAM-10252] Add null check on logical type override

TheNeuralBit merged pull request #12831: URL: https://github.com/apache/beam/pull/12831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12832: Add basic ToRows transform.

codecov[bot] edited a comment on pull request #12832: URL: https://github.com/apache/beam/pull/12832#issuecomment-691348838 # [Codecov](https://codecov.io/gh/apache/beam/pull/12832?src=pr=h1) Report > Merging [#12832](https://codecov.io/gh/apache/beam/pull/12832?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

codecov[bot] commented on pull request #12576: URL: https://github.com/apache/beam/pull/12576#issuecomment-692353567 # [Codecov](https://codecov.io/gh/apache/beam/pull/12576?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request head (`BEAM-10671@e96b70d`). [Click here

[GitHub] [beam] codecov[bot] edited a comment on pull request #12505: [WIP][BEAM-8106] Add version to java container image name

codecov[bot] edited a comment on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-684502100 # [Codecov](https://codecov.io/gh/apache/beam/pull/12505?src=pr=h1) Report > Merging [#12505](https://codecov.io/gh/apache/beam/pull/12505?src=pr=desc) into

[GitHub] [beam] emilymye commented on pull request #12505: [WIP][BEAM-8106] Add version to java container image name

emilymye commented on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-692362081 R: @chamikaramj @TheNeuralBit cc: @kennknowles I think Kenneth mentioned y'all might be good reviewers for this PR. I previously ran the Java postcommit and it passed,

[GitHub] [beam] lukecwik commented on a change in pull request #12806: [BEAM-10869] Use PubsubMessagePayloadOnlyCoder when writing to Pubsub.

lukecwik commented on a change in pull request #12806: URL: https://github.com/apache/beam/pull/12806#discussion_r488208550 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java ## @@ -1012,6 +1012,8 @@ public PDone

[GitHub] [beam] lukecwik commented on a change in pull request #12806: [BEAM-10869] Use PubsubMessagePayloadOnlyCoder when writing to Pubsub.

lukecwik commented on a change in pull request #12806: URL: https://github.com/apache/beam/pull/12806#discussion_r488216535 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java ## @@ -1010,20 +1011,27 @@ public PDone

[GitHub] [beam] lostluck commented on a change in pull request #12588: [BEAM-7009] Add Go SDK Standard Coders yaml tests.

lostluck commented on a change in pull request #12588: URL: https://github.com/apache/beam/pull/12588#discussion_r488222388 ## File path: sdks/go/pkg/beam/core/runtime/exec/coder.go ## @@ -81,24 +82,82 @@ func MakeElementEncoder(c *coder.Coder) ElementEncoder {

[GitHub] [beam] lostluck commented on a change in pull request #12588: [BEAM-7009] Add Go SDK Standard Coders yaml tests.

lostluck commented on a change in pull request #12588: URL: https://github.com/apache/beam/pull/12588#discussion_r488226218 ## File path: sdks/go/pkg/beam/core/runtime/exec/coder.go ## @@ -434,6 +600,267 @@ func convertIfNeeded(v interface{}, allocated *FullValue) *FullValue

[GitHub] [beam] lostluck commented on a change in pull request #12588: [BEAM-7009] Add Go SDK Standard Coders yaml tests.

lostluck commented on a change in pull request #12588: URL: https://github.com/apache/beam/pull/12588#discussion_r488227779 ## File path: sdks/go/test/regression/coders/fromyaml/fromyaml.go ## @@ -0,0 +1,415 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] boyuanzz merged pull request #12726: [BEAM-10475] Add max buffering duration to GroupIntoBatches (Java)

boyuanzz merged pull request #12726: URL: https://github.com/apache/beam/pull/12726 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] boyuanzz commented on pull request #12726: [BEAM-10475] Add max buffering duration to GroupIntoBatches (Java)

boyuanzz commented on pull request #12726: URL: https://github.com/apache/beam/pull/12726#issuecomment-692328746 The test failure is not related. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12553: [BEAM-9615] Add initial schema proto documentation.

codecov[bot] edited a comment on pull request #12553: URL: https://github.com/apache/beam/pull/12553#issuecomment-692340545 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12553: [BEAM-9615] Add initial schema proto documentation.

codecov[bot] edited a comment on pull request #12553: URL: https://github.com/apache/beam/pull/12553#issuecomment-692340545 # [Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr=h1) Report > Merging [#12553](https://codecov.io/gh/apache/beam/pull/12553?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on pull request #12833: Updates Dataflow containers used by unreleased SDKs.

tvalentyn commented on pull request #12833: URL: https://github.com/apache/beam/pull/12833#issuecomment-692351130 Python PreCommits passed, flake in MacOS unit test suite does not exercise this codepath. This is an

[GitHub] [beam] tvalentyn merged pull request #12833: Updates Dataflow containers used by unreleased SDKs.

tvalentyn merged pull request #12833: URL: https://github.com/apache/beam/pull/12833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] robinyqiu opened a new pull request #12843: [WIP] Support UNNEST an (possibly nested) array field of an struct column

robinyqiu opened a new pull request #12843: URL: https://github.com/apache/beam/pull/12843 See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).

[GitHub] [beam] lostluck commented on a change in pull request #12553: [BEAM-9615] Add initial schema proto documentation.

lostluck commented on a change in pull request #12553: URL: https://github.com/apache/beam/pull/12553#discussion_r488240030 ## File path: model/pipeline/src/main/proto/schema.proto ## @@ -32,16 +32,27 @@ option java_package = "org.apache.beam.model.pipeline.v1"; option

[GitHub] [beam] codecov[bot] edited a comment on pull request #12834: Document GroupBy transform.

codecov[bot] edited a comment on pull request #12834: URL: https://github.com/apache/beam/pull/12834#issuecomment-691369145 # [Codecov](https://codecov.io/gh/apache/beam/pull/12834?src=pr=h1) Report > Merging [#12834](https://codecov.io/gh/apache/beam/pull/12834?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12553: [BEAM-9615] Add initial schema proto documentation.

codecov[bot] commented on pull request #12553: URL: https://github.com/apache/beam/pull/12553#issuecomment-692340545 # [Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr=h1) Report > Merging [#12553](https://codecov.io/gh/apache/beam/pull/12553?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12553: [BEAM-9615] Add initial schema proto documentation.

codecov[bot] edited a comment on pull request #12553: URL: https://github.com/apache/beam/pull/12553#issuecomment-692340545 # [Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr=h1) Report > Merging [#12553](https://codecov.io/gh/apache/beam/pull/12553?src=pr=desc) into

[GitHub] [beam] emilymye commented on pull request #12833: Updates Dataflow containers used by unreleased SDKs.

emilymye commented on pull request #12833: URL: https://github.com/apache/beam/pull/12833#issuecomment-692348565 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12505: [WIP][BEAM-8106] Add version to java container image name

codecov[bot] edited a comment on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-684502100 # [Codecov](https://codecov.io/gh/apache/beam/pull/12505?src=pr=h1) Report > Merging [#12505](https://codecov.io/gh/apache/beam/pull/12505?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

codecov[bot] edited a comment on pull request #12576: URL: https://github.com/apache/beam/pull/12576#issuecomment-692353567 # [Codecov](https://codecov.io/gh/apache/beam/pull/12576?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request head (`BEAM-10671@edb10f3`).

  1   2   >