[GitHub] [beam] piotr-szuberski commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-15 Thread GitBox
piotr-szuberski commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-692507849 @chamikaramj ping This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-685598683 # [Codecov](https://codecov.io/gh/apache/beam/pull/12758?src=pr=h1) Report > Merging [#12758](https://codecov.io/gh/apache/beam/pull/12758?src=pr=desc) into

[GitHub] [beam] piotr-szuberski commented on pull request #12809: [BEAM-10870] Add raw private key param to snowflake cross-language python wrapper

2020-09-15 Thread GitBox
piotr-szuberski commented on pull request #12809: URL: https://github.com/apache/beam/pull/12809#issuecomment-692508024 @chamikaramj ping This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] piotr-szuberski commented on pull request #12847: [BEAM-7523] Fix starting Kafka container twice in KafkaCSVTableIT

2020-09-15 Thread GitBox
piotr-szuberski commented on pull request #12847: URL: https://github.com/apache/beam/pull/12847#issuecomment-692544119 @TheNeuralBit Could you review this? I think it's worth to have it done asap. This is an automated

[GitHub] [beam] piotr-szuberski opened a new pull request #12847: [BEAM-7523] Fix starting Kafka container twice in KafkaCSVTableIT

2020-09-15 Thread GitBox
piotr-szuberski opened a new pull request #12847: URL: https://github.com/apache/beam/pull/12847 I made a mistake and Kafka Container starts twice in KafkaCSVTableIT (@Rule KafkaContainer makes it start and stop automatically). It may result in leaving redundant containers on the VMs.

[GitHub] [beam] runningcode commented on pull request #12846: [BEAM-10886] Fix Java Wordcount Direct Runner (windows-latest)

2020-09-15 Thread GitBox
runningcode commented on pull request #12846: URL: https://github.com/apache/beam/pull/12846#issuecomment-692523923 R: @TheNeuralBit R: @lukecwik R: @kennknowles R: @mxm This is an automated message from the Apache Git

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12611: [BEAM-10139][BEAM-10140] Add cross-language support for Java SpannerIO with python wrapper

2020-09-15 Thread GitBox
piotr-szuberski commented on a change in pull request #12611: URL: https://github.com/apache/beam/pull/12611#discussion_r488422134 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/StructUtils.java ## @@ -0,0 +1,545 @@ +/* + *

[GitHub] [beam] runningcode opened a new pull request #12846: [BEAM-10886] Fix Java Wordcount Direct Runner (windows-latest)

2020-09-15 Thread GitBox
runningcode opened a new pull request #12846: URL: https://github.com/apache/beam/pull/12846 This fixes the java wordcount direct runner test on windows by using the Gradle Github action. Gradle Github action will use the `.bat` script on windows instead of the gradlew bash script.

[GitHub] [beam] purbanow commented on pull request #12823: [BEAM-10882] Update Snowflake docs

2020-09-15 Thread GitBox
purbanow commented on pull request #12823: URL: https://github.com/apache/beam/pull/12823#issuecomment-692653308 @TheNeuralBit will you find a moment for a CR? This is an automated message from the Apache Git Service. To

[GitHub] [beam] pabloem commented on pull request #12704: [BEAM-10603] Implement the new Large Source Recording API.

2020-09-15 Thread GitBox
pabloem commented on pull request #12704: URL: https://github.com/apache/beam/pull/12704#issuecomment-692746763 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] mxm commented on a change in pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

2020-09-15 Thread GitBox
mxm commented on a change in pull request #12576: URL: https://github.com/apache/beam/pull/12576#discussion_r488571222 ## File path: sdks/python/apache_beam/options/pipeline_options.py ## @@ -1044,7 +1044,12 @@ def _add_argparse_args(cls, parser): 'form {"os": "",

[GitHub] [beam] kamilwu commented on pull request #12848: [BEAM-10616] Add missing ParDo test cases for streaming/Flink

2020-09-15 Thread GitBox
kamilwu commented on pull request #12848: URL: https://github.com/apache/beam/pull/12848#issuecomment-692698764 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] entimaniac commented on pull request #12564: [BEAM-10612] add Flink 1.11 runner

2020-09-15 Thread GitBox
entimaniac commented on pull request #12564: URL: https://github.com/apache/beam/pull/12564#issuecomment-692709810 thanks! that was all the information I was looking to hear This is an automated message from the Apache Git

[GitHub] [beam] tanya-borisova commented on pull request #12734: Add authentication story via pipeline options and tests using Azurite.

2020-09-15 Thread GitBox
tanya-borisova commented on pull request #12734: URL: https://github.com/apache/beam/pull/12734#issuecomment-692744673 FYI we at Wayve are going to use Beam for our data pipelines, and we store our data in Azure. Naturally, we're very interested in these features getting merged and

[GitHub] [beam] pabloem merged pull request #12808: add readme file to python nexmark

2020-09-15 Thread GitBox
pabloem merged pull request #12808: URL: https://github.com/apache/beam/pull/12808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] kamilwu commented on pull request #12848: [BEAM-10616] Add missing ParDo test cases for streaming/Flink

2020-09-15 Thread GitBox
kamilwu commented on pull request #12848: URL: https://github.com/apache/beam/pull/12848#issuecomment-692645050 Run Load Tests Python ParDo Combine Streaming This is an automated message from the Apache Git Service. To

[GitHub] [beam] kamilwu commented on pull request #12848: [BEAM-10616] Add missing ParDo test cases for streaming/Flink

2020-09-15 Thread GitBox
kamilwu commented on pull request #12848: URL: https://github.com/apache/beam/pull/12848#issuecomment-692645216 Run Load Tests Python Combine Flink Streaming This is an automated message from the Apache Git Service. To

[GitHub] [beam] kamilwu removed a comment on pull request #12848: [BEAM-10616] Add missing ParDo test cases for streaming/Flink

2020-09-15 Thread GitBox
kamilwu removed a comment on pull request #12848: URL: https://github.com/apache/beam/pull/12848#issuecomment-692645050 Run Load Tests Python ParDo Combine Streaming This is an automated message from the Apache Git Service.

[GitHub] [beam] kamilwu commented on pull request #12848: [BEAM-10616] Add missing ParDo test cases for streaming/Flink

2020-09-15 Thread GitBox
kamilwu commented on pull request #12848: URL: https://github.com/apache/beam/pull/12848#issuecomment-692644949 Run Load Tests Python ParDo Flink Streaming This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] jayendra13 commented on a change in pull request #12540: [BEAM-10620] Eliminate nullability errors from :sdks:java:extensions:sql:perf-tests

2020-09-15 Thread GitBox
jayendra13 commented on a change in pull request #12540: URL: https://github.com/apache/beam/pull/12540#discussion_r488690404 ## File path: sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/IOTestPipelineOptions.java ## @@ -45,19 +45,16 @@ void

[GitHub] [beam] pabloem merged pull request #12813: write to file ability for java suite

2020-09-15 Thread GitBox
pabloem merged pull request #12813: URL: https://github.com/apache/beam/pull/12813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] kamilwu commented on pull request #12848: [BEAM-10616] Add missing ParDo test cases for streaming/Flink

2020-09-15 Thread GitBox
kamilwu commented on pull request #12848: URL: https://github.com/apache/beam/pull/12848#issuecomment-692641763 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] methodmissing commented on pull request #12794: [BEAM-10865] Support for Kafka deserialization API with headers (since Kafka API 2.1.0)

2020-09-15 Thread GitBox
methodmissing commented on pull request #12794: URL: https://github.com/apache/beam/pull/12794#issuecomment-692706541 Hi Luke, Apologies for the lag on this. TLDR I have the integration test against `KafkaIOTest` going but seem to not be able to force the `kafka-clients` module

[GitHub] [beam] samatix commented on pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

2020-09-15 Thread GitBox
samatix commented on pull request #12811: URL: https://github.com/apache/beam/pull/12811#issuecomment-692656216 @tvalentyn, I've corrected the problem with python 2.7 and corrected two formatting issues. Now I'm able to run tox locally on my machine. For the next time, I will avoid such

[GitHub] [beam] pabloem merged pull request #12704: [BEAM-10603] Implement the new Large Source Recording API.

2020-09-15 Thread GitBox
pabloem merged pull request #12704: URL: https://github.com/apache/beam/pull/12704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] kamilwu opened a new pull request #12848: [BEAM-10616] Add missing ParDo test cases for streaming/Flink

2020-09-15 Thread GitBox
kamilwu opened a new pull request #12848: URL: https://github.com/apache/beam/pull/12848 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] entimaniac commented on pull request #12564: [BEAM-10612] add Flink 1.11 runner

2020-09-15 Thread GitBox
entimaniac commented on pull request #12564: URL: https://github.com/apache/beam/pull/12564#issuecomment-692685878 Hey, I know this is a closed PR but I'm hoping someone can help me. I'm trying to understand how I might be able to take advantage of this PR. The environment I'm trying to

[GitHub] [beam] mxm commented on pull request #12564: [BEAM-10612] add Flink 1.11 runner

2020-09-15 Thread GitBox
mxm commented on pull request #12564: URL: https://github.com/apache/beam/pull/12564#issuecomment-692699588 Support for Flink 1.11 will be included in Beam 2.25.0. Until then, you'll have to manually build the jar from source using the following command: ./gradlew

[GitHub] [beam] tanya-borisova commented on pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-09-15 Thread GitBox
tanya-borisova commented on pull request #12492: URL: https://github.com/apache/beam/pull/12492#issuecomment-692624622 This is some great functionality in this PR, is it expected to be in a release soon? This is an

[GitHub] [beam] kamilwu commented on pull request #12848: [BEAM-10616] Add missing ParDo test cases for streaming/Flink

2020-09-15 Thread GitBox
kamilwu commented on pull request #12848: URL: https://github.com/apache/beam/pull/12848#issuecomment-692703201 Run Load Tests Python ParDo Flink Streaming This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] pabloem commented on pull request #12721: [BEAM-10871] Add deidentify for FhirIO connector

2020-09-15 Thread GitBox
pabloem commented on pull request #12721: URL: https://github.com/apache/beam/pull/12721#issuecomment-692734363 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tanya-borisova commented on pull request #12734: Add authentication story via pipeline options and tests using Azurite.

2020-09-15 Thread GitBox
tanya-borisova commented on pull request #12734: URL: https://github.com/apache/beam/pull/12734#issuecomment-692740987 @AldairCoronel With this PR, will it possible to connect to several different storage accounts using different connection strings?

[GitHub] [beam] PoojaChandak opened a new pull request #12849: [Minor] Typo/grammatical changes

2020-09-15 Thread GitBox
PoojaChandak opened a new pull request #12849: URL: https://github.com/apache/beam/pull/12849 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] codecov[bot] edited a comment on pull request #12812: [BEAM-10873] Stronger testing of dataframe partitioning declarations.

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12812: URL: https://github.com/apache/beam/pull/12812#issuecomment-690611762 # [Codecov](https://codecov.io/gh/apache/beam/pull/12812?src=pr=h1) Report > Merging [#12812](https://codecov.io/gh/apache/beam/pull/12812?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12841: URL: https://github.com/apache/beam/pull/12841#issuecomment-692395796 # [Codecov](https://codecov.io/gh/apache/beam/pull/12841?src=pr=h1) Report > Merging [#12841](https://codecov.io/gh/apache/beam/pull/12841?src=pr=desc) into

[GitHub] [beam] TheNeuralBit commented on pull request #12847: [BEAM-7523] Fix starting Kafka container twice in KafkaCSVTableIT

2020-09-15 Thread GitBox
TheNeuralBit commented on pull request #12847: URL: https://github.com/apache/beam/pull/12847#issuecomment-692819294 Looks like moving the imports around broke spotless, I'll push a commit to fix so we can get this merged today.

[GitHub] [beam] codecov[bot] edited a comment on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12841: URL: https://github.com/apache/beam/pull/12841#issuecomment-692395796 # [Codecov](https://codecov.io/gh/apache/beam/pull/12841?src=pr=h1) Report > Merging [#12841](https://codecov.io/gh/apache/beam/pull/12841?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12841: URL: https://github.com/apache/beam/pull/12841#issuecomment-692395796 # [Codecov](https://codecov.io/gh/apache/beam/pull/12841?src=pr=h1) Report > Merging [#12841](https://codecov.io/gh/apache/beam/pull/12841?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

2020-09-15 Thread GitBox
tvalentyn commented on pull request #12811: URL: https://github.com/apache/beam/pull/12811#issuecomment-692845652 Actually found the previous green PostCommit result: https://ci-beam.apache.org/job/beam_PostCommit_Python36_PR/93/

[GitHub] [beam] kw2542 commented on a change in pull request #12617: [BEAM-10670] Update Samza to be opt-out for SplittableDoFn powering the Read transform.

2020-09-15 Thread GitBox
kw2542 commented on a change in pull request #12617: URL: https://github.com/apache/beam/pull/12617#discussion_r488820872 ## File path: runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaRunner.java ## @@ -106,6 +107,7 @@ public PortablePipelineResult

[GitHub] [beam] pabloem merged pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-15 Thread GitBox
pabloem merged pull request #12770: URL: https://github.com/apache/beam/pull/12770 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] kamilwu commented on pull request #12848: [BEAM-10616] Add missing ParDo test cases for streaming/Flink

2020-09-15 Thread GitBox
kamilwu commented on pull request #12848: URL: https://github.com/apache/beam/pull/12848#issuecomment-692780948 R: @mxm This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] robertwb commented on pull request #12812: [BEAM-10873] Stronger testing of dataframe partitioning declarations.

2020-09-15 Thread GitBox
robertwb commented on pull request #12812: URL: https://github.com/apache/beam/pull/12812#issuecomment-692799520 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12841: URL: https://github.com/apache/beam/pull/12841#issuecomment-692395796 # [Codecov](https://codecov.io/gh/apache/beam/pull/12841?src=pr=h1) Report > Merging [#12841](https://codecov.io/gh/apache/beam/pull/12841?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

2020-09-15 Thread GitBox
tvalentyn commented on pull request #12811: URL: https://github.com/apache/beam/pull/12811#issuecomment-692844451 > able to reproduce the last two issues (they seem to be random). Any ideas on what went wrong? Those seem to be flaky tests :(. Found this in the logs: ```

[GitHub] [beam] chamikaramj commented on a change in pull request #12505: [BEAM-8106] Add version to java container image name

2020-09-15 Thread GitBox
chamikaramj commented on a change in pull request #12505: URL: https://github.com/apache/beam/pull/12505#discussion_r488818825 ## File path: website/www/site/content/en/documentation/runtime/environments.md ## @@ -116,8 +116,8 @@ By default, no licenses/notices are added to

[GitHub] [beam] lukecwik commented on a change in pull request #12617: [BEAM-10670] Update Samza to be opt-out for SplittableDoFn powering the Read transform.

2020-09-15 Thread GitBox
lukecwik commented on a change in pull request #12617: URL: https://github.com/apache/beam/pull/12617#discussion_r488825043 ## File path: runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaRunner.java ## @@ -106,6 +107,7 @@ public PortablePipelineResult

[GitHub] [beam] tvalentyn commented on a change in pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

2020-09-15 Thread GitBox
tvalentyn commented on a change in pull request #12811: URL: https://github.com/apache/beam/pull/12811#discussion_r488824939 ## File path: sdks/python/apache_beam/runners/portability/stager_test.py ## @@ -448,7 +448,8 @@ def test_sdk_location_remote_source_file(self,

[GitHub] [beam] pabloem commented on a change in pull request #12823: [BEAM-10882] Update Snowflake docs

2020-09-15 Thread GitBox
pabloem commented on a change in pull request #12823: URL: https://github.com/apache/beam/pull/12823#discussion_r488745935 ## File path: website/www/site/content/en/documentation/io/built-in/snowflake.md ## @@ -362,3 +635,206 @@ static SnowflakeIO.CsvMapper getCsvMapper() {

[GitHub] [beam] robertwb commented on pull request #12834: Document GroupBy transform.

2020-09-15 Thread GitBox
robertwb commented on pull request #12834: URL: https://github.com/apache/beam/pull/12834#issuecomment-692796395 Run Website PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12834: Document GroupBy transform.

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12834: URL: https://github.com/apache/beam/pull/12834#issuecomment-691369145 # [Codecov](https://codecov.io/gh/apache/beam/pull/12834?src=pr=h1) Report > Merging [#12834](https://codecov.io/gh/apache/beam/pull/12834?src=pr=desc) into

[GitHub] [beam] terryxian78 commented on pull request #12818: [BEAM-10875] Support NUMERIC in spanner schema parser

2020-09-15 Thread GitBox
terryxian78 commented on pull request #12818: URL: https://github.com/apache/beam/pull/12818#issuecomment-692816048 ping, @chamikaramj, could you review this PR? Thanks! This is an automated message from the Apache Git

[GitHub] [beam] TheNeuralBit commented on pull request #12846: [BEAM-10886] Fix Java Wordcount Direct Runner (windows-latest)

2020-09-15 Thread GitBox
TheNeuralBit commented on pull request #12846: URL: https://github.com/apache/beam/pull/12846#issuecomment-692816874 Thanks @runningcode! Looks like this adds a dependency on https://github.com/eskatos/gradle-command-action but it is MIT licensed so I don't think there's any concern.

[GitHub] [beam] ajamato commented on a change in pull request #12822: [BEAM-10880] Log error counts to debug BigQuery streaming insert requ…

2020-09-15 Thread GitBox
ajamato commented on a change in pull request #12822: URL: https://github.com/apache/beam/pull/12822#discussion_r488797757 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -1210,20 +1236,32 @@ def process(self, element, *schema_side_inputs): return

[GitHub] [beam] timclemons opened a new pull request #12850: [BEAM-10481] Ensure registration of the accumulator occurs.

2020-09-15 Thread GitBox
timclemons opened a new pull request #12850: URL: https://github.com/apache/beam/pull/12850 Move registration of accumulator so as to include those recovered from checkpoints. Prior to this, if the accumulator was recovered from a checkpoint it would not be registered, resulting in a

[GitHub] [beam] tvalentyn commented on pull request #12637: [BEAM-10768] Don't assert the order in which elements are received.

2020-09-15 Thread GitBox
tvalentyn commented on pull request #12637: URL: https://github.com/apache/beam/pull/12637#issuecomment-692843176 seeing this flake in precommits, thanks for fixing it. This is an automated message from the Apache Git

[GitHub] [beam] amaliujia commented on pull request #12843: [BEAM-10895] Support UNNEST an (possibly nested) array field of an struct column

2020-09-15 Thread GitBox
amaliujia commented on pull request #12843: URL: https://github.com/apache/beam/pull/12843#issuecomment-692848083 Thanks @robinyqiu will take a look soon. This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] monicadsong commented on pull request #12851: [BEAM-10900] add ability for ApproximateUniqueCombineFn to handle numpy input data

2020-09-15 Thread GitBox
monicadsong commented on pull request #12851: URL: https://github.com/apache/beam/pull/12851#issuecomment-692856430 R: @tvalentyn This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] codecov[bot] commented on pull request #12779: [BEAM-10856] Support for NestedValueProvider for Python SDK

2020-09-15 Thread GitBox
codecov[bot] commented on pull request #12779: URL: https://github.com/apache/beam/pull/12779#issuecomment-692856347 # [Codecov](https://codecov.io/gh/apache/beam/pull/12779?src=pr=h1) Report > Merging [#12779](https://codecov.io/gh/apache/beam/pull/12779?src=pr=desc) into

[GitHub] [beam] monicadsong opened a new pull request #12851: [BEAM-10900] add ability for ApproximateUniqueCombineFn to handle numpy input data

2020-09-15 Thread GitBox
monicadsong opened a new pull request #12851: URL: https://github.com/apache/beam/pull/12851 If element for ApproximateUniqueCombineFn.add_input() is numpy type, convert to python type. Thank you for your contribution! Follow this checklist to help us

[GitHub] [beam] robertwb commented on pull request #12812: [BEAM-10873] Stronger testing of dataframe partitioning declarations.

2020-09-15 Thread GitBox
robertwb commented on pull request #12812: URL: https://github.com/apache/beam/pull/12812#issuecomment-692861888 The github actions failures look completely unrelated and the tests all pass on jenkins (and locally). This

[GitHub] [beam] robertwb merged pull request #12812: [BEAM-10873] Stronger testing of dataframe partitioning declarations.

2020-09-15 Thread GitBox
robertwb merged pull request #12812: URL: https://github.com/apache/beam/pull/12812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12823: [BEAM-10882] Update Snowflake docs

2020-09-15 Thread GitBox
TheNeuralBit commented on a change in pull request #12823: URL: https://github.com/apache/beam/pull/12823#discussion_r488776570 ## File path: website/www/site/content/en/documentation/io/built-in/snowflake.md ## @@ -362,3 +635,206 @@ static SnowflakeIO.CsvMapper

[GitHub] [beam] robertwb merged pull request #12834: Document GroupBy transform.

2020-09-15 Thread GitBox
robertwb merged pull request #12834: URL: https://github.com/apache/beam/pull/12834 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] TheNeuralBit merged pull request #12846: [BEAM-10886] Fix Java Wordcount Direct Runner (windows-latest)

2020-09-15 Thread GitBox
TheNeuralBit merged pull request #12846: URL: https://github.com/apache/beam/pull/12846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] ajamato commented on a change in pull request #12822: [BEAM-10880] Log error counts to debug BigQuery streaming insert requ…

2020-09-15 Thread GitBox
ajamato commented on a change in pull request #12822: URL: https://github.com/apache/beam/pull/12822#discussion_r488813424 ## File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py ## @@ -538,6 +539,13 @@ def _insert_all_rows( try: response =

[GitHub] [beam] ibzib commented on a change in pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

2020-09-15 Thread GitBox
ibzib commented on a change in pull request #12576: URL: https://github.com/apache/beam/pull/12576#discussion_r488839465 ## File path: sdks/python/apache_beam/options/pipeline_options.py ## @@ -1044,7 +1044,12 @@ def _add_argparse_args(cls, parser): 'form {"os":

[GitHub] [beam] boyuanzz commented on pull request #12806: [BEAM-10869] Use PubsubMessagePayloadOnlyCoder when writing to Pubsub.

2020-09-15 Thread GitBox
boyuanzz commented on pull request #12806: URL: https://github.com/apache/beam/pull/12806#issuecomment-692865584 r: @chamikaramj This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12721: [BEAM-10871] Add deidentify for FhirIO connector

2020-09-15 Thread GitBox
pabloem commented on pull request #12721: URL: https://github.com/apache/beam/pull/12721#issuecomment-692790229 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] TheNeuralBit commented on pull request #12505: [BEAM-8106] Add version to java container image name

2020-09-15 Thread GitBox
TheNeuralBit commented on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-692824435 Note the release manager that will likely be impacted is @robinyqiu for 2.25.0, since the 2.24.0 branch has already been cut.

[GitHub] [beam] TheNeuralBit commented on pull request #12505: [BEAM-8106] Add version to java container image name

2020-09-15 Thread GitBox
TheNeuralBit commented on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-692827332 Run Dataflow PortabilityApi ValidatesRunner with Java 11 This is an automated message from the Apache Git

[GitHub] [beam] codecov[bot] edited a comment on pull request #12505: [BEAM-8106] Add version to java container image name

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-684502100 # [Codecov](https://codecov.io/gh/apache/beam/pull/12505?src=pr=h1) Report > Merging [#12505](https://codecov.io/gh/apache/beam/pull/12505?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on pull request #12779: [BEAM-10856] Support for NestedValueProvider for Python SDK

2020-09-15 Thread GitBox
tvalentyn commented on pull request #12779: URL: https://github.com/apache/beam/pull/12779#issuecomment-692833522 > A user has written a feature that they would find useful, and that will not change the experience for other users (if anything, it should improve it). The feature looks

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12505: [BEAM-8106] Add version to java container image name

2020-09-15 Thread GitBox
TheNeuralBit commented on a change in pull request #12505: URL: https://github.com/apache/beam/pull/12505#discussion_r488809349 ## File path: sdks/java/container/Dockerfile-java11 ## @@ -16,6 +16,10 @@ # limitations under the License.

[GitHub] [beam] tvalentyn edited a comment on pull request #12779: [BEAM-10856] Support for NestedValueProvider for Python SDK

2020-09-15 Thread GitBox
tvalentyn edited a comment on pull request #12779: URL: https://github.com/apache/beam/pull/12779#issuecomment-692833522 > A user has written a feature that they would find useful, and that will not change the experience for other users (if anything, it should improve it). The feature

[GitHub] [beam] codecov[bot] edited a comment on pull request #12779: [BEAM-10856] Support for NestedValueProvider for Python SDK

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12779: URL: https://github.com/apache/beam/pull/12779#issuecomment-692856347 # [Codecov](https://codecov.io/gh/apache/beam/pull/12779?src=pr=h1) Report > Merging [#12779](https://codecov.io/gh/apache/beam/pull/12779?src=pr=desc) into

[GitHub] [beam] pabloem commented on pull request #12721: [BEAM-10871] Add deidentify for FhirIO connector

2020-09-15 Thread GitBox
pabloem commented on pull request #12721: URL: https://github.com/apache/beam/pull/12721#issuecomment-692763416 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] yifanmai commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-15 Thread GitBox
yifanmai commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-692808999 Awesome, thanks for your help! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on pull request #12505: [BEAM-8106] Add version to java container image name

2020-09-15 Thread GitBox
TheNeuralBit commented on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-692822795 It looks like the spotless (Java code format) check is failing. FYI you can auto-format locally with `./gradlew spotlessApply`. It's not critical until we're ready to merge

[GitHub] [beam] tvalentyn commented on pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

2020-09-15 Thread GitBox
tvalentyn commented on pull request #12811: URL: https://github.com/apache/beam/pull/12811#issuecomment-692844750 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] pabloem merged pull request #12807: [BEAM-2855] implement query 10

2020-09-15 Thread GitBox
pabloem merged pull request #12807: URL: https://github.com/apache/beam/pull/12807 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12841: URL: https://github.com/apache/beam/pull/12841#issuecomment-692395796 # [Codecov](https://codecov.io/gh/apache/beam/pull/12841?src=pr=h1) Report > Merging [#12841](https://codecov.io/gh/apache/beam/pull/12841?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12819: [BEAM-9561] Initial framework for testing pandas website docs.

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12819: URL: https://github.com/apache/beam/pull/12819#issuecomment-691336298 # [Codecov](https://codecov.io/gh/apache/beam/pull/12819?src=pr=h1) Report > Merging [#12819](https://codecov.io/gh/apache/beam/pull/12819?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12812: [BEAM-10873] Stronger testing of dataframe partitioning declarations.

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12812: URL: https://github.com/apache/beam/pull/12812#issuecomment-690611762 # [Codecov](https://codecov.io/gh/apache/beam/pull/12812?src=pr=h1) Report > Merging [#12812](https://codecov.io/gh/apache/beam/pull/12812?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

2020-09-15 Thread GitBox
tvalentyn commented on pull request #12811: URL: https://github.com/apache/beam/pull/12811#issuecomment-692850902 Thanks, @samatix ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn merged pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

2020-09-15 Thread GitBox
tvalentyn merged pull request #12811: URL: https://github.com/apache/beam/pull/12811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] codecov[bot] edited a comment on pull request #12806: [BEAM-10869] Make WriteToPubsub output serialized PubsubMessage proto bytes when using runner v2

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12806: URL: https://github.com/apache/beam/pull/12806#issuecomment-692876818 # [Codecov](https://codecov.io/gh/apache/beam/pull/12806?src=pr=h1) Report > Merging [#12806](https://codecov.io/gh/apache/beam/pull/12806?src=pr=desc) into

[GitHub] [beam] ibzib commented on pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

2020-09-15 Thread GitBox
ibzib commented on pull request #12576: URL: https://github.com/apache/beam/pull/12576#issuecomment-692885360 (Filed BEAM-10901 for test flakes.) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12799: [BEAM-10603] Add record_pipeline, clear to RM and fix duration limiter

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12799: URL: https://github.com/apache/beam/pull/12799#issuecomment-692960218 # [Codecov](https://codecov.io/gh/apache/beam/pull/12799?src=pr=h1) Report > Merging [#12799](https://codecov.io/gh/apache/beam/pull/12799?src=pr=desc) into

[GitHub] [beam] monicadsong commented on a change in pull request #12851: [BEAM-10900] add ability for ApproximateUniqueCombineFn to handle numpy input data

2020-09-15 Thread GitBox
monicadsong commented on a change in pull request #12851: URL: https://github.com/apache/beam/pull/12851#discussion_r488863704 ## File path: sdks/python/apache_beam/transforms/stats_test.py ## @@ -89,6 +90,12 @@ def setUp(self): None, 0.1,

[GitHub] [beam] ibzib commented on a change in pull request #12827: [BEAM-10885] Add Avro support to Kafka table provider

2020-09-15 Thread GitBox
ibzib commented on a change in pull request #12827: URL: https://github.com/apache/beam/pull/12827#discussion_r488862816 ## File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/BeamKafkaTableTest.java ## @@ -41,27 +40,49 @@

[GitHub] [beam] robertwb merged pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-15 Thread GitBox
robertwb merged pull request #12787: URL: https://github.com/apache/beam/pull/12787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12576: URL: https://github.com/apache/beam/pull/12576#issuecomment-692353567 # [Codecov](https://codecov.io/gh/apache/beam/pull/12576?src=pr=h1) Report > Merging [#12576](https://codecov.io/gh/apache/beam/pull/12576?src=pr=desc) into

[GitHub] [beam] monicadsong closed pull request #12851: [BEAM-10900] add ability for ApproximateUniqueCombineFn to handle numpy input data

2020-09-15 Thread GitBox
monicadsong closed pull request #12851: URL: https://github.com/apache/beam/pull/12851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] tvalentyn commented on a change in pull request #12851: [BEAM-10900] add ability for ApproximateUniqueCombineFn to handle numpy input data

2020-09-15 Thread GitBox
tvalentyn commented on a change in pull request #12851: URL: https://github.com/apache/beam/pull/12851#discussion_r488853550 ## File path: sdks/python/apache_beam/transforms/stats_test.py ## @@ -89,6 +90,12 @@ def setUp(self): None, 0.1,

[GitHub] [beam] mxm commented on pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

2020-09-15 Thread GitBox
mxm commented on pull request #12576: URL: https://github.com/apache/beam/pull/12576#issuecomment-692877960 Thanks! I'll have another look tomorrow but generally looks good to me. This is an automated message from the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12806: [BEAM-10869] Make WriteToPubsub output serialized PubsubMessage proto bytes when using runner v2

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12806: URL: https://github.com/apache/beam/pull/12806#issuecomment-692876818 # [Codecov](https://codecov.io/gh/apache/beam/pull/12806?src=pr=h1) Report > Merging [#12806](https://codecov.io/gh/apache/beam/pull/12806?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12806: [BEAM-10869] Make WriteToPubsub output serialized PubsubMessage proto bytes when using runner v2

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12806: URL: https://github.com/apache/beam/pull/12806#issuecomment-692876818 # [Codecov](https://codecov.io/gh/apache/beam/pull/12806?src=pr=h1) Report > Merging [#12806](https://codecov.io/gh/apache/beam/pull/12806?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12576: URL: https://github.com/apache/beam/pull/12576#issuecomment-692353567 # [Codecov](https://codecov.io/gh/apache/beam/pull/12576?src=pr=h1) Report > Merging [#12576](https://codecov.io/gh/apache/beam/pull/12576?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12806: [BEAM-10869] Make WriteToPubsub output serialized PubsubMessage proto bytes when using runner v2

2020-09-15 Thread GitBox
codecov[bot] edited a comment on pull request #12806: URL: https://github.com/apache/beam/pull/12806#issuecomment-692876818 # [Codecov](https://codecov.io/gh/apache/beam/pull/12806?src=pr=h1) Report > Merging [#12806](https://codecov.io/gh/apache/beam/pull/12806?src=pr=desc) into

  1   2   >