[GitHub] [beam] kileys opened a new pull request #12899: [BEAM-8024] Add JPMS E2E test

2020-09-21 Thread GitBox
kileys opened a new pull request #12899: URL: https://github.com/apache/beam/pull/12899 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] kileys commented on pull request #12899: [BEAM-8024] Add JPMS E2E test

2020-09-21 Thread GitBox
kileys commented on pull request #12899: URL: https://github.com/apache/beam/pull/12899#issuecomment-696393175 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-09-21 Thread GitBox
lukecwik commented on pull request #11856: URL: https://github.com/apache/beam/pull/11856#issuecomment-696392541 > Thanks @boyuanzz, it makes sense now why it didn't work. Unfortunately, I can't use V2 runner, because I want to run these tests in batch mode as well (V2 runner supports

[GitHub] [beam] TheNeuralBit commented on pull request #12896: Update indexing skips for pandas 1.x

2020-09-21 Thread GitBox
TheNeuralBit commented on pull request #12896: URL: https://github.com/apache/beam/pull/12896#issuecomment-696399245 Run Python_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robertwb opened a new pull request #12900: [BEAM-10941] Use standard sharding conventions for fileio writes.

2020-09-21 Thread GitBox
robertwb opened a new pull request #12900: URL: https://github.com/apache/beam/pull/12900 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] codecov[bot] edited a comment on pull request #12896: Update indexing skips for pandas 1.x

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12896: URL: https://github.com/apache/beam/pull/12896#issuecomment-696398122 # [Codecov](https://codecov.io/gh/apache/beam/pull/12896?src=pr=h1) Report > Merging [#12896](https://codecov.io/gh/apache/beam/pull/12896?src=pr=desc) into

[GitHub] [beam] boyuanzz commented on pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-21 Thread GitBox
boyuanzz commented on pull request #12888: URL: https://github.com/apache/beam/pull/12888#issuecomment-696410670 Discussed with Luke and Cham separately, we can get ride of `with_attributes` and `serialized_attribute_fn ` from both Read and Write. There are corresponding changes for

[GitHub] [beam] codecov[bot] edited a comment on pull request #12880: [BEAM-10933] Adjust GBK and Flatten types before creating the pipeline proto

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12880: URL: https://github.com/apache/beam/pull/12880#issuecomment-695346831 # [Codecov](https://codecov.io/gh/apache/beam/pull/12880?src=pr=h1) Report > Merging [#12880](https://codecov.io/gh/apache/beam/pull/12880?src=pr=desc) into

[GitHub] [beam] pabloem commented on pull request #12762: Ensuring that BigQuery jobs are tagged with the Dataflow step that launches them

2020-09-21 Thread GitBox
pabloem commented on pull request #12762: URL: https://github.com/apache/beam/pull/12762#issuecomment-696413272 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] trucleduc opened a new pull request #12902: [BEAM-10871] Fix FhirLROIT tests

2020-09-21 Thread GitBox
trucleduc opened a new pull request #12902: URL: https://github.com/apache/beam/pull/12902 **Please** add a meaningful description for your change here In #12721 , we delete all FHIR stores in the clean up which may interfere with other integration tests. This PR fixes this by only

[GitHub] [beam] TheNeuralBit commented on pull request #12902: [BEAM-10871] Fix FhirLROIT tests

2020-09-21 Thread GitBox
TheNeuralBit commented on pull request #12902: URL: https://github.com/apache/beam/pull/12902#issuecomment-696415795 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] ibzib commented on a change in pull request #12637: [BEAM-10768] Don't assert the order in which elements are received.

2020-09-21 Thread GitBox
ibzib commented on a change in pull request #12637: URL: https://github.com/apache/beam/pull/12637#discussion_r492386778 ## File path: sdks/python/apache_beam/runners/worker/data_plane_test.py ## @@ -108,16 +106,28 @@ def send(instruction_id, transform_id, data): ])

[GitHub] [beam] trucleduc commented on pull request #12902: [BEAM-10871] Fix FhirLROIT tests

2020-09-21 Thread GitBox
trucleduc commented on pull request #12902: URL: https://github.com/apache/beam/pull/12902#issuecomment-696417081 @TheNeuralBit Would you please hold on merging, I realized that there could be flakiness issue for the existing tests. I'll investigate.

[GitHub] [beam] trucleduc commented on pull request #12902: [BEAM-10871] Fix FhirLROIT tests

2020-09-21 Thread GitBox
trucleduc commented on pull request #12902: URL: https://github.com/apache/beam/pull/12902#issuecomment-696419895 @TheNeuralBit ok fixed. I tried to run the test 10 times and they all passed. This is an automated message

[GitHub] [beam] TheNeuralBit commented on pull request #12896: Update indexing skips for pandas 1.x

2020-09-21 Thread GitBox
TheNeuralBit commented on pull request #12896: URL: https://github.com/apache/beam/pull/12896#issuecomment-696422086 Run Python_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on pull request #12902: [BEAM-10871] Fix FhirLROIT tests

2020-09-21 Thread GitBox
TheNeuralBit commented on pull request #12902: URL: https://github.com/apache/beam/pull/12902#issuecomment-696421674 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aaltay commented on pull request #12892: [BEAM-10937] Add first introductory notebook

2020-09-21 Thread GitBox
aaltay commented on pull request #12892: URL: https://github.com/apache/beam/pull/12892#issuecomment-696425242 /cc @KevinGG This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12799: [BEAM-10603] Add record_pipeline, clear to RM and fix duration limiter

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12799: URL: https://github.com/apache/beam/pull/12799#issuecomment-692960218 # [Codecov](https://codecov.io/gh/apache/beam/pull/12799?src=pr=h1) Report > Merging [#12799](https://codecov.io/gh/apache/beam/pull/12799?src=pr=desc) into

[GitHub] [beam] pabloem commented on pull request #12782: Overriding Dataflow Native BQSource.

2020-09-21 Thread GitBox
pabloem commented on pull request #12782: URL: https://github.com/apache/beam/pull/12782#issuecomment-696442124 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] lukecwik commented on pull request #12794: [BEAM-10865] Support for Kafka deserialization API with headers (since Kafka API 2.1.0)

2020-09-21 Thread GitBox
lukecwik commented on pull request #12794: URL: https://github.com/apache/beam/pull/12794#issuecomment-696393557 > Thanks for the feedback and the merge Luke. I'll address the updates in a PR. > > I agree all tests makes more sense as one can never have enough coverage. That said,

[GitHub] [beam] chamikaramj commented on a change in pull request #12611: [BEAM-10139][BEAM-10140] Add cross-language support for Java SpannerIO with python wrapper

2020-09-21 Thread GitBox
chamikaramj commented on a change in pull request #12611: URL: https://github.com/apache/beam/pull/12611#discussion_r492364337 ## File path: sdks/python/apache_beam/io/gcp/spanner.py ## @@ -0,0 +1,504 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [beam] codecov[bot] edited a comment on pull request #12896: Update indexing skips for pandas 1.x

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12896: URL: https://github.com/apache/beam/pull/12896#issuecomment-696398122 # [Codecov](https://codecov.io/gh/apache/beam/pull/12896?src=pr=h1) Report > Merging [#12896](https://codecov.io/gh/apache/beam/pull/12896?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12896: Update indexing skips for pandas 1.x

2020-09-21 Thread GitBox
codecov[bot] commented on pull request #12896: URL: https://github.com/apache/beam/pull/12896#issuecomment-696398122 # [Codecov](https://codecov.io/gh/apache/beam/pull/12896?src=pr=h1) Report > Merging [#12896](https://codecov.io/gh/apache/beam/pull/12896?src=pr=desc) into

[GitHub] [beam] robertwb commented on pull request #12873: Remove experimental declarations from fileio.

2020-09-21 Thread GitBox
robertwb commented on pull request #12873: URL: https://github.com/apache/beam/pull/12873#issuecomment-696399851 Sure, we can keep it experimental a bit longer. I would like to fix https://github.com/apache/beam/pull/12900 though.

[GitHub] [beam] ibzib opened a new pull request #12901: Move ZetaSQL UDF tests into separate class.

2020-09-21 Thread GitBox
ibzib opened a new pull request #12901: URL: https://github.com/apache/beam/pull/12901 R: @amaliujia Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] TheNeuralBit commented on pull request #12721: [BEAM-10871] Add deidentify for FhirIO connector

2020-09-21 Thread GitBox
TheNeuralBit commented on pull request #12721: URL: https://github.com/apache/beam/pull/12721#issuecomment-696407136 I think this broke Fhir integration tests in PostCommit: https://ci-beam.apache.org/job/beam_PostCommit_Java/6624/

[GitHub] [beam] trucleduc commented on pull request #12721: [BEAM-10871] Add deidentify for FhirIO connector

2020-09-21 Thread GitBox
trucleduc commented on pull request #12721: URL: https://github.com/apache/beam/pull/12721#issuecomment-696408469 I guess the issue is because we delete all FHIR stores after test. I'll send a PR to fix it.

[GitHub] [beam] kennknowles commented on pull request #12877: Upgrade GCS IO to 2.1.5 and Google OAuth to 1.31.0

2020-09-21 Thread GitBox
kennknowles commented on pull request #12877: URL: https://github.com/apache/beam/pull/12877#issuecomment-696412239 Ran `./gradlew -Ppublishing -PjavaLinkageArtifactIds=beam-sdks-java-io-google-cloud-platform,beam-runners-google-cloud-dataflow-java :checkJavaLinkage > ~/tmp/linkage-after`

[GitHub] [beam] tvalentyn commented on pull request #12895: [BEAM-9372][BEAM-9980] Switches Flink VR suite to Py36 and makes the version configurable.

2020-09-21 Thread GitBox
tvalentyn commented on pull request #12895: URL: https://github.com/apache/beam/pull/12895#issuecomment-696411840 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] chamikaramj commented on a change in pull request #12880: [BEAM-10933] Adjust GBK and Flatten types before creating the pipeline proto

2020-09-21 Thread GitBox
chamikaramj commented on a change in pull request #12880: URL: https://github.com/apache/beam/pull/12880#discussion_r492380763 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py ## @@ -488,12 +497,15 @@ def run_pipeline(self, pipeline, options): #

[GitHub] [beam] trucleduc commented on pull request #12721: [BEAM-10871] Add deidentify for FhirIO connector

2020-09-21 Thread GitBox
trucleduc commented on pull request #12721: URL: https://github.com/apache/beam/pull/12721#issuecomment-696414909 Sent https://github.com/apache/beam/pull/12902 This is an automated message from the Apache Git Service. To

[GitHub] [beam] TheNeuralBit commented on pull request #12902: [BEAM-10871] Fix FhirLROIT tests

2020-09-21 Thread GitBox
TheNeuralBit commented on pull request #12902: URL: https://github.com/apache/beam/pull/12902#issuecomment-696417351 ok I'll hold off, thanks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] rohdesamuel commented on pull request #12799: [BEAM-10603] Add record_pipeline, clear to RM and fix duration limiter

2020-09-21 Thread GitBox
rohdesamuel commented on pull request #12799: URL: https://github.com/apache/beam/pull/12799#issuecomment-696426921 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit commented on pull request #12896: Update indexing skips for pandas 1.x

2020-09-21 Thread GitBox
TheNeuralBit commented on pull request #12896: URL: https://github.com/apache/beam/pull/12896#issuecomment-696430017 PVR_Flink is now disabled: https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Commit I don't think the failure is related.

[GitHub] [beam] TheNeuralBit merged pull request #12896: Update indexing skips for pandas 1.x

2020-09-21 Thread GitBox
TheNeuralBit merged pull request #12896: URL: https://github.com/apache/beam/pull/12896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] ibzib commented on pull request #12896: Update indexing skips for pandas 1.x

2020-09-21 Thread GitBox
ibzib commented on pull request #12896: URL: https://github.com/apache/beam/pull/12896#issuecomment-696436679 > PVR_Flink is now disabled: https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Commit I don't think the failure is related. That's unexpected.. I wonder if it

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12889: Dataframe wordcount example.

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12889: URL: https://github.com/apache/beam/pull/12889#issuecomment-696446965 # [Codecov](https://codecov.io/gh/apache/beam/pull/12889?src=pr=h1) Report > Merging [#12889](https://codecov.io/gh/apache/beam/pull/12889?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12900: [BEAM-10941] Use standard sharding conventions for fileio writes.

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12900: URL: https://github.com/apache/beam/pull/12900#issuecomment-696448479 # [Codecov](https://codecov.io/gh/apache/beam/pull/12900?src=pr=h1) Report > Merging [#12900](https://codecov.io/gh/apache/beam/pull/12900?src=pr=desc) into

[GitHub] [beam] chamikaramj commented on pull request #12880: [BEAM-10933] Adjust GBK type before creating the pipeline proto

2020-09-21 Thread GitBox
chamikaramj commented on pull request #12880: URL: https://github.com/apache/beam/pull/12880#issuecomment-696451661 Run Python_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #12762: Ensuring that BigQuery jobs are tagged with the Dataflow step that launches them

2020-09-21 Thread GitBox
pabloem commented on pull request #12762: URL: https://github.com/apache/beam/pull/12762#issuecomment-696456903 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #12782: Overriding Dataflow Native BQSource.

2020-09-21 Thread GitBox
pabloem commented on pull request #12782: URL: https://github.com/apache/beam/pull/12782#issuecomment-696456995 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12880: [BEAM-10933] Adjust GBK type before creating the pipeline proto

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12880: URL: https://github.com/apache/beam/pull/12880#issuecomment-695346831 # [Codecov](https://codecov.io/gh/apache/beam/pull/12880?src=pr=h1) Report > Merging [#12880](https://codecov.io/gh/apache/beam/pull/12880?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12880: [BEAM-10933] Adjust GBK type before creating the pipeline proto

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12880: URL: https://github.com/apache/beam/pull/12880#issuecomment-695346831 # [Codecov](https://codecov.io/gh/apache/beam/pull/12880?src=pr=h1) Report > Merging [#12880](https://codecov.io/gh/apache/beam/pull/12880?src=pr=desc) into

[GitHub] [beam] chamikaramj merged pull request #12880: [BEAM-10933] Adjust GBK type before creating the pipeline proto

2020-09-21 Thread GitBox
chamikaramj merged pull request #12880: URL: https://github.com/apache/beam/pull/12880 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] codecov[bot] edited a comment on pull request #12880: [BEAM-10933] Adjust GBK type before creating the pipeline proto

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12880: URL: https://github.com/apache/beam/pull/12880#issuecomment-695346831 # [Codecov](https://codecov.io/gh/apache/beam/pull/12880?src=pr=h1) Report > Merging [#12880](https://codecov.io/gh/apache/beam/pull/12880?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #9907: [BEAM-4091] Pass type hints in ptransform_fn

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #9907: URL: https://github.com/apache/beam/pull/9907#issuecomment-682206351 # [Codecov](https://codecov.io/gh/apache/beam/pull/9907?src=pr=h1) Report > Merging [#9907](https://codecov.io/gh/apache/beam/pull/9907?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on pull request #12895: [BEAM-9372][BEAM-9980] Switches Flink VR suite to Py36 and makes the version configurable.

2020-09-21 Thread GitBox
tvalentyn commented on pull request #12895: URL: https://github.com/apache/beam/pull/12895#issuecomment-696467526 Run Python Flink ValidatesRunner This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] aaltay commented on a change in pull request #9907: [BEAM-4091] Pass type hints in ptransform_fn

2020-09-21 Thread GitBox
aaltay commented on a change in pull request #9907: URL: https://github.com/apache/beam/pull/9907#discussion_r492447574 ## File path: sdks/python/apache_beam/options/pipeline_options.py ## @@ -476,6 +499,26 @@ def _add_argparse_args(cls, parser): 'time. NOTE: only

[GitHub] [beam] kennknowles commented on pull request #12877: Upgrade GCS IO to 2.1.5 and Google OAuth to 1.31.0

2020-09-21 Thread GitBox
kennknowles commented on pull request #12877: URL: https://github.com/apache/beam/pull/12877#issuecomment-696412239 Ran `./gradlew -Ppublishing -PjavaLinkageArtifactIds=beam-sdks-java-io-google-cloud-platform,beam-runners-google-cloud-dataflow-java :checkJavaLinkage > ~/tmp/linkage-after`

[GitHub] [beam] robertwb commented on pull request #12873: Remove experimental declarations from fileio.

2020-09-21 Thread GitBox
robertwb commented on pull request #12873: URL: https://github.com/apache/beam/pull/12873#issuecomment-696399851 Sure, we can keep it experimental a bit longer. I would like to fix https://github.com/apache/beam/pull/12900 though.

[GitHub] [beam] codecov[bot] edited a comment on pull request #12889: Dataframe wordcount example.

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12889: URL: https://github.com/apache/beam/pull/12889#issuecomment-696446965 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] kileys commented on pull request #12899: [BEAM-8024] Add JPMS E2E test

2020-09-21 Thread GitBox
kileys commented on pull request #12899: URL: https://github.com/apache/beam/pull/12899#issuecomment-696393175 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] TheNeuralBit merged pull request #12896: Update indexing skips for pandas 1.x

2020-09-21 Thread GitBox
TheNeuralBit merged pull request #12896: URL: https://github.com/apache/beam/pull/12896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] kennknowles merged pull request #12875: Clarify Beam's use of semantic versioning

2020-09-21 Thread GitBox
kennknowles merged pull request #12875: URL: https://github.com/apache/beam/pull/12875 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] udim commented on pull request #12893: [BEAM-6103] Enable BQ streaming insert timeouts

2020-09-21 Thread GitBox
udim commented on pull request #12893: URL: https://github.com/apache/beam/pull/12893#issuecomment-696321660 R: @chamikaramj This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-21 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r492220801 ## File path: sdks/python/apache_beam/transforms/environments.py ## @@ -252,6 +254,14 @@ def from_runner_api_parameter(payload, capabilities, artifacts,

[GitHub] [beam] ihji commented on pull request #12822: [BEAM-10880] Log error counts to debug BigQuery streaming insert requ…

2020-09-21 Thread GitBox
ihji commented on pull request #12822: URL: https://github.com/apache/beam/pull/12822#issuecomment-696326864 @ajamato PTAL. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] robertwb merged pull request #12889: Dataframe wordcount example.

2020-09-21 Thread GitBox
robertwb merged pull request #12889: URL: https://github.com/apache/beam/pull/12889 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] ibzib merged pull request #12876: [BEAM-10931] Remove obsolete ZetaSQL precommit Gradle task.

2020-09-21 Thread GitBox
ibzib merged pull request #12876: URL: https://github.com/apache/beam/pull/12876 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] chamikaramj commented on pull request #12880: [BEAM-10933] Adjust GBK and Flatten types before creating the pipeline proto

2020-09-21 Thread GitBox
chamikaramj commented on pull request #12880: URL: https://github.com/apache/beam/pull/12880#issuecomment-696230350 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions

2020-09-21 Thread GitBox
TheNeuralBit commented on a change in pull request #12830: URL: https://github.com/apache/beam/pull/12830#discussion_r492339081 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java ## @@ -239,6 +245,12 @@

[GitHub] [beam] TheNeuralBit commented on pull request #12721: [BEAM-10871] Add deidentify for FhirIO connector

2020-09-21 Thread GitBox
TheNeuralBit commented on pull request #12721: URL: https://github.com/apache/beam/pull/12721#issuecomment-696407136 I think this broke Fhir integration tests in PostCommit: https://ci-beam.apache.org/job/beam_PostCommit_Java/6624/

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12882: [BEAM-10814] DataframeTransform outputs elements

2020-09-21 Thread GitBox
TheNeuralBit commented on a change in pull request #12882: URL: https://github.com/apache/beam/pull/12882#discussion_r492219317 ## File path: sdks/python/apache_beam/dataframe/schemas.py ## @@ -55,17 +159,149 @@ def expand(self, pcoll): lambda batch:

[GitHub] [beam] aromanenko-dev commented on pull request #11459: [BEAM-2546] Add InfluxDbIO

2020-09-21 Thread GitBox
aromanenko-dev commented on pull request #11459: URL: https://github.com/apache/beam/pull/11459#issuecomment-696273839 The only minor thing that is missing - update of `CHANGES.md` about this new IO. This is an automated

[GitHub] [beam] lukecwik commented on pull request #12367: [BEAM-10564] Support more Avro field name formats when mapping to Jav…

2020-09-21 Thread GitBox
lukecwik commented on pull request #12367: URL: https://github.com/apache/beam/pull/12367#issuecomment-696223362 We have a merge on green policy so I have been rerunning the tests to get past a known issue. This is an

[GitHub] [beam] chamikaramj commented on a change in pull request #12611: [BEAM-10139][BEAM-10140] Add cross-language support for Java SpannerIO with python wrapper

2020-09-21 Thread GitBox
chamikaramj commented on a change in pull request #12611: URL: https://github.com/apache/beam/pull/12611#discussion_r492364337 ## File path: sdks/python/apache_beam/io/gcp/spanner.py ## @@ -0,0 +1,504 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [beam] abhiy13 commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

2020-09-21 Thread GitBox
abhiy13 commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r492474752 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/contextualtextio/RecordWithMetadata.java ## @@ -0,0 +1,85 @@ +/* + *

[GitHub] [beam] abhiy13 commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

2020-09-21 Thread GitBox
abhiy13 commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r492474814 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/contextualtextio/ContextualTextIO.java ## @@ -0,0 +1,631 @@ +/* + *

[GitHub] [beam] abhiy13 commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

2020-09-21 Thread GitBox
abhiy13 commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r492475231 ## File path: sdks/java/io/contextual-text-io/build.gradle ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [beam] abhiy13 commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

2020-09-21 Thread GitBox
abhiy13 commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r492474704 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/contextualtextio/ContextualTextIOSource.java ## @@ -0,0 +1,364 @@ +/*

[GitHub] [beam] abhiy13 commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

2020-09-21 Thread GitBox
abhiy13 commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r492474778 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/contextualtextio/ContextualTextIO.java ## @@ -0,0 +1,631 @@ +/* + *

[GitHub] [beam] robertwb commented on a change in pull request #12884: [BEAM-7746] Add type checking to coders

2020-09-21 Thread GitBox
robertwb commented on a change in pull request #12884: URL: https://github.com/apache/beam/pull/12884#discussion_r492465887 ## File path: sdks/python/apache_beam/coders/coder_impl.py ## @@ -725,7 +728,7 @@ def __init__(self, key_coder_impl, window_coder_impl):

[GitHub] [beam] codecov[bot] edited a comment on pull request #12645: [BEAM-10124] Add ContextualTextIO

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12645: URL: https://github.com/apache/beam/pull/12645#issuecomment-688630083 # [Codecov](https://codecov.io/gh/apache/beam/pull/12645?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@2b2b8e7`). [Click

[GitHub] [beam] robertwb commented on pull request #12884: [BEAM-7746] Add type checking to coders

2020-09-21 Thread GitBox
robertwb commented on pull request #12884: URL: https://github.com/apache/beam/pull/12884#issuecomment-696504555 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] robertwb commented on a change in pull request #12881: [BEAM-7746] Get mypy passing on runners.worker

2020-09-21 Thread GitBox
robertwb commented on a change in pull request #12881: URL: https://github.com/apache/beam/pull/12881#discussion_r492466948 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -119,10 +125,10 @@ class RunnerIOOperation(operations.Operation): def

[GitHub] [beam] codecov[bot] commented on pull request #12884: [BEAM-7746] Add type checking to coders

2020-09-21 Thread GitBox
codecov[bot] commented on pull request #12884: URL: https://github.com/apache/beam/pull/12884#issuecomment-696510544 # [Codecov](https://codecov.io/gh/apache/beam/pull/12884?src=pr=h1) Report > Merging [#12884](https://codecov.io/gh/apache/beam/pull/12884?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12889: Dataframe wordcount example.

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12889: URL: https://github.com/apache/beam/pull/12889#issuecomment-696446965 # [Codecov](https://codecov.io/gh/apache/beam/pull/12889?src=pr=h1) Report > Merging [#12889](https://codecov.io/gh/apache/beam/pull/12889?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12762: Ensuring that BigQuery jobs are tagged with the Dataflow step that launches them

2020-09-21 Thread GitBox
codecov[bot] commented on pull request #12762: URL: https://github.com/apache/beam/pull/12762#issuecomment-696459985 # [Codecov](https://codecov.io/gh/apache/beam/pull/12762?src=pr=h1) Report > Merging [#12762](https://codecov.io/gh/apache/beam/pull/12762?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12889: Dataframe wordcount example.

2020-09-21 Thread GitBox
codecov[bot] commented on pull request #12889: URL: https://github.com/apache/beam/pull/12889#issuecomment-696446965 # [Codecov](https://codecov.io/gh/apache/beam/pull/12889?src=pr=h1) Report > Merging [#12889](https://codecov.io/gh/apache/beam/pull/12889?src=pr=desc) into

[GitHub] [beam] chamikaramj commented on pull request #12880: [BEAM-10933] Adjust GBK type before creating the pipeline proto

2020-09-21 Thread GitBox
chamikaramj commented on pull request #12880: URL: https://github.com/apache/beam/pull/12880#issuecomment-696447942 Run Python_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robertwb merged pull request #12889: Dataframe wordcount example.

2020-09-21 Thread GitBox
robertwb merged pull request #12889: URL: https://github.com/apache/beam/pull/12889 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] udim commented on pull request #9907: [BEAM-4091] Pass type hints in ptransform_fn

2020-09-21 Thread GitBox
udim commented on pull request #9907: URL: https://github.com/apache/beam/pull/9907#issuecomment-696465531 PTAL, changes are in the last commit. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12645: [BEAM-10124] Add ContextualTextIO

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12645: URL: https://github.com/apache/beam/pull/12645#issuecomment-688630083 # [Codecov](https://codecov.io/gh/apache/beam/pull/12645?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@2b2b8e7`). [Click

[GitHub] [beam] abhiy13 commented on a change in pull request #12645: [BEAM-10124] Add ContextualTextIO

2020-09-21 Thread GitBox
abhiy13 commented on a change in pull request #12645: URL: https://github.com/apache/beam/pull/12645#discussion_r492475183 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/contextualtextio/RecordWithMetadata.java ## @@ -0,0 +1,84 @@ +/* + *

[GitHub] [beam] robertwb commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-21 Thread GitBox
robertwb commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r492422441 ## File path: sdks/python/apache_beam/runners/portability/stager.py ## @@ -119,6 +119,7 @@ def create_job_resources(options, # type: PipelineOptions

[GitHub] [beam] tvalentyn commented on pull request #12895: [BEAM-9372][BEAM-9980] Switches Flink VR suite to Py36 and makes the version configurable.

2020-09-21 Thread GitBox
tvalentyn commented on pull request #12895: URL: https://github.com/apache/beam/pull/12895#issuecomment-696458288 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] codecov[bot] edited a comment on pull request #12880: [BEAM-10933] Adjust GBK type before creating the pipeline proto

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12880: URL: https://github.com/apache/beam/pull/12880#issuecomment-695346831 # [Codecov](https://codecov.io/gh/apache/beam/pull/12880?src=pr=h1) Report > Merging [#12880](https://codecov.io/gh/apache/beam/pull/12880?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12900: [BEAM-10941] Use standard sharding conventions for fileio writes.

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12900: URL: https://github.com/apache/beam/pull/12900#issuecomment-696448479 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] tvalentyn commented on a change in pull request #12895: [BEAM-9372][BEAM-9980] Switches Flink VR suite to Py36 and makes the version configurable.

2020-09-21 Thread GitBox
tvalentyn commented on a change in pull request #12895: URL: https://github.com/apache/beam/pull/12895#discussion_r492360722 ## File path: sdks/python/test-suites/gradle.properties ## @@ -27,3 +27,6 @@ dataflow_chicago_taxi_example_task_py_versions=3.7 # direct test-suites

[GitHub] [beam] ibzib commented on a change in pull request #12637: [BEAM-10768] Don't assert the order in which elements are received.

2020-09-21 Thread GitBox
ibzib commented on a change in pull request #12637: URL: https://github.com/apache/beam/pull/12637#discussion_r492386778 ## File path: sdks/python/apache_beam/runners/worker/data_plane_test.py ## @@ -108,16 +106,28 @@ def send(instruction_id, transform_id, data): ])

[GitHub] [beam] TheNeuralBit commented on pull request #12896: Update indexing skips for pandas 1.x

2020-09-21 Thread GitBox
TheNeuralBit commented on pull request #12896: URL: https://github.com/apache/beam/pull/12896#issuecomment-696446062 I think that job is actually a new one added in https://github.com/apache/beam/pull/12898. There's still

[GitHub] [beam] codecov[bot] edited a comment on pull request #12900: [BEAM-10941] Use standard sharding conventions for fileio writes.

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12900: URL: https://github.com/apache/beam/pull/12900#issuecomment-696448479 # [Codecov](https://codecov.io/gh/apache/beam/pull/12900?src=pr=h1) Report > Merging [#12900](https://codecov.io/gh/apache/beam/pull/12900?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on pull request #12896: Update indexing skips for pandas 1.x

2020-09-21 Thread GitBox
tvalentyn commented on pull request #12896: URL: https://github.com/apache/beam/pull/12896#issuecomment-696457581 > That's unexpected.. I wonder if it was disabled accidentally (perhaps because of Python version removals?) Yes, sorry about that - I was testing my changes and ran a

[GitHub] [beam] codecov[bot] edited a comment on pull request #12880: [BEAM-10933] Adjust GBK type before creating the pipeline proto

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #12880: URL: https://github.com/apache/beam/pull/12880#issuecomment-695346831 # [Codecov](https://codecov.io/gh/apache/beam/pull/12880?src=pr=h1) Report > Merging [#12880](https://codecov.io/gh/apache/beam/pull/12880?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #9907: [BEAM-4091] Pass type hints in ptransform_fn

2020-09-21 Thread GitBox
codecov[bot] edited a comment on pull request #9907: URL: https://github.com/apache/beam/pull/9907#issuecomment-682206351 # [Codecov](https://codecov.io/gh/apache/beam/pull/9907?src=pr=h1) Report > Merging [#9907](https://codecov.io/gh/apache/beam/pull/9907?src=pr=desc) into

[GitHub] [beam] lukecwik commented on a change in pull request #12637: [BEAM-10768] Don't assert the order in which elements are received.

2020-09-21 Thread GitBox
lukecwik commented on a change in pull request #12637: URL: https://github.com/apache/beam/pull/12637#discussion_r492359619 ## File path: sdks/python/apache_beam/runners/worker/data_plane_test.py ## @@ -108,16 +106,28 @@ def send(instruction_id, transform_id, data):

[GitHub] [beam] tvalentyn commented on pull request #12898: [BEAM-7372][BEAM-9980] Cleans up Flink precommit VR suite definition and makes Python version configurable.

2020-09-21 Thread GitBox
tvalentyn commented on pull request #12898: URL: https://github.com/apache/beam/pull/12898#issuecomment-696385996 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

  1   2   3   4   >