[GitHub] [beam] TheNeuralBit commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-632327533 Something just occurred to me - are there any tests that use the DATE Type in an aggregation (e.g. MAX)? I'd think that would run into the same issue I have in #11456

[GitHub] [beam] TheNeuralBit commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-18 Thread GitBox
TheNeuralBit commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-630259464 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-15 Thread GitBox
TheNeuralBit commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-629422818 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-15 Thread GitBox
TheNeuralBit commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-629421832 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,