[GitHub] [beam] TheNeuralBit commented on pull request #11784: [BEAM-9971] Do not use context classloader.

2020-05-27 Thread GitBox


TheNeuralBit commented on pull request #11784:
URL: https://github.com/apache/beam/pull/11784#issuecomment-634747637


   Is the approach in this PR acceptable for the short-term (and for 2.22.0 
release branch)?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] TheNeuralBit commented on pull request #11784: [BEAM-9971] Do not use context classloader.

2020-05-26 Thread GitBox


TheNeuralBit commented on pull request #11784:
URL: https://github.com/apache/beam/pull/11784#issuecomment-634118385


   There's a ReflectHelpers class in core with some utility functions for 
loading services and finding class loaders: 
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/common/ReflectHelpers.java#L247
   
   Sorry if this is just noise, I don't have much context here, just thought 
I'd point it out in case its helpful.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org