[GitHub] [beam] alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options

2020-04-03 Thread GitBox
alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options URL: https://github.com/apache/beam/pull/10529#issuecomment-608389251 Thanks, now I can start working on the next parts and think about documentation. Hooray! ---

[GitHub] [beam] alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options

2020-04-02 Thread GitBox
alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options URL: https://github.com/apache/beam/pull/10529#issuecomment-607977285 @reuvenlax friendly reminder for reviewing the changes. It would be great if this would make the release (2.21) that will be cut in 6

[GitHub] [beam] alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options

2020-03-28 Thread GitBox
alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options URL: https://github.com/apache/beam/pull/10529#issuecomment-605491780 I've decided to add the removal of metadata usage in the proto implementation as an additional commit, this makes the PR bigger but i

[GitHub] [beam] alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options

2020-03-28 Thread GitBox
alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options URL: https://github.com/apache/beam/pull/10529#issuecomment-605465433 Run Java PreCommit This is an automated message from the Apache Git

[GitHub] [beam] alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options

2020-03-27 Thread GitBox
alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options URL: https://github.com/apache/beam/pull/10529#issuecomment-605251990 @reuvenlax if you don't have remarks (removing metadata will be in another PR) I can make a private build of master. I got a pipeline

[GitHub] [beam] alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options

2020-03-25 Thread GitBox
alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options URL: https://github.com/apache/beam/pull/10529#issuecomment-603977599 Run Java PreCommit This is an automated message from the Apache Git

[GitHub] [beam] alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options

2020-03-25 Thread GitBox
alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options URL: https://github.com/apache/beam/pull/10529#issuecomment-603781120 Run Java PreCommit This is an automated message from the Apache Git