[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-15 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-644417719 thanks @perkss! I'm quite happy to get tests on the examples! This is an automated message from the Apache Git

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-15 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-644351342 that's right @perkss it looks like an unrelated issue, so I'll just run 'till I get a passing run and merge

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-15 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-644256943 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-14 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643807039 great! thanks for pointhing that out This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-14 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643807080 let me get a passing run for the tests and we'll merge This is an automated message from the Apache Git Service.

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-13 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643680979 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-13 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643680465 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643470778 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643452551 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643450395 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643436010 RAT Precommit - can you please add an Apache License header to any new files? (you can copy the header from other kotlin files)

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643424085 retest this please This is an automated message from the Apache Git Service. To respond to the message, please